From patchwork Fri Aug 20 22:46:13 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Leann Ogasawara X-Patchwork-Id: 62326 X-Patchwork-Delegate: leann.ogasawara@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id B14E9B70DF for ; Sat, 21 Aug 2010 08:46:42 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OmaM9-0006kV-Ny; Fri, 20 Aug 2010 23:46:37 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1OmaM4-0006cf-Sg for kernel-team@lists.ubuntu.com; Fri, 20 Aug 2010 23:46:33 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1OmaM3-0004Yk-UF; Fri, 20 Aug 2010 23:46:32 +0100 Received: from 173-164-72-174-oregon.hfc.comcastbusiness.net ([173.164.72.174] helo=[10.1.0.4]) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1OmaM3-0005XH-8i; Fri, 20 Aug 2010 23:46:31 +0100 Subject: Re: [PATCH 2/2] UBUNTU: [Config] build-in uinput module From: Leann Ogasawara To: tim.gardner@canonical.com In-Reply-To: <4C6BDAAD.4040100@canonical.com> References: <1282125271.46458.748451972634.2.gpush@pororo> <4C6BDAAD.4040100@canonical.com> Date: Fri, 20 Aug 2010 15:46:13 -0700 Message-ID: <1282344373.4512.1285.camel@emiko> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 Cc: Jeremy Kerr , kernel-team@lists.ubuntu.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com On Wed, 2010-08-18 at 07:05 -0600, Tim Gardner wrote: > On 08/18/2010 03:54 AM, Jeremy Kerr wrote: > > The bluetooth userspace tools can use /dev/uinput to report events > > from bluetooth input devices (eg volume up/down controls on a BT > > headset). > > > > However, the uinput module is not loaded automatically, as there is no > > physical device to match on. Consequently, we don't have the uinput > > device node present when the bluetooth daemon starts, and no synthesized > > BT events are reported. > > > > Instead of compiling uinput as a module, this change builds it into the > > kernel, so it is always available. > > > > BugLink: http://bugs.launchpad.net/bugs/584812 > > > > Signed-off-by: Jeremy Kerr > > > > --- > > debian.master/config/config.common.ports | 2 +- > > debian.master/config/config.common.ubuntu | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports > > index a983a52..95bb3c8 100644 > > --- a/debian.master/config/config.common.ports > > +++ b/debian.master/config/config.common.ports > > @@ -1515,7 +1515,7 @@ CONFIG_INPUT_TWL4030_PWRBUTTON=m > > CONFIG_INPUT_TWL4030_VIBRA=m > > CONFIG_INPUT_WM831X_ON=m > > CONFIG_INPUT_YEALINK=m > > -CONFIG_INPUT_UINPUT=m > > +CONFIG_INPUT_UINPUT=y > > CONFIG_IOMMU_API=y > > CONFIG_IOMMU_HELPER=y > > CONFIG_IOSAPIC=y > > diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu > > index 9e40bac..7a84e2b 100644 > > --- a/debian.master/config/config.common.ubuntu > > +++ b/debian.master/config/config.common.ubuntu > > @@ -1966,7 +1966,7 @@ CONFIG_INPUT_SPARSEKMAP=m > > CONFIG_INPUT_TABLET=y > > CONFIG_INPUT_TWL4030_PWRBUTTON=m > > CONFIG_INPUT_TWL4030_VIBRA=m > > -CONFIG_INPUT_UINPUT=m > > +CONFIG_INPUT_UINPUT=y > > CONFIG_INPUT_WINBOND_CIR=m > > CONFIG_INPUT_WISTRON_BTNS=m > > CONFIG_INPUT_WM831X_ON=m > > > > Again, the implication is that this patch is for Maverick. Should this > config option be added to the enforcer so we don't lose it in subsequent > releases? > > Acked-by: Tim Gardner I've gone ahead and added this to the config enforcer as well. >From c87b9e3698d8a5a358c398103c173c842dfa4800 Mon Sep 17 00:00:00 2001 From: Leann Ogasawara Date: Fri, 20 Aug 2010 12:03:22 -0700 Subject: [PATCH] UBUNTU: [Config] Add CONFIG_INPUT_UINPUT=y to config enforcer BugLink: http://bugs.launchpad.net/bugs/584812 The uinput module is not loaded automatically, as there is no physical device to match on. Ensure that it's built into the kernel so that it's always available. Signed-off-by: Leann Ogasawara --- debian.master/config/enforce | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/debian.master/config/enforce b/debian.master/config/enforce index 644caee..4e5e7f8 100644 --- a/debian.master/config/enforce +++ b/debian.master/config/enforce @@ -55,3 +55,6 @@ value CONFIG_FRAMEBUFFER_CONSOLE y # UbuntuSpec:foundations-m-grub2-boot-framebuffer (( arch i386 | arch amd64 ) & value CONFIG_FB_VESA y) | \ value CONFIG_FB_VESA m | !exists CONFIG_FB_VESA + +# Build in uinput module so that it's always available (LP: 584812) +value CONFIG_INPUT_UINPUT y