From patchwork Mon Apr 26 20:08:09 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chase Douglas X-Patchwork-Id: 51000 X-Patchwork-Delegate: apw@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id 5572AB7D52 for ; Tue, 27 Apr 2010 06:08:23 +1000 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1O6UbE-0001Uz-GJ; Mon, 26 Apr 2010 21:08:12 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1O6UbD-0001US-Gl for kernel-team@lists.ubuntu.com; Mon, 26 Apr 2010 21:08:11 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1O6UbD-00060U-FB for ; Mon, 26 Apr 2010 21:08:11 +0100 Received: from cpe-75-180-27-10.columbus.res.rr.com ([75.180.27.10] helo=canonical.com) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1O6UbD-0006Ai-48 for kernel-team@lists.ubuntu.com; Mon, 26 Apr 2010 21:08:11 +0100 From: Chase Douglas To: kernel-team@lists.ubuntu.com Subject: [Lucid][PATCH] UBUNTU: Enable ftrace function profiler Date: Mon, 26 Apr 2010 16:08:09 -0400 Message-Id: <1272312489-4641-1-git-send-email-chase.douglas@canonical.com> X-Mailer: git-send-email 1.7.0.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com SRU Justification: Impact: Without function profiling we may have a more difficult time resolving performance issues. How Addressed: The ftrace function profiler is turned on in the common kernel configs. Reproduction: No ftrace function profiling is possible on current Ubuntu 10.04 LTS kernel. If it were, the file /sys/kernel/debug/tracing/function_profile_enabled would exist. Regression Potential: Enabling this functionality is an added bonus to Ubuntu that should not cause any regressions. Further, regressions should be localized to the ftrace subsystem, which will not affect the vast majority of users. Acked-by: Tim Gardner Acked-by: Colin King ===== The ftrace framework has profiling capabilities that will be useful in tracking desktop responsiveness. As an example, profiling can tell us how many times an ISR is run, and how long the average run time is. This option will not have any performance impact. When turned on at runtime, a small performance impact may be seen, and a few hundred KB per cpu of buffer pages will be allocated and used. Extremely brief overview: echo 1 > /sys/kernel/debug/tracing/function_profile_enabled ... run tests ... echo 0 > /sys/kernel/debug/tracing/function_profile_enabled cat /sys/kernel/debug/tracing/trace_stat/function0 (suffix: cpu #) BugLink: http://bugs.launchpad.net/bugs/570389 Signed-off-by: Chase Douglas --- debian.master/config/config.common.ports | 2 +- debian.master/config/config.common.ubuntu | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/debian.master/config/config.common.ports b/debian.master/config/config.common.ports index 6e1517c..10d5189 100644 --- a/debian.master/config/config.common.ports +++ b/debian.master/config/config.common.ports @@ -1006,7 +1006,7 @@ CONFIG_FTRACE_MCOUNT_RECORD=y # CONFIG_FTRACE_STARTUP_TEST is not set # CONFIG_FTR_FIXUP_SELFTEST is not set CONFIG_FUNCTION_GRAPH_TRACER=y -# CONFIG_FUNCTION_PROFILER is not set +CONFIG_FUNCTION_PROFILER=y CONFIG_FUNCTION_TRACER=y CONFIG_FUSE_FS=y CONFIG_FUSION=y diff --git a/debian.master/config/config.common.ubuntu b/debian.master/config/config.common.ubuntu index bbefa4a..f5876c2 100644 --- a/debian.master/config/config.common.ubuntu +++ b/debian.master/config/config.common.ubuntu @@ -1232,7 +1232,7 @@ CONFIG_FTRACE_NMI_ENTER=y CONFIG_FUJITSU_LAPTOP=m # CONFIG_FUJITSU_LAPTOP_DEBUG is not set CONFIG_FUNCTION_GRAPH_TRACER=y -# CONFIG_FUNCTION_PROFILER is not set +CONFIG_FUNCTION_PROFILER=y CONFIG_FUNCTION_TRACER=y CONFIG_FUSE_FS=y CONFIG_FUSION=y