From patchwork Thu Apr 1 10:56:06 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bryan Wu X-Patchwork-Id: 49204 X-Patchwork-Delegate: apw@canonical.com Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from chlorine.canonical.com (chlorine.canonical.com [91.189.94.204]) by ozlabs.org (Postfix) with ESMTP id EFC38B7C06 for ; Thu, 1 Apr 2010 21:57:06 +1100 (EST) Received: from localhost ([127.0.0.1] helo=chlorine.canonical.com) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1NxI58-0001eu-H1; Thu, 01 Apr 2010 11:57:02 +0100 Received: from adelie.canonical.com ([91.189.90.139]) by chlorine.canonical.com with esmtp (Exim 4.69) (envelope-from ) id 1NxI57-0001e0-70 for kernel-team@lists.ubuntu.com; Thu, 01 Apr 2010 11:57:01 +0100 Received: from hutte.canonical.com ([91.189.90.181]) by adelie.canonical.com with esmtp (Exim 4.69 #1 (Debian)) id 1NxI57-00006l-4t for ; Thu, 01 Apr 2010 11:57:01 +0100 Received: from [218.82.233.81] (helo=canonical.com) by hutte.canonical.com with esmtpsa (TLS-1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1NxI55-0005bg-Qv for kernel-team@lists.ubuntu.com; Thu, 01 Apr 2010 11:57:01 +0100 From: Bryan Wu To: kernel-team@lists.ubuntu.com Subject: [PATCH 2/2] netdev/fec.c: fix timeout warning message Date: Thu, 1 Apr 2010 18:56:06 +0800 Message-Id: <1270119366-6301-3-git-send-email-bryan.wu@canonical.com> X-Mailer: git-send-email 1.7.0 In-Reply-To: <1270119366-6301-1-git-send-email-bryan.wu@canonical.com> References: <1270119366-6301-1-git-send-email-bryan.wu@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.9 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Sender: kernel-team-bounces@lists.ubuntu.com Errors-To: kernel-team-bounces@lists.ubuntu.com BugLink: http://bugs.launchpad.net/bugs/546649 BugLink: http://bugs.launchpad.net/bugs/457878 We will get lots of timeout error message when transfer large file. It is not an error, just a warning and it is not an impact to performance. So set the printk message level as warning not an error. Signed-off-by: Bryan Wu --- drivers/net/fec.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/fec.c b/drivers/net/fec.c index 53240d3..92a67a1 100644 --- a/drivers/net/fec.c +++ b/drivers/net/fec.c @@ -644,7 +644,7 @@ static int fec_enet_mdio_read(struct mii_bus *bus, int mii_id, int regnum) cpu_relax(); if (timeout-- < 0) { fep->mii_timeout = 1; - printk(KERN_ERR "FEC: MDIO read timeout\n"); + printk(KERN_WARNING "FEC: MDIO read timeout\n"); return -ETIMEDOUT; } } @@ -675,7 +675,7 @@ static int fec_enet_mdio_write(struct mii_bus *bus, int mii_id, int regnum, cpu_relax(); if (timeout-- < 0) { fep->mii_timeout = 1; - printk(KERN_ERR "FEC: MDIO write timeout\n"); + printk(KERN_WARNING "FEC: MDIO write timeout\n"); return -ETIMEDOUT; } }