From patchwork Tue Apr 2 14:14:30 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Thompson X-Patchwork-Id: 1918855 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4V88zc3hF2z1yY4 for ; Wed, 3 Apr 2024 01:15:24 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1rreux-0004IP-Th; Tue, 02 Apr 2024 14:15:15 +0000 Received: from mail-co1nam11on2063.outbound.protection.outlook.com ([40.107.220.63] helo=NAM11-CO1-obe.outbound.protection.outlook.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1rreuv-0004Gk-7C for kernel-team@lists.ubuntu.com; Tue, 02 Apr 2024 14:15:13 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dRhuplryCMaLRqSKb5IcCWBHzfVun8HhomD01qtw+MnS9mIpXzNTQN4JtIHzVU4cCVL1qXxQd7JXz8v0ltSzL7oYmfaguwOlmC1l9ftJXzkvge1VUtVNtD1iKe0YoFZLkiuYwMJnw0OrYs6U1O2NtcCFkh2Dwyl7x/PMes7A6Ta/Ri5aET2KRkKwWT7J7o5jL8HoHvrh6Vu8agrYE576kMyZ1fdlnHT8jVnCM1zWP3ehdCh/0BH84d9DIhhJTje98p/AsKU5GbKoUFi2bwRIby70DKsofcOiFA10zJHxYSYYeb7VwBrbp3cPWfZUTfd76CnbffrH16paTT5752IqQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=QJYYCCGG8rws67jaRg8wDaBTFmlPUqusC97D9VGuQkQ=; b=lUaO3SCiPJo/S6UKptOKb4pUgdy9JApWBw4bOQimm9aUAX3K78nYQ7J6eLH89IgllbYt2AVrs3WwkWtBnJSLESR2G8H/j8TGQbK7jLXMbHoOUw8Cl03d31Tr0tYH1k7LvYblVBcOV6NK5S/8Jhhhiak2yKly8g4elLYLwaWjnp/EtSY+OOcXkqJscmmI5izEHxC3foSvyJxFaR86Ii0FVl/B+jnHsjZNRcvLpRSlKr/QSvTMhrzbdX52/+jmNsXBkXWvgZlfnAE+g0wdJoIoq7lyGVikgyg9toqIq2Fc5lykdSnZ62Ewpy0ujVOJdmb5TAEPwj61z7+1BVi9Pq0tAQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=lists.ubuntu.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) Received: from SJ0PR13CA0020.namprd13.prod.outlook.com (2603:10b6:a03:2c0::25) by IA1PR12MB8336.namprd12.prod.outlook.com (2603:10b6:208:3fc::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Tue, 2 Apr 2024 14:14:45 +0000 Received: from SJ5PEPF000001CF.namprd05.prod.outlook.com (2603:10b6:a03:2c0:cafe::58) by SJ0PR13CA0020.outlook.office365.com (2603:10b6:a03:2c0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.25 via Frontend Transport; Tue, 2 Apr 2024 14:14:44 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ5PEPF000001CF.mail.protection.outlook.com (10.167.242.43) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Tue, 2 Apr 2024 14:14:44 +0000 Received: from rnnvmail205.nvidia.com (10.129.68.10) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 2 Apr 2024 07:14:33 -0700 Received: from rnnvmail202.nvidia.com (10.129.68.7) by rnnvmail205.nvidia.com (10.129.68.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Tue, 2 Apr 2024 07:14:32 -0700 Received: from vdi.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.7) with Microsoft SMTP Server id 15.2.1258.12 via Frontend Transport; Tue, 2 Apr 2024 07:14:32 -0700 From: David Thompson To: Subject: [SRU][J:linux-bluefield][PATCH v1 0/1] mlxbf_gige: stop interface during shutdown Date: Tue, 2 Apr 2024 10:14:30 -0400 Message-ID: X-Mailer: git-send-email 2.30.1 MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ5PEPF000001CF:EE_|IA1PR12MB8336:EE_ X-MS-Office365-Filtering-Correlation-Id: a6dcb57f-2190-454d-1922-08dc531f3eeb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Dr0MknuxbrVH6q+fbiCPks/SykFkyV2nI+okfe2SxQE1pdCFbJ0kF5xY/NyZblUoKWubIP8J8lo4SydOWGeCz84F92CR87RkovTOPhM9BhPrzc7i5BjDvZc/qHbmTqDM/64N1Zbg2k//bYj/ZTS8adnW4GBbWvyXSnide8zP/AZ5yWYyZfnAhdE4imYztWiXzibuRIDy8gX/bXLOSL8uTgPaF7HN2acFSICxOa8Pd6wFC3PP/su8m4oXzdKUGkm0yCxJS8/0aVP2aeGAMj/GJ9O5osy7Cp6ExveAnbDazY9Ysw0lqMAzY0ZMsYFgmy2yCQILxFOHHAO+3bBo9vqTQcXfcXk2w7FlkTjSjrxHZtiwgIzDHQZGKqABM3M0WvsWlBTMxmOud1keDmQbIMYAOjdGJaYCFk2KPoTii3LtWq045Hoqt5iT7wD+eTravOprgLQCczPvJe7Bq9Z4H8a3WIPPJW5IHClNnTBGAWUB6p5KHLaqYJ4Rhccc/SaHGnnYHUN4QmRRzfC0IQ6wNtrw9g84c7ytqqn5ElD71bqIcGIiuB7TGimvuCx1hLKnWFWXVMph2CpeqvgpuqVNJ3jCi21rnmjsQFpxfMJ4nCMlhnvA7Eu3Vv4hA59z+C+v7HEy/YtNSpmD9Z9A1cu3xq0LE4yZUi8eiKlNI/cu7r22OcEKusmwZZ1HrC9vfCOxkBlZjQvmepXBvmm7/ZiFbztUmkFLyQIWyWdIWlR/GoffEf9P0fEx8l6Bi2fCDPjsL6Ph X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2024 14:14:44.3985 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a6dcb57f-2190-454d-1922-08dc531f3eeb X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ5PEPF000001CF.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8336 Received-SPF: softfail client-ip=40.107.220.63; envelope-from=davthompson@nvidia.com; helo=NAM11-CO1-obe.outbound.protection.outlook.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: asmaa@nvidia.com, davthompson@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2059951 SRU Justification: [Impact] The mlxbf_gige driver shutdown() is invoked during reboot processing, but the stop() logic is not guaranteed to execute on all distros. If stop() does not execute NAPI remains enabled during system shutdown and can cause an exception if NAPI is scheduled when interface is shutdown but not stopped. [Fix] The networking interface managed by the mlxbf_gige driver must be stopped during reboot processing so that it is put into a clean state and driver callbacks won't be called. [Test Case] * Put BF platform into a reboot loop * Ensure that BF platform brings up "oob_net0" interface each reboot, and that no mlxbf_gige driver exceptions occur [Regression Potential] There is low potential for regression as this brings in upstream content. [Other] None David Thompson (1): mlxbf_gige: stop interface during shutdown .../net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) Acked-by: Bartlomiej Zolnierkiewicz Acked-by: Jose Ogando