From patchwork Wed Apr 10 11:29:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guoqing Jiang X-Patchwork-Id: 1921930 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4VF0yL09nLz1yYB for ; Wed, 10 Apr 2024 21:31:05 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ruWAH-0007pU-MU; Wed, 10 Apr 2024 11:30:53 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ruWAF-0007oL-8y for kernel-team@lists.ubuntu.com; Wed, 10 Apr 2024 11:30:51 +0000 Received: from localhost.localdomain (1.general.gjiang.uk.vpn [10.172.198.26]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 776EB3F158 for ; Wed, 10 Apr 2024 11:30:46 +0000 (UTC) From: Guoqing Jiang To: kernel-team@lists.ubuntu.com Subject: [SRU][M][PATCH 0/2] Fix proc_sched_rt01 issue in LTP Date: Wed, 10 Apr 2024 19:29:18 +0800 Message-Id: <20240410112920.33436-1-guoqing.jiang@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" SRU justification BugLink: https://bugs.launchpad.net/bugs/2057734 [Impact] The updated LTP has added proc_sched_rt01 testcase which can't pass since several commits are missed from kernel side. Test log: INFO: Test start time: Tue Mar 12 11:52:21 UTC 2024 COMMAND: /opt/ltp/bin/ltp-pan -q -e -S -a 163430 -n 163430 -f /tmp/ltp-X3Nz2HWCQe/alltests -l /dev/null -C /dev/null -T /dev/null LOG File: /dev/null FAILED COMMAND File: /dev/null TCONF COMMAND File: /dev/null Running tests....... tst_kconfig.c:87: TINFO: Parsing kernel config '/lib/modules/6.5.0-27-generic/build/.config' tst_test.c:1741: TINFO: LTP version: 20230929-406-gcbc2d0568 tst_test.c:1625: TINFO: Timeout per run is 0h 00m 30s proc_sched_rt01.c:45: TFAIL: Expect: timeslice_ms > 0 after reset to default proc_sched_rt01.c:51: TPASS: echo 0 > /proc/sys/kernel/sched_rt_period_us : EINVAL (22) proc_sched_rt01.c:53: TFAIL: echo -1 > /proc/sys/kernel/sched_rt_period_us invalid retval 2: SUCCESS (0) proc_sched_rt01.c:59: TPASS: echo -2 > /proc/sys/kernel/sched_rt_runtime_us : EINVAL (22) proc_sched_rt01.c:72: TFAIL: echo rt_period_us+1 > /proc/sys/kernel/sched_rt_runtime_us invalid retval 1: SUCCESS (0) HINT: You _MAY_ be missing kernel fixes: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c1fc6484e1fb https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=079be8fc6309 [Fix] There are 3 relevant commits from upstream. 1. 079be8fc6309 sched/rt: Disallow writing invalid values to sched_rt_period_us 2. c1fc6484e1fb sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset 3. c7fcb99877f9 sched/rt: Fix sysctl_sched_rr_timeslice intial value Mantic: the 3rd is already in master-next. Jammy: stable v5.15.150 includes the three commits. Focal: master-next has include them after update to v5.4.270 [Test case] Run LTP update 20240312 to check the log of proc_sched_rt01. [Regression potential] Low risk since these content are existed in upstream for a while. Cyril Hrubis (2): sched/rt: sysctl_sched_rr_timeslice show default timeslice after reset sched/rt: Disallow writing invalid values to sched_rt_period_us kernel/sched/rt.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) Acked-by: Thibault Ferrante Acked-by: Po-Hsu Lin