| Message ID | 20240405134646.200849-1-roxana.nicolescu@canonical.com |
|---|---|
| Headers | show |
| Series | Include cifs.ko in linux-modules package | expand |
On 4/5/24 7:46 AM, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2042546 > > [Impact] > > Commit: "smb: move client and server files to common directory fs/smb" > moved the fs/cifs directory to fs/sb/client. The inclusion list for > linux-modules was not updated, it still contains the old path. This means > that the cifs.ko module cannot be loaded if only linux-modules package is > installed, now being part of linux-modules-extra. For the main kernels > this is not a problem because linux-modules-extra is always installed, but > for derivatives like aws, azure etc ,this module cannot be loaded without > explicitly installing linux-modules-extra. > > [How to reproduce it]: > 1. Install the latest azure kernel 6.5.0-1017.17 > 2. Load cifs module > $ modprobe cifs > modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure > If modules-extra is installed, this works. > > [Fix] > > Replace fs/cifs/* with fs/smb/* in > debian.<derivative>/control.d/<derivative>.inclusion-list. > First the main kernels are addressed, derivatives will be fixed via cranky fix. > > [Test Plan] > > 1. Apply the fix to one of the derivative (azure), build a new kernel and > install it > 2. Load cifs module > $ modprobe cifs > It should work without installing modules-extra. > > [Regression potential] > > Very low, it's a straightforward fix. > > [Other Info] > Sending a patch for every derivative takes time and each derivative will > be fixed once this proposal is acked via cranky fix. > > [Changes since v1] > Include the whole smb directory to include the server too > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Replace fs/cifs with fs/smb/client in inclusion > list > > debian.master/control.d/generic.inclusion-list | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Tim Gardner <tim.gardner@canonical.com>
On Fri, Apr 05, 2024 at 03:46:45PM +0200, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2042546 > > [Impact] > > Commit: "smb: move client and server files to common directory fs/smb" > moved the fs/cifs directory to fs/sb/client. The inclusion list for > linux-modules was not updated, it still contains the old path. This means > that the cifs.ko module cannot be loaded if only linux-modules package is > installed, now being part of linux-modules-extra. For the main kernels > this is not a problem because linux-modules-extra is always installed, but > for derivatives like aws, azure etc ,this module cannot be loaded without > explicitly installing linux-modules-extra. > > [How to reproduce it]: > 1. Install the latest azure kernel 6.5.0-1017.17 > 2. Load cifs module > $ modprobe cifs > modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure > If modules-extra is installed, this works. > > [Fix] > > Replace fs/cifs/* with fs/smb/* in > debian.<derivative>/control.d/<derivative>.inclusion-list. > First the main kernels are addressed, derivatives will be fixed via cranky fix. > > [Test Plan] > > 1. Apply the fix to one of the derivative (azure), build a new kernel and > install it > 2. Load cifs module > $ modprobe cifs > It should work without installing modules-extra. > > [Regression potential] > > Very low, it's a straightforward fix. > > [Other Info] > Sending a patch for every derivative takes time and each derivative will > be fixed once this proposal is acked via cranky fix. > > [Changes since v1] > Include the whole smb directory to include the server too > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Replace fs/cifs with fs/smb/client in inclusion > list > > debian.master/control.d/generic.inclusion-list | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > -- > 2.34.1 > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
On 05/04/2024 15:46, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2042546 > > [Impact] > > Commit: "smb: move client and server files to common directory fs/smb" > moved the fs/cifs directory to fs/sb/client. The inclusion list for > linux-modules was not updated, it still contains the old path. This means > that the cifs.ko module cannot be loaded if only linux-modules package is > installed, now being part of linux-modules-extra. For the main kernels > this is not a problem because linux-modules-extra is always installed, but > for derivatives like aws, azure etc ,this module cannot be loaded without > explicitly installing linux-modules-extra. > > [How to reproduce it]: > 1. Install the latest azure kernel 6.5.0-1017.17 > 2. Load cifs module > $ modprobe cifs > modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure > If modules-extra is installed, this works. > > [Fix] > > Replace fs/cifs/* with fs/smb/* in > debian.<derivative>/control.d/<derivative>.inclusion-list. > First the main kernels are addressed, derivatives will be fixed via cranky fix. > > [Test Plan] > > 1. Apply the fix to one of the derivative (azure), build a new kernel and > install it > 2. Load cifs module > $ modprobe cifs > It should work without installing modules-extra. > > [Regression potential] > > Very low, it's a straightforward fix. > > [Other Info] > Sending a patch for every derivative takes time and each derivative will > be fixed once this proposal is acked via cranky fix. > > [Changes since v1] > Include the whole smb directory to include the server too > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Replace fs/cifs with fs/smb/client in inclusion > list > > debian.master/control.d/generic.inclusion-list | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to mantic master-next branch. Thanks!
On 05/04/2024 15:46, Roxana Nicolescu wrote: > BugLink: https://bugs.launchpad.net/bugs/2042546 > > [Impact] > > Commit: "smb: move client and server files to common directory fs/smb" > moved the fs/cifs directory to fs/sb/client. The inclusion list for > linux-modules was not updated, it still contains the old path. This means > that the cifs.ko module cannot be loaded if only linux-modules package is > installed, now being part of linux-modules-extra. For the main kernels > this is not a problem because linux-modules-extra is always installed, but > for derivatives like aws, azure etc ,this module cannot be loaded without > explicitly installing linux-modules-extra. > > [How to reproduce it]: > 1. Install the latest azure kernel 6.5.0-1017.17 > 2. Load cifs module > $ modprobe cifs > modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure > If modules-extra is installed, this works. > > [Fix] > > Replace fs/cifs/* with fs/smb/* in > debian.<derivative>/control.d/<derivative>.inclusion-list. > First the main kernels are addressed, derivatives will be fixed via cranky fix. > > [Test Plan] > > 1. Apply the fix to one of the derivative (azure), build a new kernel and > install it > 2. Load cifs module > $ modprobe cifs > It should work without installing modules-extra. > > [Regression potential] > > Very low, it's a straightforward fix. > > [Other Info] > Sending a patch for every derivative takes time and each derivative will > be fixed once this proposal is acked via cranky fix. > > [Changes since v1] > Include the whole smb directory to include the server too > > Roxana Nicolescu (1): > UBUNTU: [Packaging] Replace fs/cifs with fs/smb/client in inclusion > list > > debian.master/control.d/generic.inclusion-list | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to noble master-next branch. Thanks!
BugLink: https://bugs.launchpad.net/bugs/2042546 [Impact] Commit: "smb: move client and server files to common directory fs/smb" moved the fs/cifs directory to fs/sb/client. The inclusion list for linux-modules was not updated, it still contains the old path. This means that the cifs.ko module cannot be loaded if only linux-modules package is installed, now being part of linux-modules-extra. For the main kernels this is not a problem because linux-modules-extra is always installed, but for derivatives like aws, azure etc ,this module cannot be loaded without explicitly installing linux-modules-extra. [How to reproduce it]: 1. Install the latest azure kernel 6.5.0-1017.17 2. Load cifs module $ modprobe cifs modprobe: FATAL: Module cifs not found in directory /lib/modules/6.5.0-1017-azure If modules-extra is installed, this works. [Fix] Replace fs/cifs/* with fs/smb/* in debian.<derivative>/control.d/<derivative>.inclusion-list. First the main kernels are addressed, derivatives will be fixed via cranky fix. [Test Plan] 1. Apply the fix to one of the derivative (azure), build a new kernel and install it 2. Load cifs module $ modprobe cifs It should work without installing modules-extra. [Regression potential] Very low, it's a straightforward fix. [Other Info] Sending a patch for every derivative takes time and each derivative will be fixed once this proposal is acked via cranky fix. [Changes since v1] Include the whole smb directory to include the server too Roxana Nicolescu (1): UBUNTU: [Packaging] Replace fs/cifs with fs/smb/client in inclusion list debian.master/control.d/generic.inclusion-list | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)