From patchwork Thu Mar 7 18:32:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philip Cox X-Patchwork-Id: 1909437 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=185.125.189.65; helo=lists.ubuntu.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=patchwork.ozlabs.org) Received: from lists.ubuntu.com (lists.ubuntu.com [185.125.189.65]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4TrHwQ13cLz1yWy for ; Fri, 8 Mar 2024 05:32:37 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=lists.ubuntu.com) by lists.ubuntu.com with esmtp (Exim 4.86_2) (envelope-from ) id 1riIXY-0008Gd-0O; Thu, 07 Mar 2024 18:32:26 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by lists.ubuntu.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1riIXV-0008G9-66 for kernel-team@lists.ubuntu.com; Thu, 07 Mar 2024 18:32:21 +0000 Received: from mail-oo1-f70.google.com (mail-oo1-f70.google.com [209.85.161.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 9994D3F148 for ; Thu, 7 Mar 2024 18:32:20 +0000 (UTC) Received: by mail-oo1-f70.google.com with SMTP id 006d021491bc7-59907104d88so1201563eaf.3 for ; Thu, 07 Mar 2024 10:32:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709836338; x=1710441138; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=s6anf9XKOV37+tW7rZlYAMDxZsc7Cj1SQMi4IVU3Aeg=; b=MJ2q1wNcFTE8rB/DUzQHfGqwdj8tFi7g2sNFclk+sttP3InR98RKidVpKpT3w7ifUr OBjAH052jp7Y8bkaNkbqVlbRnF+yhVl1zCVYa5qcGkK6VDr7ZF84W2igIiKWMkgA5yNf h4xRTxvxjr8ciGJXa9AnvuONXhS3HHaN0dNEdmVYdfzvoFcluRcb8UWwgfe8mgMSdIhk d8bMsZqQD9z2CtS54j/YAsQpLaubRMUjHUezCHe87fSCVxO6vvMBlKr8FH/FCZanS9bm dWmdZPIxjfH2TRCMi96GRc0soAeata79mFZdpEwAtd0wjWaxqxoHSPHfEYO9qPS8zVi4 Jyfg== X-Gm-Message-State: AOJu0YxcQHDir4zD0ASKorkRzQ/j5X7XJED9Yt/+uWZvgPOzRAcmEcr1 XJExmdqLctpu31yM0LncgaMYDFxzuT/joeXQVQbu0GuQH0CJIlXnKiOxR2zw2P3/YHn/SpagmuL dLrCahYctaTT9h2jCRjf6GMkPEqOaHUqER2qk9EEqcq90ojzOvP7RAoxwzsX1OSptRV+kNwYoDz vnYa6EJEaXLQ== X-Received: by 2002:a05:6358:70b:b0:176:40d5:2bd5 with SMTP id e11-20020a056358070b00b0017640d52bd5mr9351151rwj.6.1709836337872; Thu, 07 Mar 2024 10:32:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IGmUBmwXtjH/FAvidPpMboRlsHZALrmMJllOKbkTSaTnzg2X46TXRSzvMAlgPAMv/M4svLuPA== X-Received: by 2002:a05:6358:70b:b0:176:40d5:2bd5 with SMTP id e11-20020a056358070b00b0017640d52bd5mr9351136rwj.6.1709836337575; Thu, 07 Mar 2024 10:32:17 -0800 (PST) Received: from cox.home.arpa (104-222-113-121.cpe.teksavvy.com. [104.222.113.121]) by smtp.gmail.com with ESMTPSA id z18-20020a05622a061200b0042ec4f07712sm7130673qta.86.2024.03.07.10.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Mar 2024 10:32:16 -0800 (PST) From: Philip Cox To: kernel-team@lists.ubuntu.com Subject: [f/j/m/n:linux-aws][PATCH 0/1] aws: Backport latest ENA driver in upstream Linux to enable IRQ moderation Date: Thu, 7 Mar 2024 13:32:12 -0500 Message-Id: <20240307183213.106423-1-philip.cox@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2056475 SRU Justification: [Impact] In Ubuntu AMIs for x86 and Graviton based EC2 instances, the standard Ubuntu AMI comes without IRQ moderation enabled for ENA, which for our latest generation instances with networking heavy workloads is up to a 25% performance regression (i.e. NGINX in a load-balancing configuration). [Fix] The mainline Linux kernel will now support IRQ moderation by default for ENA in the 6.9 kernel release via this patch: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/commit/drivers/net/ethernet/amazon/ena?id=50d7a2660579889fba28b7e4543d4ce85aa2311b [Test Plan] AWS tested [Where problems could occur] By enabling adaptive coalescing, the default interrupt behaviour will by changed to be more adaptive, which shows improvements on heavy network workloads, but my change the behaviour and performance on other network workloads differently. Rather than handling the interrupts based off of a fixed amount of time elapsed, it will change to an adaptive based approach. There should be no negative impact on light workloads, and a positive impact on heavy work loads. If there is an impact though, this option can be disabled via the ethtool command. [Other Info] SF: 00380449 Acked-by: John Cabaj Acked-by: Tim Gardner --- David Arinzon (1): net: ena: Enable DIM by default drivers/net/ethernet/amazon/ena/ena_netdev.c | 6 ++++++ 1 file changed, 6 insertions(+)