mbox series

[SRU,M,v5,0/2] Dynamically determine acpi_handle_list size

Message ID 20240301075122.7242-1-ivan.hu@canonical.com
Headers show
Series Dynamically determine acpi_handle_list size | expand

Message

Ivan Hu March 1, 2024, 7:51 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/2049733

[Impact]
ACPI handle list will be dynamic allocated without default fixed size.

[Fix]
Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
some platforms that called ACPI _PSL method to get passive cooling device
objects. then will get the error message "Invalid passive threshold", this 
patch change the fixed size with the dynamic handle list size which fixes the
handle reference error.

[Test Case]
check the dmesg to see if there is the error message "Invalid passive threshold"

[Where problems could occur]
Only change the fixed size with the dynamic handle list size. Risk of regression
is low.

[Other Info]
Change of v2:
add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
and modify the cherrypicked to backported
Change of v3
add missing [SRU][M]
Change of v4
add missing BugLinks
Change of v5
add backport explanation

Rafael J. Wysocki (2):
  ACPI: utils: Dynamically determine acpi_handle_list size
  ACPI: utils: Fix error path in acpi_evaluate_reference()

 drivers/acpi/acpi_lpss.c                      | 10 ++-
 drivers/acpi/scan.c                           |  1 +
 drivers/acpi/thermal.c                        | 29 ++++++---
 drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
 .../platform/surface/surface_acpi_notify.c    | 10 ++-
 include/acpi/acpi_bus.h                       |  9 ++-
 6 files changed, 101 insertions(+), 21 deletions(-)

Comments

Manuel Diewald March 4, 2024, 10:37 a.m. UTC | #1
On Fri, Mar 01, 2024 at 03:51:20PM +0800, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049733
> 
> [Impact]
> ACPI handle list will be dynamic allocated without default fixed size.
> 
> [Fix]
> Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
> some platforms that called ACPI _PSL method to get passive cooling device
> objects. then will get the error message "Invalid passive threshold", this 
> patch change the fixed size with the dynamic handle list size which fixes the
> handle reference error.
> 
> [Test Case]
> check the dmesg to see if there is the error message "Invalid passive threshold"
> 
> [Where problems could occur]
> Only change the fixed size with the dynamic handle list size. Risk of regression
> is low.
> 
> [Other Info]
> Change of v2:
> add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
> fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
> and modify the cherrypicked to backported
> Change of v3
> add missing [SRU][M]
> Change of v4
> add missing BugLinks
> Change of v5
> add backport explanation
> 
> Rafael J. Wysocki (2):
>   ACPI: utils: Dynamically determine acpi_handle_list size
>   ACPI: utils: Fix error path in acpi_evaluate_reference()
> 
>  drivers/acpi/acpi_lpss.c                      | 10 ++-
>  drivers/acpi/scan.c                           |  1 +
>  drivers/acpi/thermal.c                        | 29 ++++++---
>  drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
>  .../platform/surface/surface_acpi_notify.c    | 10 ++-
>  include/acpi/acpi_bus.h                       |  9 ++-
>  6 files changed, 101 insertions(+), 21 deletions(-)
> 
> -- 
> 2.34.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Manuel Diewald <manuel.diewald@canonical.com>
Stefan Bader March 5, 2024, 8:48 a.m. UTC | #2
On 01.03.24 08:51, Ivan Hu wrote:
> BugLink: https://bugs.launchpad.net/bugs/2049733
> 
> [Impact]
> ACPI handle list will be dynamic allocated without default fixed size.
> 
> [Fix]
> Currently the ACPI_MAX_HANDLES is defined fix to 10, and it is not enough for
> some platforms that called ACPI _PSL method to get passive cooling device
> objects. then will get the error message "Invalid passive threshold", this
> patch change the fixed size with the dynamic handle list size which fixes the
> handle reference error.
> 
> [Test Case]
> check the dmesg to see if there is the error message "Invalid passive threshold"
> 
> [Where problems could occur]
> Only change the fixed size with the dynamic handle list size. Risk of regression
> is low.
> 
> [Other Info]
> Change of v2:
> add the "ACPI: utils: Fix error path in acpi_evaluate_reference()" patch for
> fixing the "ACPI: utils: Dynamically determine acpi_handle_list size" issue
> and modify the cherrypicked to backported
> Change of v3
> add missing [SRU][M]
> Change of v4
> add missing BugLinks
> Change of v5
> add backport explanation
> 
> Rafael J. Wysocki (2):
>    ACPI: utils: Dynamically determine acpi_handle_list size
>    ACPI: utils: Fix error path in acpi_evaluate_reference()
> 
>   drivers/acpi/acpi_lpss.c                      | 10 ++-
>   drivers/acpi/scan.c                           |  1 +
>   drivers/acpi/thermal.c                        | 29 ++++++---
>   drivers/acpi/utils.c                          | 63 ++++++++++++++++++-
>   .../platform/surface/surface_acpi_notify.c    | 10 ++-
>   include/acpi/acpi_bus.h                       |  9 ++-
>   6 files changed, 101 insertions(+), 21 deletions(-)
> 

Rejected for the following reasons:
- v6 on mailing list

-Stefan