mbox series

[SRU,J:linux-bluefield,v2,0/1] UBUNTU: SAUCE: mlxbf-gige: support fixed phy for Bobcat

Message ID 20240226175641.21215-1-asmaa@nvidia.com
Headers show
Series UBUNTU: SAUCE: mlxbf-gige: support fixed phy for Bobcat | expand

Message

Asmaa Mnebhi Feb. 26, 2024, 5:56 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/2054845

SRU Justification:

[Impact]

Bobcat is a new board which doesn't have an external PHY connected to the OOB. There are no MDIO busses involved and no PHY involved. The OOB is directly connected to the switch (MAC to MAC). SO we need to use the linux fixed phy to be able to emulate the mdio behavior and load the ethernet driver.

[Fix]

* Register the fixed-phy register in the case of the bobcat.

[Test Case]

* Important: For testing on the bobcat board, make sure the corresponding UEFI image is also loaded, otherwise, the oob driver will fail to load. For other board, it is backward compatible.
* Check if the mlxbf-gige is loaded on bobcat
* Check that it is using the fixed-phy via dmesg | grep PHY
* check that the oob interface is pingable
* check that files can be copied over via oob interface
* rmmod/modprobe
* ifconfig up/down
* reboot test

[Regression Potential]

* Redo all the OOB testing on other boards (moonraker) and make sure the bobcat changes dont trigger any regressions.

Comments

Bartlomiej Zolnierkiewicz March 1, 2024, 10:42 a.m. UTC | #1 
[ reply to 0/1 email this time ]

Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Mon, Feb 26, 2024 at 7:00 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2054845
>
> SRU Justification:
>
> [Impact]
>
> Bobcat is a new board which doesn't have an external PHY connected to the OOB. There are no MDIO busses involved and no PHY involved. The OOB is directly connected to the switch (MAC to MAC). SO we need to use the linux fixed phy to be able to emulate the mdio behavior and load the ethernet driver.
>
> [Fix]
>
> * Register the fixed-phy register in the case of the bobcat.
>
> [Test Case]
>
> * Important: For testing on the bobcat board, make sure the corresponding UEFI image is also loaded, otherwise, the oob driver will fail to load. For other board, it is backward compatible.
> * Check if the mlxbf-gige is loaded on bobcat
> * Check that it is using the fixed-phy via dmesg | grep PHY
> * check that the oob interface is pingable
> * check that files can be copied over via oob interface
> * rmmod/modprobe
> * ifconfig up/down
> * reboot test
>
> [Regression Potential]
>
> * Redo all the OOB testing on other boards (moonraker) and make sure the bobcat changes dont trigger any regressions.
>
Andrei Gherzan March 1, 2024, 11:48 a.m. UTC | #2 
On 24/02/26 12:56PM, Asmaa Mnebhi wrote:
> BugLink: https://bugs.launchpad.net/bugs/2054845
> 
> SRU Justification:
> 
> [Impact]
> 
> Bobcat is a new board which doesn't have an external PHY connected to the OOB. There are no MDIO busses involved and no PHY involved. The OOB is directly connected to the switch (MAC to MAC). SO we need to use the linux fixed phy to be able to emulate the mdio behavior and load the ethernet driver.
> 
> [Fix]
> 
> * Register the fixed-phy register in the case of the bobcat.
> 
> [Test Case]
> 
> * Important: For testing on the bobcat board, make sure the corresponding UEFI image is also loaded, otherwise, the oob driver will fail to load. For other board, it is backward compatible.
> * Check if the mlxbf-gige is loaded on bobcat
> * Check that it is using the fixed-phy via dmesg | grep PHY
> * check that the oob interface is pingable
> * check that files can be copied over via oob interface
> * rmmod/modprobe
> * ifconfig up/down
> * reboot test
> 
> [Regression Potential]
> 
> * Redo all the OOB testing on other boards (moonraker) and make sure the bobcat changes dont trigger any regressions.

Acked-by: Andrei Gherzan <andrei.gherzan@canonical.com>
Bartlomiej Zolnierkiewicz March 6, 2024, 12:33 p.m. UTC | #3 
Applied to jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Mon, Feb 26, 2024 at 7:00 PM Asmaa Mnebhi <asmaa@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/2054845
>
> SRU Justification:
>
> [Impact]
>
> Bobcat is a new board which doesn't have an external PHY connected to the OOB. There are no MDIO busses involved and no PHY involved. The OOB is directly connected to the switch (MAC to MAC). SO we need to use the linux fixed phy to be able to emulate the mdio behavior and load the ethernet driver.
>
> [Fix]
>
> * Register the fixed-phy register in the case of the bobcat.
>
> [Test Case]
>
> * Important: For testing on the bobcat board, make sure the corresponding UEFI image is also loaded, otherwise, the oob driver will fail to load. For other board, it is backward compatible.
> * Check if the mlxbf-gige is loaded on bobcat
> * Check that it is using the fixed-phy via dmesg | grep PHY
> * check that the oob interface is pingable
> * check that files can be copied over via oob interface
> * rmmod/modprobe
> * ifconfig up/down
> * reboot test
>
> [Regression Potential]
>
> * Redo all the OOB testing on other boards (moonraker) and make sure the bobcat changes dont trigger any regressions.
>