From patchwork Wed Apr 26 17:19:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 1774193 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=QhKzEnaV; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q65G43Nh0z23vJ for ; Thu, 27 Apr 2023 03:19:40 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1prink-0003Xz-Ll; Wed, 26 Apr 2023 17:19:32 +0000 Received: from smtp-relay-internal-0.internal ([10.131.114.225] helo=smtp-relay-internal-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1prini-0003Xd-BW for kernel-team@lists.ubuntu.com; Wed, 26 Apr 2023 17:19:30 +0000 Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id BF5BF3F18A for ; Wed, 26 Apr 2023 17:19:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1682529569; bh=NiAqjBvl6FvSAc2htNIX6r4ZAKIavLuuT5v1ygc5Cxg=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=QhKzEnaVf/VHyUW+50cNyLVPIh/zxZxmlXkM3dRlmSnbwZ/GolV21J1H93RGG6Y4Y lf3Q51bvDoNLsSf9k4bhoeYOmWPVL03Zwa2onl/JYnAvoJHzd0EBgmwHAHvy4cwrJm mDo6N94FZtf3GysGIEjdRDSTB8JpFot7Nf23gRX9Mn6EGVJyOjs+ZwrYrCeJMTWJ8b HdG3DbFaA6HJ2CW38SzHJcZhkqgSRivrQSlLByLsvcIGPx4ccsqv6IiCUQvzYJIR++ PY8pYNph8O+mG5/AEVZwVbsd62rEh43ZT1BhUxGhqIVXVprWjgWh+z71Fc5fWXVX2p Z4LkQCqC06GXA== Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-5187bd3d365so6661115a12.3 for ; Wed, 26 Apr 2023 10:19:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682529567; x=1685121567; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NiAqjBvl6FvSAc2htNIX6r4ZAKIavLuuT5v1ygc5Cxg=; b=D+t2XAzHe5XeCGWQMLQYfM483+y9yRuHPNC4L8C5vIw/Q6oO5MzalXWQscbhkZ8OUB DCboYe/F5cVnCTgnUadUPiz2fYKPmF2mPN3ZuqDLqBVND1f7YZ8XlUROhd96kGSdyvQJ K6ptNk+RdQ8GlEm+vJSNep+k/LJwRgW5vrm8LWCgGq1VZo6mwJ13So6MS9P5QyalObZJ mtCQpI1a7VL119OG+BMLcGft29TPV/1Ldc6vrzWIJQk23we4ptBjohAq7OWiLyhtxCJ5 MZBggLtw11m+4aF9uUrFYjW6PwbAAnBs9q1P2pc2gUo0c9uLTzKeprN+y2sGOjfktUhi mbsA== X-Gm-Message-State: AAQBX9c3HrPK4qIOLqdPEhUJHlhHCRz66wNZSY7WDbHzF4UCDOpr7GIH G2plphtzGHh/9JFIjRPvjQ5x3ttV5GfFLbcUDbfERS+19B7UviwhVYDt3F8nWpTZSMnWrWJqGWf SRpM5B033nxKo+aCAmjGuW7dsqBUA1zYCGXQnoeS5oYPV1d7Szg== X-Received: by 2002:a05:6a20:e68b:b0:ef:70b:42fc with SMTP id mz11-20020a056a20e68b00b000ef070b42fcmr23379338pzb.38.1682529567111; Wed, 26 Apr 2023 10:19:27 -0700 (PDT) X-Google-Smtp-Source: AKy350amGb060SFOnm9FcG4uudvcRRY0b0+S+8SGWnh9lTGfHEx58BTsE/P6RC1K0lq9RHBBPnz/4w== X-Received: by 2002:a05:6a20:e68b:b0:ef:70b:42fc with SMTP id mz11-20020a056a20e68b00b000ef070b42fcmr23379324pzb.38.1682529566808; Wed, 26 Apr 2023 10:19:26 -0700 (PDT) Received: from smtp.gmail.com (174-045-099-030.res.spectrum.com. [174.45.99.30]) by smtp.gmail.com with ESMTPSA id l5-20020a17090a598500b00247a2498075sm9780256pji.48.2023.04.26.10.19.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Apr 2023 10:19:26 -0700 (PDT) From: Tim Gardner To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1] [Focal linux-azure]Azure: keys: Do not cache key in task struct if key is requested from kernel thread Date: Wed, 26 Apr 2023 11:19:21 -0600 Message-Id: <20230426171922.896150-1-tim.gardner@canonical.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/2017801 SRU Justification [Impact] The key which gets cached in task structure from a kernel thread does not get invalidated even after expiry. Due to which, a new key request from kernel thread will be served with the cached key if it's present in task struct irrespective of the key validity. [Fix] commit 47f9e4c924025c5be87959d3335e66fcbb7f6b5c ('keys: Do not cache key in task struct if key is requested from kernel thread') Fixes: 7743c48e54ee ("keys: Cache result of request_key*() temporarily in task_struct") [Regression potential] DNS keys used by CIFS could get confused. [Other Info] Though this commit is part of stable updates v5.4.240, MSFT has requested that it be applied in advance since Focal is only up to v5.4.233. Linux-azure 5.4 is the only kernel that does not have this patch. SF: #00359129 Acked-by: John Cabaj