From patchwork Mon Apr 24 23:51:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Tu X-Patchwork-Id: 1773162 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=Nvidia.com header.i=@Nvidia.com header.a=rsa-sha256 header.s=selector2 header.b=Y4dlhqPt; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4Q523c43v9z23v2 for ; Tue, 25 Apr 2023 09:51:56 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1pr5yG-0006g5-Nw; Mon, 24 Apr 2023 23:51:48 +0000 Received: from mail-bn7nam10on2056.outbound.protection.outlook.com ([40.107.92.56] helo=NAM10-BN7-obe.outbound.protection.outlook.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1pr5yA-0006YV-EW for kernel-team@lists.ubuntu.com; Mon, 24 Apr 2023 23:51:42 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lSQ8PMnWgWLEyqjFmRD+hXza77ZvYtVtxFlC432hGktfS6XIa1Y6yVMf1qQeNZsKJpPMu6q3qJoLF/uIxfLybZlvuoUcR/JJiYhrYqHEtrqWVMW2sr3mlQ7Ap+fYu8qwtTddtHVSCSa3aZMEMEVOL/NH31hkuRQ7KHNT1/q3AMyieqkAHRWGCwALwlZ1U8rQ48xsYxfNugqifg2kFSkscCTetYKIH5uWLuBg4OljuTFcHqlnzTWt8Y8+VGMz03jZo6Ug5wgv6ugVSyB+k04kDIFeWKxukii8tlyjaAVbLuP6A90sISL+XAOjVXrVIrliGQgCgP/mQZEgVuD2laIokg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=GG0MtYZR5eFyKSPCCJrc0qHnljgps0ugTQjfNcwm7yc=; b=RX6QzncZOcHv8G1c5mEknsfbA2kkL4z45LXsnbSBqcXBbJVLR3OwOEv0b4J5PBKypDQ3h+PBB1b6/6TbaXyDZkXy7DBp9qgLqFl9Ifgy0GXmdbE8KnrE9x89UCXD8PNmBUsXXU6+ogP61ofCMIn3V+y0QCG6af/Le1PMJmaup1Ses+BFijpb9UDiKCJG72ZVpod/xD/gZZb6V41N9mDGis44/g0xCRA8xzStRxUZ2BrIUQRIv5aEKtDIsxxmf9lzj88DF336ocwir3x0IU2AWYM0HeTAUDNi+Xy/PiUr5Ad7aqfq0O2Pt1WWLi5HGnry+jRb5udhX9WR3c23j8UPfQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.118.232) smtp.rcpttodomain=canonical.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GG0MtYZR5eFyKSPCCJrc0qHnljgps0ugTQjfNcwm7yc=; b=Y4dlhqPtB84AIPzhlT7gDaYSRlcZbLNuiYV/NSGOJY37uUr4fyLH03oN3g3Jz/Eq+j4a3cp95wcmfxFpKjOaEVlWBPO/CqQl7EJs24lMNOpng6eJ1XCa4k3vN/WFoTTeRL7b7Juxp2FN6RqJW5rUCTnKh5dM2TbOMtSW1qp8Hae0wYZOCvU2c95/XHbnHBDu3ZgKC6MfVcs/VRyyOznsCzl3Q7qIJxZhKNPnEA0uN6VNViPigG3oG+xR1BYrWfmwI0nI3lqA7t70A0HJtSSIZv6VDxQCs71eOA/DvFaOVf83i+FgCCfY8WPKWElzO3QwbS8z4ogwTF8Jcwps8E1ZgQ== Received: from DS7PR03CA0086.namprd03.prod.outlook.com (2603:10b6:5:3bb::31) by PH7PR12MB7138.namprd12.prod.outlook.com (2603:10b6:510:1ee::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 23:51:40 +0000 Received: from DM6NAM11FT100.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3bb:cafe::f2) by DS7PR03CA0086.outlook.office365.com (2603:10b6:5:3bb::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 23:51:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.118.232) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.118.232 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.118.232; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.118.232) by DM6NAM11FT100.mail.protection.outlook.com (10.13.172.247) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.20 via Frontend Transport; Mon, 24 Apr 2023 23:51:39 +0000 Received: from drhqmail201.nvidia.com (10.126.190.180) by mail.nvidia.com (10.127.129.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 16:51:12 -0700 Received: from drhqmail203.nvidia.com (10.126.190.182) by drhqmail201.nvidia.com (10.126.190.180) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 16:51:12 -0700 Received: from mtl123.mtl.labs.mlnx (10.127.8.10) by mail.nvidia.com (10.126.190.182) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37 via Frontend Transport; Mon, 24 Apr 2023 16:51:11 -0700 Received: from sw-mtx-002.mtx.labs.mlnx (sw-mtx-002.mtx.labs.mlnx [10.9.151.106]) by mtl123.mtl.labs.mlnx (8.14.4/8.14.4) with ESMTP id 33ONp7ur001062; Tue, 25 Apr 2023 02:51:08 +0300 From: William Tu To: Subject: [SRU][F:linux-bluefield][PATCH v2 0/5] revert "Support hardware miss to tc action" Date: Tue, 25 Apr 2023 02:51:02 +0300 Message-ID: <20230424235107.607162-1-witu@nvidia.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT100:EE_|PH7PR12MB7138:EE_ X-MS-Office365-Filtering-Correlation-Id: 3492315d-423a-453c-9ce4-08db451ed8f6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: LH4AYSrhExkrEH0zma2Bf/YifqbK8bX3FOckUnO/KJuX8FCviP/UcwqPjhrQr4MK6YW0MWD6+mQ+ssDu4k/ZWOI3ml+RlJ6jpRHC+bXEtdpPogevz0fptnaPocS+BSXlmtO6JgnAk46V3j2ftWmtpQKGiK7/kDe31G6ljhhewhiOfqYrG2mg6YiTteoSncnNokl9xjnbgjSfCNZwiC1M/imaJrDSXyY3csF21CTodDz/XLjNlfuSLpofplEYrkDnpzULvEwTX/wcZ1V48hyOWfXcHdU8cKyGkZQrQ8XQIURqEvDJvgNTgvBU5K9LEQUoftX0oC/jXgbn89rLNKLD7GHr0cVKzdQgwWUMyNQ+b/uOVDfCBb0EkbVxnWWByJiObT6pL3n06etW1VqXqA+4vdfbLj8K0Kq3Wa+1lJe40zaK2+E76x0Db7FYSz/lxkzrEhAmEyTyBbhLQD2IBiP0MkxesxzAoo5zzZ6LSWhfwauB4XJj4CuWPpMdsAOEFJYyIJI4Q69b5NojEpy+4DTCMcpr4mnvJNqp26lE+zDU+v2uxZApjBulR3UgPobEJJlBbwiCk1nTh6OAy9eYzWUkDplbIiI1yUgls/RF9ctDRm1ABh/9sy6F6zLbN50btl61DRslTDFUpcKkJxS/SliT0BY6kvODMbn8vrpOrwCLIgE1wYhm+OBQs3HutQ2W2PT6xaw2Udar2fwyq3puBBgZgMt05WhrmkgBD91K3/BLmr3/7PHy95kGvLCo69VAPuRWRtkOoog3BhF41m0RMORvzisdUrepyelqr7nGnraFwOsoedgX3q/v9g97ENraOzIB X-Forefront-Antispam-Report: CIP:216.228.118.232; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc7edge1.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(396003)(376002)(136003)(39860400002)(451199021)(40470700004)(46966006)(36840700001)(4743002)(54906003)(86362001)(478600001)(40460700003)(36756003)(966005)(107886003)(34020700004)(186003)(45080400002)(8936002)(26005)(40480700001)(82310400005)(1076003)(6666004)(82740400003)(316002)(356005)(7636003)(336012)(41300700001)(36860700001)(6916009)(4326008)(70206006)(70586007)(83380400001)(8676002)(5660300002)(47076005)(2906002)(2616005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 23:51:39.3183 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 3492315d-423a-453c-9ce4-08db451ed8f6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.118.232]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT100.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7138 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dann.frazier@canonical.com, paulb@nvidia.com, vlad@nvidia.com, yifeid@nvidia.com, bodong@nvidia.com Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" The series revert the patches for: BugLink: https://bugs.launchpad.net/bugs/2012571 While testing, we found the following kernel NULL pointer dereference: [ 299.084455] Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000 [ 299.093268] Mem abort info: [ 299.096052] ESR = 0x96000004 [ 299.099157] EC = 0x25: DABT (current EL), IL = 32 bits [ 299.104485] SET = 0, FnV = 0 [ 299.107529] EA = 0, S1PTW = 0 [ 299.110690] Data abort info: [ 299.113585] ISV = 0, ISS = 0x00000004 [ 299.117436] CM = 0, WnR = 0 [ 299.120420] user pgtable: 4k pages, 48-bit VAs, pgdp=000000083b887000 [ 299.126882] [0000000000000000] pgd=0000000000000000 [ 299.131778] Internal error: Oops: 96000004 [#1] PREEMPT SMP [ 299.137342] Modules linked in: ipmb_host rdma_ucm(O) rdma_cm(O) iw_cm(O) ib_ipoib(O) ib_cm(O) ib_umad(O) mlx5_ib(O) mlx5_core(O) mlxfw(O) mlxdevm(O) auxiliary(O) ib_uverbs(O) psample ib_core(O) mlx_compat(O) sbsa_gwdt act_mirred act_skbedit ip6table_filter ip6table_nat ip6table_mangle ip6_tables xt_MASQUERADE xt_mark iptable_nat xt_conntrack xt_comment iptable_filter iptable_mangle bpfilter nfnetlink_cttimeout nfnetlink act_gact cls_flower sch_ingress xfrm_user xfrm_algo openvswitch nsh nf_conncount nf_nat mst_pciconf(O) ipmi_devintf ipmi_msghandler ipmb_dev_int 8021q garp stp mrp llc overlay dm_multipath uio_pdrv_genirq mlxbf_pmc uio pwr_mlxbf mlx_bootctl mlxbf_pka mlx_trio bluefield_edac sch_fq_codel efi_pstore ip_tables ipv6 crc_ccitt btrfs zstd_compress raid10 raid456 async_raid6_recov async_memcpy async_pq async_xor async_tx xor xor_neon raid6_pq raid1 raid0 crct10dif_ce i2c_mlxbf gpio_mlxbf2 mlxbf_gige aes_neon_bs aes_neon_blk [last unloaded: mlx_compat] [ 299.222443] CPU: 5 PID: 11902 Comm: revalidator15 Tainted: G O 5.4.0-1061-bluefield #67-Ubuntu [ 299.232347] Hardware name: https://www.mellanox.com BlueField SoC/BlueField SoC, BIOS 4.0.2.12660 Apr 15 2023 [ 299.242253] pstate: a0000005 (NzCv daif -PAN -UAO) [ 299.247047] pc : fl_dump_key+0x34/0xa08 [cls_flower] [ 299.252002] lr : fl_dump+0xc4/0x300 [cls_flower] [ 299.256609] sp : ffff8000117935e0 [ 299.259912] x29: ffff8000117935e0 x28: ffff4932144e6800 [ 299.265214] x27: ffff493206128048 x26: ffff4931d77dd738 [ 299.270516] x25: ffff493206128000 x24: ffff4932144e6800 [ 299.275817] x23: ffff4932068bba00 x22: ffffcaf6d467d500 [ 299.281118] x21: ffff493214581900 x20: 0000000000000000 [ 299.286419] x19: ffff4932144e6a18 x18: 0000000000000000 [ 299.291721] x17: 0000000000000000 x16: ffffcaf6d369ac70 [ 299.297021] x15: 0000000000000000 x14: 0000000000000000 [ 299.302323] x13: 0000000000000040 x12: 0000000000000030 [ 299.307624] x11: 0101010101010101 x10: 7f7f7f7f7f7f7f7f [ 299.312925] x9 : fefefefefefefeff x8 : ffff493206128074 [ 299.318226] x7 : 0000000000000000 x6 : ffff493206128074 [ 299.323527] x5 : 0000000000007e50 x4 : 0000000000000000 [ 299.328828] x3 : 0000000000000000 x2 : ffff4932144e6a18 [ 299.334129] x1 : ffffcaf6d467d500 x0 : ffffcaf68d53198c Git bisect shows the first FAILED is below FAILED 0e6ec758d035 net/sched: flower: Move filter handle initialization earlier PASS 636a658578ec net/sched: cls_api: Support hardware miss to tc action It seems non-trivial to fix the issue, so request to revert. v1->v2: Fix format errors. William Tu (5): Revert "net/sched: flower: fix fl_change() error recovery path" Revert "net/sched: flower: Support hardware miss to tc action" Revert "net/sched: flower: Move filter handle initialization earlier" Revert "net/sched: cls_api: Support hardware miss to tc action" Revert "UBUNTU: SAUCE: net/sched: Provide act to offload action" include/linux/skbuff.h | 6 +- include/net/flow_offload.h | 2 - include/net/pkt_cls.h | 30 ++--- include/net/sch_generic.h | 2 - net/openvswitch/flow.c | 3 +- net/sched/cls_api.c | 217 ++----------------------------------- net/sched/cls_flower.c | 79 +++++--------- 7 files changed, 51 insertions(+), 288 deletions(-) Acked-by: Andrei Gherzan Acked-by: Bartlomiej Zolnierkiewicz