From patchwork Tue Mar 21 07:15:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1759318 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: legolas.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=vab0jg+6; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4PgjZW5L00z247m for ; Tue, 21 Mar 2023 18:16:18 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1peWDz-0000HY-Cs; Tue, 21 Mar 2023 07:16:03 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1peWDx-0000Gr-4K for kernel-team@lists.ubuntu.com; Tue, 21 Mar 2023 07:16:01 +0000 Received: from localhost.localdomain (1.general.phlin.uk.vpn [10.172.194.38]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id 226923F25F for ; Tue, 21 Mar 2023 07:15:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1679382959; bh=HZsBcWC+Tt5kul4no/30CfGXPOzEwFf8tMnfdX3Cp/4=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=vab0jg+6vEOQluxieUzEFNiKjV6U7aetqxUCcTAW4MRrJVpvxxHNRway+2tRqj1uy dpmDbu3U3F1HUq3V4l9kGl2OAtU63F6fxb35+dHKwbh724XgSGSGJmNX6nHa7P1egD OrkN7hlltwVdpTDruyP7cAlm/7sIEgqMpKtbMkyhLDu3ThB/hCovd629McSMdGsKqL lclWlXmPDFPRgRUx3+OdckZ4qfU+k0ltXSEvklpyV5L0pyIjwUdHONYOprn8YcmnV0 FisTVJ1/qROITPqn3hqeUkswv9PPU9ivTWNdYJUMu1avdezES5r4w4Wweo0kmQJXaJ BEyIpbEpfhA6A== From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [B][SRU][PATCH 0/1] selftests/ftrace: Fix bash specific "==" operator Date: Tue, 21 Mar 2023 15:15:08 +0800 Message-Id: <20230321071509.79196-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" == Impact == With upstream commit a1d6cd88c "selftests/ftrace: event_triggers: wait longer for test_event_enable" applied via stable update, ftrace in Bionic proposed (4.15.0-207.218) is now failing with: $ sudo ./ftracetest ./test.d/ftrace/func_event_triggers.tc [1] ftrace - test for function event triggers [FAIL] [2] (instance) ftrace - test for function event triggers [FAIL] With -v added to the command you will see it failing with: ./ftracetest: 52: [: 0: unexpected operator The "==" operator fix from 1e6b485c can solve this problem. == Fix == * 1e6b485c selftests/ftrace: Fix bash specific "==" operator This patch can be cherry-picked into Bionic. We have this fix in other kernels already. == Testcase == Running the kernel selftests/ftracetest with -v flag, it should no longer show these two "test for function event triggers" test FAIL because of this unexpected operator issue. == Regression Potential == This affects only the selftest suite and only ftrace subtests. Any change would only be observable there. Masami Hiramatsu (Google) (1): selftests/ftrace: Fix bash specific "==" operator tools/testing/selftests/ftrace/test.d/ftrace/func_event_triggers.tc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Acked-by: Tim Gardner Acked-by: Cory Todd