mbox series

[SRU,F/J:linux-bluefield,v1,0/1] UBUNTU: SAUCE: mlxbf-pmc: Fix event string typo

Message ID 20221206163155.18797-1-jahurley@nvidia.com
Headers show
Series UBUNTU: SAUCE: mlxbf-pmc: Fix event string typo | expand

Message

James Hurley Dec. 6, 2022, 4:31 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1998863

SRU Justification:

[Impact]

Due to a typo, duplicate events are shown

[Fix]

* Fix event name typo.

[Test Case]

* cd /sys/class/hwmon/hwmon0/tilenetX ("X" may be 0..7)
root@localhost:/sys/class/hwmon/hwmon0/tilenet3# cat event_list | grep CRED
15: CDN_DIAG_N_OUT_OF_CRED
16: CDN_DIAG_S_OUT_OF_CRED
17: CDN_DIAG_E_OUT_OF_CRED
18: CDN_DIAG_W_OUT_OF_CRED
19: CDN_DIAG_C_OUT_OF_CRED
25: DDN_DIAG_N_OUT_OF_CRED
26: DDN_DIAG_S_OUT_OF_CRED
27: DDN_DIAG_E_OUT_OF_CRED
28: DDN_DIAG_W_OUT_OF_CRED
29: DDN_DIAG_C_OUT_OF_CRED
35: NDN_DIAG_N_OUT_OF_CRED <== Incorrectly was set to NDN_DIAG_S_OUT_OF_CRED
36: NDN_DIAG_S_OUT_OF_CRED
37: NDN_DIAG_E_OUT_OF_CRED
38: NDN_DIAG_W_OUT_OF_CRED
39: NDN_DIAG_C_OUT_OF_CRED

[Regression Potential]

* Duplicate events still get shown

Comments

Tim Gardner Dec. 8, 2022, 7:35 p.m. UTC | #1 
On 12/6/22 9:31 AM, James Hurley wrote:
> BugLink: https://bugs.launchpad.net/bugs/1998863
> 
> SRU Justification:
> 
> [Impact]
> 
> Due to a typo, duplicate events are shown
> 
> [Fix]
> 
> * Fix event name typo.
> 
> [Test Case]
> 
> * cd /sys/class/hwmon/hwmon0/tilenetX ("X" may be 0..7)
> root@localhost:/sys/class/hwmon/hwmon0/tilenet3# cat event_list | grep CRED
> 15: CDN_DIAG_N_OUT_OF_CRED
> 16: CDN_DIAG_S_OUT_OF_CRED
> 17: CDN_DIAG_E_OUT_OF_CRED
> 18: CDN_DIAG_W_OUT_OF_CRED
> 19: CDN_DIAG_C_OUT_OF_CRED
> 25: DDN_DIAG_N_OUT_OF_CRED
> 26: DDN_DIAG_S_OUT_OF_CRED
> 27: DDN_DIAG_E_OUT_OF_CRED
> 28: DDN_DIAG_W_OUT_OF_CRED
> 29: DDN_DIAG_C_OUT_OF_CRED
> 35: NDN_DIAG_N_OUT_OF_CRED <== Incorrectly was set to NDN_DIAG_S_OUT_OF_CRED
> 36: NDN_DIAG_S_OUT_OF_CRED
> 37: NDN_DIAG_E_OUT_OF_CRED
> 38: NDN_DIAG_W_OUT_OF_CRED
> 39: NDN_DIAG_C_OUT_OF_CRED
> 
> [Regression Potential]
> 
> * Duplicate events still get shown
> 
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Bartlomiej Zolnierkiewicz Dec. 13, 2022, 5:23 p.m. UTC | #2 
Acked-by: Bartlomiej Zolnierkiewicz <bartlomiej.zolnierkiewicz@canonical.com>

On Thu, Dec 8, 2022 at 2:30 PM James Hurley <jahurley@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1998863
>
> SRU Justification:
>
> [Impact]
>
> Due to a typo, duplicate events are shown
>
> [Fix]
>
> * Fix event name typo.
>
> [Test Case]
>
> * cd /sys/class/hwmon/hwmon0/tilenetX ("X" may be 0..7)
> root@localhost:/sys/class/hwmon/hwmon0/tilenet3# cat event_list | grep CRED
> 15: CDN_DIAG_N_OUT_OF_CRED
> 16: CDN_DIAG_S_OUT_OF_CRED
> 17: CDN_DIAG_E_OUT_OF_CRED
> 18: CDN_DIAG_W_OUT_OF_CRED
> 19: CDN_DIAG_C_OUT_OF_CRED
> 25: DDN_DIAG_N_OUT_OF_CRED
> 26: DDN_DIAG_S_OUT_OF_CRED
> 27: DDN_DIAG_E_OUT_OF_CRED
> 28: DDN_DIAG_W_OUT_OF_CRED
> 29: DDN_DIAG_C_OUT_OF_CRED
> 35: NDN_DIAG_N_OUT_OF_CRED <== Incorrectly was set to NDN_DIAG_S_OUT_OF_CRED
> 36: NDN_DIAG_S_OUT_OF_CRED
> 37: NDN_DIAG_E_OUT_OF_CRED
> 38: NDN_DIAG_W_OUT_OF_CRED
> 39: NDN_DIAG_C_OUT_OF_CRED
>
> [Regression Potential]
>
> * Duplicate events still get shown
Bartlomiej Zolnierkiewicz Jan. 5, 2023, 12:46 p.m. UTC | #3 
Applied to focal:linux-bluefield/master-next and
jammy:linux-bluefield/master-next. Thanks.

--
Best regards,
Bartlomiej

On Thu, Dec 8, 2022 at 2:30 PM James Hurley <jahurley@nvidia.com> wrote:
>
> BugLink: https://bugs.launchpad.net/bugs/1998863
>
> SRU Justification:
>
> [Impact]
>
> Due to a typo, duplicate events are shown
>
> [Fix]
>
> * Fix event name typo.
>
> [Test Case]
>
> * cd /sys/class/hwmon/hwmon0/tilenetX ("X" may be 0..7)
> root@localhost:/sys/class/hwmon/hwmon0/tilenet3# cat event_list | grep CRED
> 15: CDN_DIAG_N_OUT_OF_CRED
> 16: CDN_DIAG_S_OUT_OF_CRED
> 17: CDN_DIAG_E_OUT_OF_CRED
> 18: CDN_DIAG_W_OUT_OF_CRED
> 19: CDN_DIAG_C_OUT_OF_CRED
> 25: DDN_DIAG_N_OUT_OF_CRED
> 26: DDN_DIAG_S_OUT_OF_CRED
> 27: DDN_DIAG_E_OUT_OF_CRED
> 28: DDN_DIAG_W_OUT_OF_CRED
> 29: DDN_DIAG_C_OUT_OF_CRED
> 35: NDN_DIAG_N_OUT_OF_CRED <== Incorrectly was set to NDN_DIAG_S_OUT_OF_CRED
> 36: NDN_DIAG_S_OUT_OF_CRED
> 37: NDN_DIAG_E_OUT_OF_CRED
> 38: NDN_DIAG_W_OUT_OF_CRED
> 39: NDN_DIAG_C_OUT_OF_CRED
>
> [Regression Potential]
>
> * Duplicate events still get shown
>