From patchwork Thu Nov 10 08:25:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: You-Sheng Yang X-Patchwork-Id: 1702026 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@legolas.ozlabs.org Authentication-Results: legolas.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by legolas.ozlabs.org (Postfix) with ESMTPS id 4N7FKc5rLfz1yqS for ; Thu, 10 Nov 2022 19:26:10 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1ot2sr-0002lW-5u; Thu, 10 Nov 2022 08:26:01 +0000 Received: from mail-pg1-f174.google.com ([209.85.215.174]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1ot2sp-0002kU-S1 for kernel-team@lists.ubuntu.com; Thu, 10 Nov 2022 08:26:00 +0000 Received: by mail-pg1-f174.google.com with SMTP id o13so1101800pgu.7 for ; Thu, 10 Nov 2022 00:25:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=iti+yqNJzmZ/t1ISajCzjZCqfEp9z18mTfWkCyljI3M=; b=7gVlovq6M7c6SH3lDlIZMATiVwPQhhwCqVBPw0sdxiV0j29ydS+VEXLczbiqKyMBKK Aoo/WkZBqMbFxgM5pI/aBIeB4wJ7w9lSgD0qycTLdLfRq0iDUuxnbu0je10hsrH3Ex+F 459LDQdcst2+DfHyS+BnoJSX337LiYnbMMuSZZfKefpf4zIeUvqiTrZmUnUKAXlNOK7G UCV/jhnmU/r5peMkHYy+k7uikpdmix+C9ML9YsTZ1ZH9TNP6hAWp7+Tl6sAF/kw/kcCm /5m8rFAeRbO1EfUMht+I+u7AXIpZug49ehn8yd4YQz9PzHNydmH0bCVCWSMQe6dS9d7b gBvw== X-Gm-Message-State: ACrzQf3sccT9KXz5XukRTRMVN4kuJ2hKGsZWcV2jDeg57M8mnzikV0q2 IkmrW1udHILHndhVCsBfeEi8Komm5eUPBA== X-Google-Smtp-Source: AMsMyM6HbQt2oOUwm6KSIHLh0Sl52r9suv5/QqoxFEJ7qc0cXPywtbsSbE5124btlZtpXTK4kqjuuw== X-Received: by 2002:a63:ec51:0:b0:46f:ed8d:7089 with SMTP id r17-20020a63ec51000000b0046fed8d7089mr39193014pgj.469.1668068756199; Thu, 10 Nov 2022 00:25:56 -0800 (PST) Received: from yewun.. (61-227-105-74.dynamic-ip.hinet.net. [61.227.105.74]) by smtp.gmail.com with ESMTPSA id q8-20020a170902a3c800b00186ad73e2d5sm10517521plb.208.2022.11.10.00.25.54 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Nov 2022 00:25:54 -0800 (PST) From: You-Sheng Yang To: kernel-team@lists.ubuntu.com Subject: [PATCH v3 0/1][SRU][Unstable/Kinetic/OEM-6.0] Fix suspend failure on t7xx equipped platform Date: Thu, 10 Nov 2022 16:25:51 +0800 Message-Id: <20221110082552.1055995-1-vicamo.yang@canonical.com> X-Mailer: git-send-email 2.37.2 MIME-Version: 1.0 Received-SPF: pass client-ip=209.85.215.174; envelope-from=vicamo@gmail.com; helo=mail-pg1-f174.google.com X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" From: "You-Sheng Yang (vicamo)" BugLink: https://bugs.launchpad.net/bugs/1990700 [Impact] Fibocom WWAN FM350-GL equipped platform fails to suspend. [Fix] Full t7xx driver is still under development and some of them have already accepted and merged in mainline kernel. The following commits are once in the mainline and are reverted in v6.0 to address some more review comments: d20ef656f994 net: wwan: t7xx: Add AP CLDMA 007f26f0d68e net: wwan: t7xx: Infrastructure for early port configuration 140424d90165 net: wwan: t7xx: PCIe reset rescan 87dae9e70bf7 net: wwan: t7xx: Enable devlink based fw flashing and coredump collection The first patch implemented the other AP-CLDMA, and with that applied, platforms in question may suspend and resume normally as every bits are in position. [Test Case] Trigger suspend and there should be no more suspend errors from t7xx: mtk_t7xx 0000:58:00.0: [PM] SAP suspend error: -110 mtk_t7xx 0000:58:00.0: PM: pci_pm_suspend(): t7xx_pci_pm_suspend+0x0/0x20 [mtk_t7xx] returns -110 mtk_t7xx 0000:58:00.0: PM: dpm_run_callback(): pci_pm_suspend+0x0/0x1a0 returns -110 mtk_t7xx 0000:58:00.0: PM: failed to suspend async: error -110 [Where problems could occur] The t7xx driver is still incomplete, but this should be enough for general use. [Other Info] This affects Kinetic and above, so only Unstable, Kinetic and OEM-6.0 are nominated for fix. V3: use the full implementation for AP-CLDMA instead as requested by hw vendor. Haijun Liu (1): net: wwan: t7xx: Add AP CLDMA drivers/net/wwan/t7xx/t7xx_hif_cldma.c | 17 +++-- drivers/net/wwan/t7xx/t7xx_hif_cldma.h | 2 +- drivers/net/wwan/t7xx/t7xx_mhccif.h | 1 + drivers/net/wwan/t7xx/t7xx_modem_ops.c | 85 ++++++++++++++++++---- drivers/net/wwan/t7xx/t7xx_modem_ops.h | 3 + drivers/net/wwan/t7xx/t7xx_port.h | 8 +- drivers/net/wwan/t7xx/t7xx_port_ctrl_msg.c | 8 +- drivers/net/wwan/t7xx/t7xx_port_proxy.c | 12 +++ drivers/net/wwan/t7xx/t7xx_reg.h | 2 +- drivers/net/wwan/t7xx/t7xx_state_monitor.c | 13 +++- drivers/net/wwan/t7xx/t7xx_state_monitor.h | 2 + 11 files changed, 125 insertions(+), 28 deletions(-) Acked-by: Tim Gardner Acked-by: Kleber Sacilotto de Souza