mbox series

[v2,0/3,jammy] Fix AMD Yellow Carp B0 s0i3

Message ID 20220725080058.2892400-1-vicamo.yang@canonical.com
Headers show
Series Fix AMD Yellow Carp B0 s0i3 | expand

Message

You-Sheng Yang July 25, 2022, 8 a.m. UTC
From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1957026

[Impact]

On AMD Yellow Carp B0 platforms, S0i3 is still not working.

[Fix]

This denpends on a few fixes for kernel driver that are all either in
v5.17-rc1 or in stable linux-5.1x.y, along with an already upstreamed
dmcub firmware.

[Test Case]

On AMD RMT CRB board,
1. apply both kernel and firmware fixes
2. module blacklist amd_sfh as it's still under development,
3. trigger system suspend. Use power button to wake up the device.
4. check /sys/kernel/debug/amd_pmc/s0ix_stats, the values shall be
   non-zero

On without any of above, the board may not cut device power during
suspend, and/or fail to resume and leaving a blank screen, and/or
s0ix stats remain all zeros.

[Where problems could occur]

So far all the patches can be cleanly applied, and they're being
progressively proposed to linux-stable.

[Other Info]

For kernel driver fixes, patches for both oem-5.14 and jammy are
necessary; for firmware, that has been available in jammy branch
but not yet released, so only Focal will be nominated.

V2: no change resubmit since the last part in the previous revision has
been included through stable fixes.


Nicholas Kazlauskas (3):
  drm/amd/display: Optimize bandwidth on following fast update
  drm/amd/display: Fix surface optimization regression on Carrizo
  drm/amd/display: Reset DMCUB before HW init

 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  5 ++++
 drivers/gpu/drm/amd/display/dc/core/dc.c      | 24 +++++++++++++------
 2 files changed, 22 insertions(+), 7 deletions(-)

Comments

Tim Gardner July 26, 2022, 1:19 p.m. UTC | #1
On 7/25/22 02:00, You-Sheng Yang wrote:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1957026
> 
> [Impact]
> 
> On AMD Yellow Carp B0 platforms, S0i3 is still not working.
> 
> [Fix]
> 
> This denpends on a few fixes for kernel driver that are all either in
> v5.17-rc1 or in stable linux-5.1x.y, along with an already upstreamed
> dmcub firmware.
> 
> [Test Case]
> 
> On AMD RMT CRB board,
> 1. apply both kernel and firmware fixes
> 2. module blacklist amd_sfh as it's still under development,
> 3. trigger system suspend. Use power button to wake up the device.
> 4. check /sys/kernel/debug/amd_pmc/s0ix_stats, the values shall be
>     non-zero
> 
> On without any of above, the board may not cut device power during
> suspend, and/or fail to resume and leaving a blank screen, and/or
> s0ix stats remain all zeros.
> 
> [Where problems could occur]
> 
> So far all the patches can be cleanly applied, and they're being
> progressively proposed to linux-stable.
> 
> [Other Info]
> 
> For kernel driver fixes, patches for both oem-5.14 and jammy are
> necessary; for firmware, that has been available in jammy branch
> but not yet released, so only Focal will be nominated.
> 
> V2: no change resubmit since the last part in the previous revision has
> been included through stable fixes.
> 
> 
> Nicholas Kazlauskas (3):
>    drm/amd/display: Optimize bandwidth on following fast update
>    drm/amd/display: Fix surface optimization regression on Carrizo
>    drm/amd/display: Reset DMCUB before HW init
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  5 ++++
>   drivers/gpu/drm/amd/display/dc/core/dc.c      | 24 +++++++++++++------
>   2 files changed, 22 insertions(+), 7 deletions(-)
> 
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Stefan Bader Aug. 5, 2022, 8:56 a.m. UTC | #2
On 25.07.22 10:00, You-Sheng Yang wrote:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1957026
> 
> [Impact]
> 
> On AMD Yellow Carp B0 platforms, S0i3 is still not working.
> 
> [Fix]
> 
> This denpends on a few fixes for kernel driver that are all either in
> v5.17-rc1 or in stable linux-5.1x.y, along with an already upstreamed
> dmcub firmware.
> 
> [Test Case]
> 
> On AMD RMT CRB board,
> 1. apply both kernel and firmware fixes
> 2. module blacklist amd_sfh as it's still under development,
> 3. trigger system suspend. Use power button to wake up the device.
> 4. check /sys/kernel/debug/amd_pmc/s0ix_stats, the values shall be
>     non-zero
> 
> On without any of above, the board may not cut device power during
> suspend, and/or fail to resume and leaving a blank screen, and/or
> s0ix stats remain all zeros.
> 
> [Where problems could occur]
> 
> So far all the patches can be cleanly applied, and they're being
> progressively proposed to linux-stable.
> 
> [Other Info]
> 
> For kernel driver fixes, patches for both oem-5.14 and jammy are
> necessary; for firmware, that has been available in jammy branch
> but not yet released, so only Focal will be nominated.
> 
> V2: no change resubmit since the last part in the previous revision has
> been included through stable fixes.
> 
> 
> Nicholas Kazlauskas (3):
>    drm/amd/display: Optimize bandwidth on following fast update
>    drm/amd/display: Fix surface optimization regression on Carrizo
>    drm/amd/display: Reset DMCUB before HW init
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  5 ++++
>   drivers/gpu/drm/amd/display/dc/core/dc.c      | 24 +++++++++++++------
>   2 files changed, 22 insertions(+), 7 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Aug. 5, 2022, 1:45 p.m. UTC | #3
On 25.07.22 10:00, You-Sheng Yang wrote:
> From: "You-Sheng Yang (vicamo)" <vicamo.yang@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1957026
> 
> [Impact]
> 
> On AMD Yellow Carp B0 platforms, S0i3 is still not working.
> 
> [Fix]
> 
> This denpends on a few fixes for kernel driver that are all either in
> v5.17-rc1 or in stable linux-5.1x.y, along with an already upstreamed
> dmcub firmware.
> 
> [Test Case]
> 
> On AMD RMT CRB board,
> 1. apply both kernel and firmware fixes
> 2. module blacklist amd_sfh as it's still under development,
> 3. trigger system suspend. Use power button to wake up the device.
> 4. check /sys/kernel/debug/amd_pmc/s0ix_stats, the values shall be
>     non-zero
> 
> On without any of above, the board may not cut device power during
> suspend, and/or fail to resume and leaving a blank screen, and/or
> s0ix stats remain all zeros.
> 
> [Where problems could occur]
> 
> So far all the patches can be cleanly applied, and they're being
> progressively proposed to linux-stable.
> 
> [Other Info]
> 
> For kernel driver fixes, patches for both oem-5.14 and jammy are
> necessary; for firmware, that has been available in jammy branch
> but not yet released, so only Focal will be nominated.
> 
> V2: no change resubmit since the last part in the previous revision has
> been included through stable fixes.
> 
> 
> Nicholas Kazlauskas (3):
>    drm/amd/display: Optimize bandwidth on following fast update
>    drm/amd/display: Fix surface optimization regression on Carrizo
>    drm/amd/display: Reset DMCUB before HW init
> 
>   .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c |  5 ++++
>   drivers/gpu/drm/amd/display/dc/core/dc.c      | 24 +++++++++++++------
>   2 files changed, 22 insertions(+), 7 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan