Message ID | 20220530060110.584380-1-aaron.ma@canonical.com |
---|---|
Headers | show |
Series | [OEM-5.14/Jammy,1/1] drm/i915: update new TMDS clock setting defined by VBT | expand |
Acked-by: Cengiz Can <cengiz.can@canonical.com> On Mon, 2022-05-30 at 14:01 +0800, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1976214 > > [Impact] > Call trace on new ADL-U BIOS: > kernel: ------------[ cut here ]------------ > kernel: Missing case (devdata->child.hdmi_max_data_rate == 3) > kernel: WARNING: CPU: 8 PID: 491 at > drivers/gpu/drm/i915/display/intel_bios.c:1954 > parse_ddi_port+0x724/0xab0 [i915] > kernel: Modules linked in: fjes(+) snd_intel_sdw_acpi iwlmvm(+) > snd_hda_codec intel_powerclamp snd_hda_core coretemp i915(+) mac80211 > snd_hwdep libarc4 thinkpad_acpi(+) nvram snd_pcm drm_buddy > platform_profile ledtrig_audio ttm kv> > kernel: think_lmi(+) syscopyarea serio_raw efi_pstore > firmware_attributes_class wmi_bmof mtd hid_multitouch ecc intel_cstate > joydev nci cfg80211 industrialio mei_me snd clk_tps68470 sysfillrect > videodev typec_ucsi intel_rapl_comm> > kernel: CPU: 8 PID: 491 Comm: systemd-udevd Not tainted > 5.18.0-051800rc6-generic #202205082130 > kernel: Hardware name: LENOVO 21CDSIT245/21CDSIT245, BIOS N3AET58W (1.23 > ) 04/15/2022 > kernel: RIP: 0010:parse_ddi_port+0x724/0xab0 [i915] > kernel: calling iwl_mvm_init+0x0/0x1000 [iwlmvm] @ 645 > kernel: Code: 45 31 ed 45 0f b6 c9 e9 89 fa ff ff 0f b6 d0 48 c7 c6 90 > c7 b8 c1 48 c7 c7 ea 2e b7 c1 4c 89 5d c8 4c 89 55 d0 e8 92 5c ee e0 > <0f> 0b 4c 8b 55 d0 4c 8b 5d c8 e9 f8 fb ff ff 31 db e9 7d fa ff ff > kernel: RSP: 0018:ffffac58c136b910 EFLAGS: 00010282 > kernel: RAX: 0000000000000000 RBX: 0000000000000009 RCX: > 0000000000000027 > kernel: RDX: ffff8e63376205a8 RSI: 0000000000000001 RDI: > ffff8e63376205a0 > kernel: RBP: ffffac58c136b968 R08: 0000000000000003 R09: > 0000000000000019 > kernel: R10: 000000000000000a R11: 20676e697373694d R12: > ffff8e5c4e7c0000 > kernel: R13: 0000000000000001 R14: 0000000000000000 R15: > 0000000000000042 > kernel: FS: 00007f17f9ba2880(0000) GS:ffff8e6337600000(0000) > knlGS:0000000000000000 > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > kernel: CR2: 000055695ac9c7c8 CR3: 0000000118806002 CR4: > 0000000000770ee0 > kernel: PKRU: 55555554 > kernel: Call Trace: > kernel: <TASK> > kernel: intel_bios_init+0x4f5/0x6a0 [i915] > kernel: intel_modeset_init_noirq+0x3a/0x260 [i915] > kernel: i915_driver_probe+0x201/0x590 [i915] > kernel: ? acpi_dev_found+0x66/0x70 > kernel: i915_pci_probe+0x58/0x140 [i915] > kernel: local_pci_probe+0x48/0x90 > kernel: pci_call_probe+0x55/0x180 > kernel: pci_device_probe+0x84/0x110 > kernel: really_probe+0x1b3/0x390 > kernel: __driver_probe_device+0x96/0x190 > kernel: driver_probe_device+0x23/0xc0 > kernel: __driver_attach+0xbd/0x1d0 > kernel: ? __device_attach_driver+0x110/0x110 > kernel: bus_for_each_dev+0x7c/0xc0 > kernel: driver_attach+0x1e/0x30 > kernel: bus_add_driver+0x162/0x200 > kernel: driver_register+0x95/0xf0 > kernel: __pci_register_driver+0x68/0x70 > kernel: i915_pci_register_driver+0x23/0x30 [i915] > kernel: i915_init+0x3b/0xeb [i915] > kernel: ? 0xffffffffc1c70000 > kernel: do_one_initcall+0x46/0x210 > kernel: ? kmem_cache_alloc_trace+0x1a6/0x320 > kernel: do_init_module+0x52/0x260 > kernel: load_module+0xb81/0xc90 > kernel: __do_sys_finit_module+0xc5/0x130 > kernel: __x64_sys_finit_module+0x18/0x20 > kernel: do_syscall_64+0x59/0x80 > kernel: ? do_syscall_64+0x69/0x80 > kernel: ? irqentry_exit+0x35/0x40 > kernel: ? sysvec_reschedule_ipi+0x7b/0x120 > kernel: ? asm_sysvec_reschedule_ipi+0xa/0x20 > kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae > kernel: RIP: 0033:0x7f17f9e4b73d > kernel: Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 > f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 > <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 23 37 0d 00 f7 d8 64 89 01 48 > kernel: RSP: 002b:00007ffc5d349e18 EFLAGS: 00000246 ORIG_RAX: > 0000000000000139 > kernel: RAX: ffffffffffffffda RBX: 00005644ea7d3960 RCX: > 00007f17f9e4b73d > kernel: RDX: 0000000000000000 RSI: 00005644ea7db9a0 RDI: > 0000000000000019 > kernel: RBP: 0000000000020000 R08: 0000000000000000 R09: > 0000000000000000 > kernel: R10: 0000000000000019 R11: 0000000000000246 R12: > 00005644ea7db9a0 > kernel: R13: 0000000000000000 R14: 00005644ea5aaf60 R15: > 00005644ea7d3960 > kernel: </TASK> > kernel: ---[ end trace 0000000000000000 ]--- > > [Fix] > Update new TMDS clock setting defined by VBT to configure max > TMDS clock rate. > > [Test] > Verified on hardware, no errors or calltrace. > > [Where problems could occur] > Low risk, add new definition on new hardware. It may break i915 driver. > > Backported in minor change because this part of code is made to a > function. > > Lee Shawn C (1): > drm/i915: update new TMDS clock setting defined by VBT > > drivers/gpu/drm/i915/display/intel_bios.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +++ > 2 files changed, 12 insertions(+) > > -- > 2.34.1 > >
Acked-by: Tim Gardner <tim.gardner@canonical.com> On 5/30/22 00:01, Aaron Ma wrote: > BugLink: https://bugs.launchpad.net/bugs/1976214 > > [Impact] > Call trace on new ADL-U BIOS: > kernel: ------------[ cut here ]------------ > kernel: Missing case (devdata->child.hdmi_max_data_rate == 3) > kernel: WARNING: CPU: 8 PID: 491 at > drivers/gpu/drm/i915/display/intel_bios.c:1954 > parse_ddi_port+0x724/0xab0 [i915] > kernel: Modules linked in: fjes(+) snd_intel_sdw_acpi iwlmvm(+) > snd_hda_codec intel_powerclamp snd_hda_core coretemp i915(+) mac80211 > snd_hwdep libarc4 thinkpad_acpi(+) nvram snd_pcm drm_buddy > platform_profile ledtrig_audio ttm kv> > kernel: think_lmi(+) syscopyarea serio_raw efi_pstore > firmware_attributes_class wmi_bmof mtd hid_multitouch ecc intel_cstate > joydev nci cfg80211 industrialio mei_me snd clk_tps68470 sysfillrect > videodev typec_ucsi intel_rapl_comm> > kernel: CPU: 8 PID: 491 Comm: systemd-udevd Not tainted > 5.18.0-051800rc6-generic #202205082130 > kernel: Hardware name: LENOVO 21CDSIT245/21CDSIT245, BIOS N3AET58W (1.23 > ) 04/15/2022 > kernel: RIP: 0010:parse_ddi_port+0x724/0xab0 [i915] > kernel: calling iwl_mvm_init+0x0/0x1000 [iwlmvm] @ 645 > kernel: Code: 45 31 ed 45 0f b6 c9 e9 89 fa ff ff 0f b6 d0 48 c7 c6 90 > c7 b8 c1 48 c7 c7 ea 2e b7 c1 4c 89 5d c8 4c 89 55 d0 e8 92 5c ee e0 > <0f> 0b 4c 8b 55 d0 4c 8b 5d c8 e9 f8 fb ff ff 31 db e9 7d fa ff ff > kernel: RSP: 0018:ffffac58c136b910 EFLAGS: 00010282 > kernel: RAX: 0000000000000000 RBX: 0000000000000009 RCX: > 0000000000000027 > kernel: RDX: ffff8e63376205a8 RSI: 0000000000000001 RDI: > ffff8e63376205a0 > kernel: RBP: ffffac58c136b968 R08: 0000000000000003 R09: > 0000000000000019 > kernel: R10: 000000000000000a R11: 20676e697373694d R12: > ffff8e5c4e7c0000 > kernel: R13: 0000000000000001 R14: 0000000000000000 R15: > 0000000000000042 > kernel: FS: 00007f17f9ba2880(0000) GS:ffff8e6337600000(0000) > knlGS:0000000000000000 > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > kernel: CR2: 000055695ac9c7c8 CR3: 0000000118806002 CR4: > 0000000000770ee0 > kernel: PKRU: 55555554 > kernel: Call Trace: > kernel: <TASK> > kernel: intel_bios_init+0x4f5/0x6a0 [i915] > kernel: intel_modeset_init_noirq+0x3a/0x260 [i915] > kernel: i915_driver_probe+0x201/0x590 [i915] > kernel: ? acpi_dev_found+0x66/0x70 > kernel: i915_pci_probe+0x58/0x140 [i915] > kernel: local_pci_probe+0x48/0x90 > kernel: pci_call_probe+0x55/0x180 > kernel: pci_device_probe+0x84/0x110 > kernel: really_probe+0x1b3/0x390 > kernel: __driver_probe_device+0x96/0x190 > kernel: driver_probe_device+0x23/0xc0 > kernel: __driver_attach+0xbd/0x1d0 > kernel: ? __device_attach_driver+0x110/0x110 > kernel: bus_for_each_dev+0x7c/0xc0 > kernel: driver_attach+0x1e/0x30 > kernel: bus_add_driver+0x162/0x200 > kernel: driver_register+0x95/0xf0 > kernel: __pci_register_driver+0x68/0x70 > kernel: i915_pci_register_driver+0x23/0x30 [i915] > kernel: i915_init+0x3b/0xeb [i915] > kernel: ? 0xffffffffc1c70000 > kernel: do_one_initcall+0x46/0x210 > kernel: ? kmem_cache_alloc_trace+0x1a6/0x320 > kernel: do_init_module+0x52/0x260 > kernel: load_module+0xb81/0xc90 > kernel: __do_sys_finit_module+0xc5/0x130 > kernel: __x64_sys_finit_module+0x18/0x20 > kernel: do_syscall_64+0x59/0x80 > kernel: ? do_syscall_64+0x69/0x80 > kernel: ? irqentry_exit+0x35/0x40 > kernel: ? sysvec_reschedule_ipi+0x7b/0x120 > kernel: ? asm_sysvec_reschedule_ipi+0xa/0x20 > kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae > kernel: RIP: 0033:0x7f17f9e4b73d > kernel: Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 > f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 > <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 23 37 0d 00 f7 d8 64 89 01 48 > kernel: RSP: 002b:00007ffc5d349e18 EFLAGS: 00000246 ORIG_RAX: > 0000000000000139 > kernel: RAX: ffffffffffffffda RBX: 00005644ea7d3960 RCX: > 00007f17f9e4b73d > kernel: RDX: 0000000000000000 RSI: 00005644ea7db9a0 RDI: > 0000000000000019 > kernel: RBP: 0000000000020000 R08: 0000000000000000 R09: > 0000000000000000 > kernel: R10: 0000000000000019 R11: 0000000000000246 R12: > 00005644ea7db9a0 > kernel: R13: 0000000000000000 R14: 00005644ea5aaf60 R15: > 00005644ea7d3960 > kernel: </TASK> > kernel: ---[ end trace 0000000000000000 ]--- > > [Fix] > Update new TMDS clock setting defined by VBT to configure max > TMDS clock rate. > > [Test] > Verified on hardware, no errors or calltrace. > > [Where problems could occur] > Low risk, add new definition on new hardware. It may break i915 driver. > > Backported in minor change because this part of code is made to a > function. > > Lee Shawn C (1): > drm/i915: update new TMDS clock setting defined by VBT > > drivers/gpu/drm/i915/display/intel_bios.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +++ > 2 files changed, 12 insertions(+) >
Aaron Ma kirjoitti 30.5.2022 klo 9.01: > BugLink: https://bugs.launchpad.net/bugs/1976214 > > [Impact] > Call trace on new ADL-U BIOS: > kernel: ------------[ cut here ]------------ > kernel: Missing case (devdata->child.hdmi_max_data_rate == 3) > kernel: WARNING: CPU: 8 PID: 491 at > drivers/gpu/drm/i915/display/intel_bios.c:1954 > parse_ddi_port+0x724/0xab0 [i915] > kernel: Modules linked in: fjes(+) snd_intel_sdw_acpi iwlmvm(+) > snd_hda_codec intel_powerclamp snd_hda_core coretemp i915(+) mac80211 > snd_hwdep libarc4 thinkpad_acpi(+) nvram snd_pcm drm_buddy > platform_profile ledtrig_audio ttm kv> > kernel: think_lmi(+) syscopyarea serio_raw efi_pstore > firmware_attributes_class wmi_bmof mtd hid_multitouch ecc intel_cstate > joydev nci cfg80211 industrialio mei_me snd clk_tps68470 sysfillrect > videodev typec_ucsi intel_rapl_comm> > kernel: CPU: 8 PID: 491 Comm: systemd-udevd Not tainted > 5.18.0-051800rc6-generic #202205082130 > kernel: Hardware name: LENOVO 21CDSIT245/21CDSIT245, BIOS N3AET58W (1.23 > ) 04/15/2022 > kernel: RIP: 0010:parse_ddi_port+0x724/0xab0 [i915] > kernel: calling iwl_mvm_init+0x0/0x1000 [iwlmvm] @ 645 > kernel: Code: 45 31 ed 45 0f b6 c9 e9 89 fa ff ff 0f b6 d0 48 c7 c6 90 > c7 b8 c1 48 c7 c7 ea 2e b7 c1 4c 89 5d c8 4c 89 55 d0 e8 92 5c ee e0 > <0f> 0b 4c 8b 55 d0 4c 8b 5d c8 e9 f8 fb ff ff 31 db e9 7d fa ff ff > kernel: RSP: 0018:ffffac58c136b910 EFLAGS: 00010282 > kernel: RAX: 0000000000000000 RBX: 0000000000000009 RCX: > 0000000000000027 > kernel: RDX: ffff8e63376205a8 RSI: 0000000000000001 RDI: > ffff8e63376205a0 > kernel: RBP: ffffac58c136b968 R08: 0000000000000003 R09: > 0000000000000019 > kernel: R10: 000000000000000a R11: 20676e697373694d R12: > ffff8e5c4e7c0000 > kernel: R13: 0000000000000001 R14: 0000000000000000 R15: > 0000000000000042 > kernel: FS: 00007f17f9ba2880(0000) GS:ffff8e6337600000(0000) > knlGS:0000000000000000 > kernel: CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > kernel: CR2: 000055695ac9c7c8 CR3: 0000000118806002 CR4: > 0000000000770ee0 > kernel: PKRU: 55555554 > kernel: Call Trace: > kernel: <TASK> > kernel: intel_bios_init+0x4f5/0x6a0 [i915] > kernel: intel_modeset_init_noirq+0x3a/0x260 [i915] > kernel: i915_driver_probe+0x201/0x590 [i915] > kernel: ? acpi_dev_found+0x66/0x70 > kernel: i915_pci_probe+0x58/0x140 [i915] > kernel: local_pci_probe+0x48/0x90 > kernel: pci_call_probe+0x55/0x180 > kernel: pci_device_probe+0x84/0x110 > kernel: really_probe+0x1b3/0x390 > kernel: __driver_probe_device+0x96/0x190 > kernel: driver_probe_device+0x23/0xc0 > kernel: __driver_attach+0xbd/0x1d0 > kernel: ? __device_attach_driver+0x110/0x110 > kernel: bus_for_each_dev+0x7c/0xc0 > kernel: driver_attach+0x1e/0x30 > kernel: bus_add_driver+0x162/0x200 > kernel: driver_register+0x95/0xf0 > kernel: __pci_register_driver+0x68/0x70 > kernel: i915_pci_register_driver+0x23/0x30 [i915] > kernel: i915_init+0x3b/0xeb [i915] > kernel: ? 0xffffffffc1c70000 > kernel: do_one_initcall+0x46/0x210 > kernel: ? kmem_cache_alloc_trace+0x1a6/0x320 > kernel: do_init_module+0x52/0x260 > kernel: load_module+0xb81/0xc90 > kernel: __do_sys_finit_module+0xc5/0x130 > kernel: __x64_sys_finit_module+0x18/0x20 > kernel: do_syscall_64+0x59/0x80 > kernel: ? do_syscall_64+0x69/0x80 > kernel: ? irqentry_exit+0x35/0x40 > kernel: ? sysvec_reschedule_ipi+0x7b/0x120 > kernel: ? asm_sysvec_reschedule_ipi+0xa/0x20 > kernel: entry_SYSCALL_64_after_hwframe+0x44/0xae > kernel: RIP: 0033:0x7f17f9e4b73d > kernel: Code: 00 c3 66 2e 0f 1f 84 00 00 00 00 00 90 f3 0f 1e fa 48 89 > f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 > <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d 23 37 0d 00 f7 d8 64 89 01 48 > kernel: RSP: 002b:00007ffc5d349e18 EFLAGS: 00000246 ORIG_RAX: > 0000000000000139 > kernel: RAX: ffffffffffffffda RBX: 00005644ea7d3960 RCX: > 00007f17f9e4b73d > kernel: RDX: 0000000000000000 RSI: 00005644ea7db9a0 RDI: > 0000000000000019 > kernel: RBP: 0000000000020000 R08: 0000000000000000 R09: > 0000000000000000 > kernel: R10: 0000000000000019 R11: 0000000000000246 R12: > 00005644ea7db9a0 > kernel: R13: 0000000000000000 R14: 00005644ea5aaf60 R15: > 00005644ea7d3960 > kernel: </TASK> > kernel: ---[ end trace 0000000000000000 ]--- > > [Fix] > Update new TMDS clock setting defined by VBT to configure max > TMDS clock rate. > > [Test] > Verified on hardware, no errors or calltrace. > > [Where problems could occur] > Low risk, add new definition on new hardware. It may break i915 driver. > > Backported in minor change because this part of code is made to a > function. > > Lee Shawn C (1): > drm/i915: update new TMDS clock setting defined by VBT > > drivers/gpu/drm/i915/display/intel_bios.c | 9 +++++++++ > drivers/gpu/drm/i915/display/intel_vbt_defs.h | 3 +++ > 2 files changed, 12 insertions(+) > applied to oem-kernels, thanks