mbox series

[0/1,SRU,J,OEM-5.14] ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops

Message ID 20220427075617.40852-1-andy.chi@canonical.com
Headers show
Series ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops | expand

Message

Andy Chi April 27, 2022, 7:56 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1970552

[Impact]
The mic mute/audio mute LEDS are not work on
1) HP EliteBook x360 830 G9
2) HP EliteBook 830 G9
3) HP EliteBook 840 G9
4) HP EliteBook 860 G9
5) HP EliteBook 840 Aero G9
6) HP EliteBook x360 840 Aero G9

[Fix]
It needs the specific quirk for the hardware layout.
Thus, add the quirks to make it works.

[Test]
After applying the quirk, the audio/mic mute LEDs are working good.

[Where problems could occur]
If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).

Andy Chi (1):
  ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops

 sound/pci/hda/patch_realtek.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Tim Gardner April 27, 2022, 2:18 p.m. UTC | #1
Acked-by: Tim Gardner <tim.gardner@canonical.com>

On 4/27/22 01:56, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1970552
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP EliteBook x360 830 G9
> 2) HP EliteBook 830 G9
> 3) HP EliteBook 840 G9
> 4) HP EliteBook 860 G9
> 5) HP EliteBook 840 Aero G9
> 6) HP EliteBook x360 840 Aero G9
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
> 
>   sound/pci/hda/patch_realtek.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
>
Timo Aaltonen May 3, 2022, 5:06 a.m. UTC | #2
Andy Chi kirjoitti 27.4.2022 klo 10.56:
> BugLink: https://bugs.launchpad.net/bugs/1970552
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP EliteBook x360 830 G9
> 2) HP EliteBook 830 G9
> 3) HP EliteBook 840 G9
> 4) HP EliteBook 860 G9
> 5) HP EliteBook 840 Aero G9
> 6) HP EliteBook x360 840 Aero G9
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
> 
>   sound/pci/hda/patch_realtek.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

applied to oem-5.14, thanks
Stefan Bader May 5, 2022, 7:55 a.m. UTC | #3
On 27.04.22 09:56, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1970552
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP EliteBook x360 830 G9
> 2) HP EliteBook 830 G9
> 3) HP EliteBook 840 G9
> 4) HP EliteBook 860 G9
> 5) HP EliteBook 840 Aero G9
> 6) HP EliteBook x360 840 Aero G9
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
> 
>   sound/pci/hda/patch_realtek.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader May 5, 2022, 12:40 p.m. UTC | #4
On 27.04.22 09:56, Andy Chi wrote:
> BugLink: https://bugs.launchpad.net/bugs/1970552
> 
> [Impact]
> The mic mute/audio mute LEDS are not work on
> 1) HP EliteBook x360 830 G9
> 2) HP EliteBook 830 G9
> 3) HP EliteBook 840 G9
> 4) HP EliteBook 860 G9
> 5) HP EliteBook 840 Aero G9
> 6) HP EliteBook x360 840 Aero G9
> 
> [Fix]
> It needs the specific quirk for the hardware layout.
> Thus, add the quirks to make it works.
> 
> [Test]
> After applying the quirk, the audio/mic mute LEDs are working good.
> 
> [Where problems could occur]
> If HP ships the different system boards design with the same subsystem ID of audio codec which is using different GPIO pins (different layout), then the quirk will not work (LEDs will not work when muting audio-output or microphone).
> 
> Andy Chi (1):
>    ALSA: hda/realtek: Enable mute/micmute LEDs support for HP Laptops
> 
>   sound/pci/hda/patch_realtek.c | 12 ++++++------
>   1 file changed, 6 insertions(+), 6 deletions(-)
> 

Applied to jammy:linux/master-next. Thanks.

-Stefan