mbox series

[0/2,SRU,OEM-5.14] Choppy trackpad/USB mouse on AMD Rembrandt with PSR enabled panel

Message ID 20220316075109.3371061-1-vicamo.yang@canonical.com
Headers show
Series Choppy trackpad/USB mouse on AMD Rembrandt with PSR enabled panel | expand

Message

You-Sheng Yang March 16, 2022, 7:51 a.m. UTC
BugLink: https://bugs.launchpad.net/amd/+bug/1964850

[Impact]

Disjoint trackpad/mouse path found on PSR capable panels.

[Fix]

Two fixes from v5.17-rc6 that only turns off vblank IRQs when PSR is not
enabled, originally for commit f94cf1cb1796 ("drm/amdgpu/display: set
vblank_disable_immediate for DC") that was being backported to LTS stable
5.15.y, and therefore oem-5.14.

[Test Case]

Simply move the mouse around.

[Where problems could occur]

This follows for AMD platforms, the power-saving performance may not be
as good as before, but while we don't have such energy-saving
certificate program for AMD yet, this would become something to be fully
addressed in the future.

[Other Info]

These fixes have been applied to v5.15.27, and oem-5.14 currently has
v5.15.25 in -1028, therefore only oem-5.14 is nominated, but probably
they will still be included through stable patch backport in the next
release.

Michel Dänzer (1):
  drm/amd/display: For vblank_disable_immediate, check PSR is really
    used

Nicholas Kazlauskas (1):
  drm/amdgpu/display: Only set vblank_disable_immediate when PSR is not
    enabled

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

Comments

Timo Aaltonen March 17, 2022, 5:21 p.m. UTC | #1
You-Sheng Yang kirjoitti 16.3.2022 klo 9.51:
> BugLink: https://bugs.launchpad.net/amd/+bug/1964850
> 
> [Impact]
> 
> Disjoint trackpad/mouse path found on PSR capable panels.
> 
> [Fix]
> 
> Two fixes from v5.17-rc6 that only turns off vblank IRQs when PSR is not
> enabled, originally for commit f94cf1cb1796 ("drm/amdgpu/display: set
> vblank_disable_immediate for DC") that was being backported to LTS stable
> 5.15.y, and therefore oem-5.14.
> 
> [Test Case]
> 
> Simply move the mouse around.
> 
> [Where problems could occur]
> 
> This follows for AMD platforms, the power-saving performance may not be
> as good as before, but while we don't have such energy-saving
> certificate program for AMD yet, this would become something to be fully
> addressed in the future.
> 
> [Other Info]
> 
> These fixes have been applied to v5.15.27, and oem-5.14 currently has
> v5.15.25 in -1028, therefore only oem-5.14 is nominated, but probably
> they will still be included through stable patch backport in the next
> release.
> 
> Michel Dänzer (1):
>    drm/amd/display: For vblank_disable_immediate, check PSR is really
>      used
> 
> Nicholas Kazlauskas (1):
>    drm/amdgpu/display: Only set vblank_disable_immediate when PSR is not
>      enabled
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 12 +++++++++---
>   1 file changed, 9 insertions(+), 3 deletions(-)
> 

applied to oem-5.14, thanks