| Message ID | 20211014170010.581679-1-kai.heng.feng@canonical.com |
|---|---|
| Headers | show |
| Series | Add support for Realtek 8852AE WiFi | expand |
Acked-by: Tim Gardner <tim.gardner@canonical.com> Code changes are isolated to the new driver. Can't be any worse then some of the staging drivers. Note that this driver will get packaged in linux-modules-extra, where it appears all drivers/net/wireless drivers go. On 10/14/21 11:00 AM, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1945967 > > [Impact] > Realtek 8852AE, which is used by many new laptops, doesn't have a > driver. > > [Fix] > Add rtw89 driver to support Realtek 8852AE. > > [Test] > After applying the patch, 8852AE can scan, connect and do TX/RX. > > [Where problems could occur] > This is a brand new driver, unless the driver hits some subtle PCI or > IOMMU bugs, there isn't much chance to introduce any regression. > > Kai-Heng Feng (1): > UBUNTU: [Config] RTW89=m > > Ping-Ke Shih (1): > UBUNTU: SAUCE: rtw89: add Realtek 802.11ax driver > > debian.master/config/annotations | 9 + > debian.master/config/config.common.ubuntu | 7 + > drivers/net/wireless/realtek/Kconfig | 1 + > drivers/net/wireless/realtek/Makefile | 1 + > drivers/net/wireless/realtek/rtw89/Kconfig | 50 + > drivers/net/wireless/realtek/rtw89/Makefile | 25 + > drivers/net/wireless/realtek/rtw89/cam.c | 695 + > drivers/net/wireless/realtek/rtw89/cam.h | 165 + > drivers/net/wireless/realtek/rtw89/coex.c | 5716 ++ > drivers/net/wireless/realtek/rtw89/coex.h | 181 + > drivers/net/wireless/realtek/rtw89/core.c | 2502 + > drivers/net/wireless/realtek/rtw89/core.h | 3384 ++ > drivers/net/wireless/realtek/rtw89/debug.c | 2489 + > drivers/net/wireless/realtek/rtw89/debug.h | 77 + > drivers/net/wireless/realtek/rtw89/efuse.c | 188 + > drivers/net/wireless/realtek/rtw89/efuse.h | 13 + > drivers/net/wireless/realtek/rtw89/fw.c | 1641 + > drivers/net/wireless/realtek/rtw89/fw.h | 1378 + > drivers/net/wireless/realtek/rtw89/mac.c | 3838 ++ > drivers/net/wireless/realtek/rtw89/mac.h | 860 + > drivers/net/wireless/realtek/rtw89/mac80211.c | 676 + > drivers/net/wireless/realtek/rtw89/pci.c | 3060 + > drivers/net/wireless/realtek/rtw89/pci.h | 635 + > drivers/net/wireless/realtek/rtw89/phy.c | 2868 + > drivers/net/wireless/realtek/rtw89/phy.h | 311 + > drivers/net/wireless/realtek/rtw89/ps.c | 150 + > drivers/net/wireless/realtek/rtw89/ps.h | 16 + > drivers/net/wireless/realtek/rtw89/reg.h | 2159 + > drivers/net/wireless/realtek/rtw89/regd.c | 353 + > drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2036 + > drivers/net/wireless/realtek/rtw89/rtw8852a.h | 109 + > .../net/wireless/realtek/rtw89/rtw8852a_rfk.c | 3911 ++ > .../net/wireless/realtek/rtw89/rtw8852a_rfk.h | 24 + > .../realtek/rtw89/rtw8852a_rfk_table.c | 1607 + > .../realtek/rtw89/rtw8852a_rfk_table.h | 133 + > .../wireless/realtek/rtw89/rtw8852a_table.c | 48725 ++++++++++++++++ > .../wireless/realtek/rtw89/rtw8852a_table.h | 28 + > drivers/net/wireless/realtek/rtw89/sar.c | 190 + > drivers/net/wireless/realtek/rtw89/sar.h | 26 + > drivers/net/wireless/realtek/rtw89/ser.c | 491 + > drivers/net/wireless/realtek/rtw89/ser.h | 15 + > drivers/net/wireless/realtek/rtw89/txrx.h | 358 + > drivers/net/wireless/realtek/rtw89/util.h | 17 + > 43 files changed, 91118 insertions(+) > create mode 100644 drivers/net/wireless/realtek/rtw89/Kconfig > create mode 100644 drivers/net/wireless/realtek/rtw89/Makefile > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.c > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.h > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.c > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.h > create mode 100644 drivers/net/wireless/realtek/rtw89/core.c > create mode 100644 drivers/net/wireless/realtek/rtw89/core.h > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.c > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.h > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.c > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.h > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.c > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.h > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.c > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.h > create mode 100644 drivers/net/wireless/realtek/rtw89/mac80211.c > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.c > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.h > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.c > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.h > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.c > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.h > create mode 100644 drivers/net/wireless/realtek/rtw89/reg.h > create mode 100644 drivers/net/wireless/realtek/rtw89/regd.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.h > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.c > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.h > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.c > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.h > create mode 100644 drivers/net/wireless/realtek/rtw89/txrx.h > create mode 100644 drivers/net/wireless/realtek/rtw89/util.h >
Hi Kai-Heng, This driver made it to linux-next with a different SHA1 (e3ec7017f6a2) and it already has some fixes, from which at least one is a real bug fix. Could you please re-send cherry-picking from linux-next and with the additional fix(es)? Thanks, Kleber On 14.10.21 19:00, Kai-Heng Feng wrote: > BugLink: https://bugs.launchpad.net/bugs/1945967 > > [Impact] > Realtek 8852AE, which is used by many new laptops, doesn't have a > driver. > > [Fix] > Add rtw89 driver to support Realtek 8852AE. > > [Test] > After applying the patch, 8852AE can scan, connect and do TX/RX. > > [Where problems could occur] > This is a brand new driver, unless the driver hits some subtle PCI or > IOMMU bugs, there isn't much chance to introduce any regression. > > Kai-Heng Feng (1): > UBUNTU: [Config] RTW89=m > > Ping-Ke Shih (1): > UBUNTU: SAUCE: rtw89: add Realtek 802.11ax driver > > debian.master/config/annotations | 9 + > debian.master/config/config.common.ubuntu | 7 + > drivers/net/wireless/realtek/Kconfig | 1 + > drivers/net/wireless/realtek/Makefile | 1 + > drivers/net/wireless/realtek/rtw89/Kconfig | 50 + > drivers/net/wireless/realtek/rtw89/Makefile | 25 + > drivers/net/wireless/realtek/rtw89/cam.c | 695 + > drivers/net/wireless/realtek/rtw89/cam.h | 165 + > drivers/net/wireless/realtek/rtw89/coex.c | 5716 ++ > drivers/net/wireless/realtek/rtw89/coex.h | 181 + > drivers/net/wireless/realtek/rtw89/core.c | 2502 + > drivers/net/wireless/realtek/rtw89/core.h | 3384 ++ > drivers/net/wireless/realtek/rtw89/debug.c | 2489 + > drivers/net/wireless/realtek/rtw89/debug.h | 77 + > drivers/net/wireless/realtek/rtw89/efuse.c | 188 + > drivers/net/wireless/realtek/rtw89/efuse.h | 13 + > drivers/net/wireless/realtek/rtw89/fw.c | 1641 + > drivers/net/wireless/realtek/rtw89/fw.h | 1378 + > drivers/net/wireless/realtek/rtw89/mac.c | 3838 ++ > drivers/net/wireless/realtek/rtw89/mac.h | 860 + > drivers/net/wireless/realtek/rtw89/mac80211.c | 676 + > drivers/net/wireless/realtek/rtw89/pci.c | 3060 + > drivers/net/wireless/realtek/rtw89/pci.h | 635 + > drivers/net/wireless/realtek/rtw89/phy.c | 2868 + > drivers/net/wireless/realtek/rtw89/phy.h | 311 + > drivers/net/wireless/realtek/rtw89/ps.c | 150 + > drivers/net/wireless/realtek/rtw89/ps.h | 16 + > drivers/net/wireless/realtek/rtw89/reg.h | 2159 + > drivers/net/wireless/realtek/rtw89/regd.c | 353 + > drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2036 + > drivers/net/wireless/realtek/rtw89/rtw8852a.h | 109 + > .../net/wireless/realtek/rtw89/rtw8852a_rfk.c | 3911 ++ > .../net/wireless/realtek/rtw89/rtw8852a_rfk.h | 24 + > .../realtek/rtw89/rtw8852a_rfk_table.c | 1607 + > .../realtek/rtw89/rtw8852a_rfk_table.h | 133 + > .../wireless/realtek/rtw89/rtw8852a_table.c | 48725 ++++++++++++++++ > .../wireless/realtek/rtw89/rtw8852a_table.h | 28 + > drivers/net/wireless/realtek/rtw89/sar.c | 190 + > drivers/net/wireless/realtek/rtw89/sar.h | 26 + > drivers/net/wireless/realtek/rtw89/ser.c | 491 + > drivers/net/wireless/realtek/rtw89/ser.h | 15 + > drivers/net/wireless/realtek/rtw89/txrx.h | 358 + > drivers/net/wireless/realtek/rtw89/util.h | 17 + > 43 files changed, 91118 insertions(+) > create mode 100644 drivers/net/wireless/realtek/rtw89/Kconfig > create mode 100644 drivers/net/wireless/realtek/rtw89/Makefile > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.c > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.h > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.c > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.h > create mode 100644 drivers/net/wireless/realtek/rtw89/core.c > create mode 100644 drivers/net/wireless/realtek/rtw89/core.h > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.c > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.h > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.c > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.h > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.c > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.h > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.c > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.h > create mode 100644 drivers/net/wireless/realtek/rtw89/mac80211.c > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.c > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.h > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.c > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.h > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.c > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.h > create mode 100644 drivers/net/wireless/realtek/rtw89/reg.h > create mode 100644 drivers/net/wireless/realtek/rtw89/regd.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.h > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.c > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.h > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.c > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.h > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.c > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.h > create mode 100644 drivers/net/wireless/realtek/rtw89/txrx.h > create mode 100644 drivers/net/wireless/realtek/rtw89/util.h >
Hi Kleber, On Fri, Oct 22, 2021 at 10:25 PM Kleber Souza <kleber.souza@canonical.com> wrote: > > Hi Kai-Heng, > > This driver made it to linux-next with a different SHA1 > (e3ec7017f6a2) and it already has some fixes, from which > at least one is a real bug fix. > > Could you please re-send cherry-picking from linux-next > and with the additional fix(es)? Thanks for the checking, I'll send V2 with the fixes. Kai-Heng > > > Thanks, > Kleber > > > On 14.10.21 19:00, Kai-Heng Feng wrote: > > BugLink: https://bugs.launchpad.net/bugs/1945967 > > > > [Impact] > > Realtek 8852AE, which is used by many new laptops, doesn't have a > > driver. > > > > [Fix] > > Add rtw89 driver to support Realtek 8852AE. > > > > [Test] > > After applying the patch, 8852AE can scan, connect and do TX/RX. > > > > [Where problems could occur] > > This is a brand new driver, unless the driver hits some subtle PCI or > > IOMMU bugs, there isn't much chance to introduce any regression. > > > > Kai-Heng Feng (1): > > UBUNTU: [Config] RTW89=m > > > > Ping-Ke Shih (1): > > UBUNTU: SAUCE: rtw89: add Realtek 802.11ax driver > > > > debian.master/config/annotations | 9 + > > debian.master/config/config.common.ubuntu | 7 + > > drivers/net/wireless/realtek/Kconfig | 1 + > > drivers/net/wireless/realtek/Makefile | 1 + > > drivers/net/wireless/realtek/rtw89/Kconfig | 50 + > > drivers/net/wireless/realtek/rtw89/Makefile | 25 + > > drivers/net/wireless/realtek/rtw89/cam.c | 695 + > > drivers/net/wireless/realtek/rtw89/cam.h | 165 + > > drivers/net/wireless/realtek/rtw89/coex.c | 5716 ++ > > drivers/net/wireless/realtek/rtw89/coex.h | 181 + > > drivers/net/wireless/realtek/rtw89/core.c | 2502 + > > drivers/net/wireless/realtek/rtw89/core.h | 3384 ++ > > drivers/net/wireless/realtek/rtw89/debug.c | 2489 + > > drivers/net/wireless/realtek/rtw89/debug.h | 77 + > > drivers/net/wireless/realtek/rtw89/efuse.c | 188 + > > drivers/net/wireless/realtek/rtw89/efuse.h | 13 + > > drivers/net/wireless/realtek/rtw89/fw.c | 1641 + > > drivers/net/wireless/realtek/rtw89/fw.h | 1378 + > > drivers/net/wireless/realtek/rtw89/mac.c | 3838 ++ > > drivers/net/wireless/realtek/rtw89/mac.h | 860 + > > drivers/net/wireless/realtek/rtw89/mac80211.c | 676 + > > drivers/net/wireless/realtek/rtw89/pci.c | 3060 + > > drivers/net/wireless/realtek/rtw89/pci.h | 635 + > > drivers/net/wireless/realtek/rtw89/phy.c | 2868 + > > drivers/net/wireless/realtek/rtw89/phy.h | 311 + > > drivers/net/wireless/realtek/rtw89/ps.c | 150 + > > drivers/net/wireless/realtek/rtw89/ps.h | 16 + > > drivers/net/wireless/realtek/rtw89/reg.h | 2159 + > > drivers/net/wireless/realtek/rtw89/regd.c | 353 + > > drivers/net/wireless/realtek/rtw89/rtw8852a.c | 2036 + > > drivers/net/wireless/realtek/rtw89/rtw8852a.h | 109 + > > .../net/wireless/realtek/rtw89/rtw8852a_rfk.c | 3911 ++ > > .../net/wireless/realtek/rtw89/rtw8852a_rfk.h | 24 + > > .../realtek/rtw89/rtw8852a_rfk_table.c | 1607 + > > .../realtek/rtw89/rtw8852a_rfk_table.h | 133 + > > .../wireless/realtek/rtw89/rtw8852a_table.c | 48725 ++++++++++++++++ > > .../wireless/realtek/rtw89/rtw8852a_table.h | 28 + > > drivers/net/wireless/realtek/rtw89/sar.c | 190 + > > drivers/net/wireless/realtek/rtw89/sar.h | 26 + > > drivers/net/wireless/realtek/rtw89/ser.c | 491 + > > drivers/net/wireless/realtek/rtw89/ser.h | 15 + > > drivers/net/wireless/realtek/rtw89/txrx.h | 358 + > > drivers/net/wireless/realtek/rtw89/util.h | 17 + > > 43 files changed, 91118 insertions(+) > > create mode 100644 drivers/net/wireless/realtek/rtw89/Kconfig > > create mode 100644 drivers/net/wireless/realtek/rtw89/Makefile > > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/cam.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/coex.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/core.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/core.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/debug.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/efuse.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/fw.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/mac.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/mac80211.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/pci.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/phy.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/ps.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/reg.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/regd.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_rfk_table.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/rtw8852a_table.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/sar.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.c > > create mode 100644 drivers/net/wireless/realtek/rtw89/ser.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/txrx.h > > create mode 100644 drivers/net/wireless/realtek/rtw89/util.h > > >