Message ID | 20210716084821.260594-1-chris.chiu@canonical.com |
---|---|
Headers | show
Return-Path: <kernel-team-bounces@lists.ubuntu.com> X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=<UNKNOWN>) Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.a=rsa-sha256 header.s=20210705 header.b=O7n5q/Y+; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GR4dv3cnXz9sX3; Fri, 16 Jul 2021 18:48:34 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from <kernel-team-bounces@lists.ubuntu.com>) id 1m4JWF-0005v5-TD; Fri, 16 Jul 2021 08:48:27 +0000 Received: from smtp-relay-canonical-0.internal ([10.131.114.83] helo=smtp-relay-canonical-0.canonical.com) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from <chris.chiu@canonical.com>) id 1m4JWD-0005us-RR for kernel-team@lists.ubuntu.com; Fri, 16 Jul 2021 08:48:25 +0000 Received: from localhost.localdomain (111-240-103-86.dynamic-ip.hinet.net [111.240.103.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-canonical-0.canonical.com (Postfix) with ESMTPSA id E372C408AC for <kernel-team@lists.ubuntu.com>; Fri, 16 Jul 2021 08:48:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1626425305; bh=gQqyZSExpaP9l2UrLchC38qOAtK4snRdI7TsTWmLeH4=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=O7n5q/Y+NWJEetPZJBNFdDYmIJ/WwgMfn4ERIdsGBrfbdKN4EuTxKS1HdYMJuG+G5 VkeoQTVvbvXssFNnpl4fZmz6XhfyLNieKwCGGBRGrqgKutD7JfltK50in91I2blGVb 7bk3eTG0WGim8SKaBj+8m1FpeJaZwFKua73xtJM2vy+jr3RZNDar5DS6yJez87Ex/2 VLdcy4T5kVfX3tTFHpFlbnWYaPK6erXeYZeuGeUgQsvkTCEJ1WkRa8ZUqzTuIatEXx h3iQmu5lzf88o5IHMcbJ5vZZqkvDw/lUZhGyMASwMN17MTvhx3nTgl0jWEdHKgolRb FUzwROH2P4vXw== From: chris.chiu@canonical.com To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1][SRU][H] Fix this missing NIC after resume Date: Fri, 16 Jul 2021 16:48:19 +0800 Message-Id: <20210716084821.260594-1-chris.chiu@canonical.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions <kernel-team.lists.ubuntu.com> List-Unsubscribe: <https://lists.ubuntu.com/mailman/options/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=unsubscribe> List-Archive: <https://lists.ubuntu.com/archives/kernel-team> List-Post: <mailto:kernel-team@lists.ubuntu.com> List-Help: <mailto:kernel-team-request@lists.ubuntu.com?subject=help> List-Subscribe: <https://lists.ubuntu.com/mailman/listinfo/kernel-team>, <mailto:kernel-team-request@lists.ubuntu.com?subject=subscribe> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" <kernel-team-bounces@lists.ubuntu.com> |
Series |
Fix this missing NIC after resume
|
expand
|
From: Chris Chiu <chris.chiu@canonical.com> BugLink: https://bugs.launchpad.net/bugs/1931301 [SRU Justification] [Impact] The network card will be unavailable after system resume if the interface is not UP before suspend. [Fix] It's because we added the WOL support for this driver. The driver with WoL feature does detach the network interface even the interface is DOWN. However, it doesn't attach the network interface back on resume if it was DOWN. That's why it's unavailable after resume. Fix this by correctly netif_device_attach according to the interface status. [Test Case] 1. Plug the ethernet cable to the Atheros E220x ethernet adapter 2. Suspend the system and check if the ethernet interface available after resume 3. Unplug the ethernet cable 4. Suspend the system and check if the ethernet interface available after resume [Regression Potential] Low. The driver code would be identical to working Groovy version after fix. Chris Chiu (1): UBUNTU: SAUCE: Revert "ethernet: alx: fix order of calls on resume" drivers/net/ethernet/atheros/alx/main.c | 17 ++++++++--------- 1 file changed, 8 insertions(+), 9 deletions(-)