From patchwork Wed Jul 7 11:47:26 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1501704 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4GKdBn6VTQz9t0p; Wed, 7 Jul 2021 21:54:41 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1m168T-0002xs-3k; Wed, 07 Jul 2021 11:54:37 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1m168S-0002xg-10 for kernel-team@lists.ubuntu.com; Wed, 07 Jul 2021 11:54:36 +0000 Received: from mail-pj1-f69.google.com ([209.85.216.69]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1m168R-0007n7-OU for kernel-team@lists.ubuntu.com; Wed, 07 Jul 2021 11:54:35 +0000 Received: by mail-pj1-f69.google.com with SMTP id z9-20020a17090aa489b02901724a633c70so3711696pjp.6 for ; Wed, 07 Jul 2021 04:54:35 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=aBQLzRBnGMfCzzsk4CVmgRrRAxu5lkMDmadjLl5Oj7s=; b=EE7jcIwYdcGqohxmAm03iV2XSV1ZBJSlq1k9AekreszkA/pbfny2ZE6W2PJa7SnLBz F5QTjbzyQC3DXon8tILghZt+uC1Isq8akE4nYi6bVM/xgmae1UOO1TbMcVqsFxsPdcwS DwTu6bHRYVwm0ua4Tbc4WZnsdlvjnZ0Z234h4gNOfsDxaaHzejC0j2QkTEOIapjgBNDZ C/53XYn3k84B0SPYnh3xC4tdmkiaUUvPIw/puNiK5gnA13Wl2KDXtkMSuEjAJ5YAwPRS oIsBK5pqFVcQgUJJaoH7ls6XcrQuo8BMHOh6hKpMbz6wTtKx7pzag9HesV6/IHKK3HfD JBig== X-Gm-Message-State: AOAM530akF3/Gltv41LXrUOyao/gNkoGENcyYrdShlXFFlurgFyoHynG pzpdz48Nn0QNhliJyU9jtDCsspRpgVdqlS0C6INi5Dt1+Dxu+xdD0/7ZOdxovfmdSXFuu2DjoPT gUSFNb7oTrEUGoHR01KSPxvayy6PxI+/Pe/Kb90IP X-Received: by 2002:a63:ea0e:: with SMTP id c14mr25741994pgi.117.1625658874486; Wed, 07 Jul 2021 04:54:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxAj7L1oSNQXOWRyvcBBrCDwD9HwcpzpoIrRp1mEhp7ur9Y3gcHXvCy3U9RpMrUkrqVtUMR+A== X-Received: by 2002:a63:ea0e:: with SMTP id c14mr25741968pgi.117.1625658874089; Wed, 07 Jul 2021 04:54:34 -0700 (PDT) Received: from localhost.localdomain (223-137-239-238.emome-ip.hinet.net. [223.137.239.238]) by smtp.gmail.com with ESMTPSA id 20sm19881619pfi.170.2021.07.07.04.54.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jul 2021 04:54:33 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [B][SRU][PATCH 0/4] Enable fib-onlink-tests.sh and msg_zerocopy.sh in kselftests/net Date: Wed, 7 Jul 2021 19:47:26 +0800 Message-Id: <20210707114730.40375-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" [Impact] Found this issue while debugging missing tests with bug 1934282. On Bionic there are 3 scripts that are not in the Makefile of the net test suite of kselftests: $ for file in $(ls *.sh); do grep -q $file Makefile || echo $file; done fib-onlink-tests.sh in_netns.sh msg_zerocopy.sh [Fix] * 830669e691464c selftests/net: enable msg_zerocopy test * 1751eb42ddb56b selftests: net: use TEST_PROGS_EXTENDED * a52b839752aab7 selftests: Add fib-onlink-tests.sh to TEST_PROGS * Set fib-onlink-tests.sh as executable They all need to be backported to Bionic. For the in_netns.sh it's not causing any issue to us when being called by run_afpackettests, but I think it's no harm to fix it to reduce confusions. Commit 1751eb42ddb56b will replace the changes in 9faedd64 selftests: net: add in_netns.sh TEST_GEN_PROGS_EXTENDED [1] and 5ff9c1a3 selftests: net: add in_netns.sh to TEST_PROGS [2]. Since we need to backport it there is no need to work on these two. The fib-onlink-tests.sh must be set to executable otherwise it will fail with test not executable. [1] https://github.com/torvalds/linux/commit/9faedd643fd9 [2] https://github.com/torvalds/linux/commit/5ff9c1a3dd92 [Test] Run the "net" test suite in the kselftest directory from a patched source tree. fib-onlink-tests.sh and msg_zerocopy.sh tests will be executed. [Where problems could occur] This change will bring in more test for our SRU, we might see new failures because of these test in the future. Anders Roxell (1): selftests: net: use TEST_PROGS_EXTENDED David Ahern (1): selftests: Add fib-onlink-tests.sh to TEST_PROGS Po-Hsu Lin (1): UBUNTU: SAUCE: selftests: Make fib-onlink-tests.sh executable Willem de Bruijn (1): selftests/net: enable msg_zerocopy test tools/testing/selftests/net/Makefile | 3 +++ tools/testing/selftests/net/fib-onlink-tests.sh | 0 tools/testing/selftests/net/msg_zerocopy.sh | 8 ++++++++ 3 files changed, 11 insertions(+) mode change 100644 => 100755 tools/testing/selftests/net/fib-onlink-tests.sh Acked-by: Tim Gardner Acked-by: Kleber Sacilotto de Souza