| Message ID | 20210302112258.4909-1-colin.king@canonical.com |
|---|---|
| Headers | show |
| Series | Revert SiFive Unleashed CPUFreq (LP: #1917433 | expand |
On 3/2/21 4:22 AM, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > == SRU Justifcation Hirsute RISCV == > > The SiFive Unleashed board with the current Ubuntu cpufreq default > config can hang on boot with CPU freq enabled with the latest device > tree settings. It is known that the cpufreq can be problematic so > the recommended way forward is to currently revert the cpufreq > enablement commit. > > commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 > Author: David Abdurachmanov <david.abdurachmanov@sifive.com> > Date: Tue Jan 28 02:55:56 2020 -0800 > > SiFive Unleashed CPUFreq > > == The fix(es) == > > Revert commit "SiFive Unleashed CPUFreq" > > == Test Case == > > Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. > > == Where problems could occur == > > Users expecting CPU freq scaling now don't have this working option. > This is deemed to be acceptable as without the fix their systems are > likely to be unbootable with the updated DT. > > > *** BLURB HERE *** > > Colin Ian King (2): > Revert "SiFive Unleashed CPUFreq" > UBUNTU: [Config] Update annotations for CPUFreq revert > > arch/riscv/Kconfig | 8 ----- > arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- > .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- > arch/riscv/configs/defconfig | 5 --- > debian.riscv-21.04/config/annotations | 3 +- > debian.riscv/config/annotations | 3 +- > 6 files changed, 4 insertions(+), 54 deletions(-) > Perhaps apply in reverse order. Patch 2/2 has a spelling error, "diabling". Acked-by: Tim Gardner <tim.gardner@canonical.com> ----------- Tim Gardner Canonical, Inc
On 02/03/2021 12:56, Tim Gardner wrote: > > > On 3/2/21 4:22 AM, Colin King wrote: >> From: Colin Ian King <colin.king@canonical.com> >> >> == SRU Justifcation Hirsute RISCV == >> >> The SiFive Unleashed board with the current Ubuntu cpufreq default >> config can hang on boot with CPU freq enabled with the latest device >> tree settings. It is known that the cpufreq can be problematic so >> the recommended way forward is to currently revert the cpufreq >> enablement commit. >> >> commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 >> Author: David Abdurachmanov <david.abdurachmanov@sifive.com> >> Date: Tue Jan 28 02:55:56 2020 -0800 >> >> SiFive Unleashed CPUFreq >> >> == The fix(es) == >> >> Revert commit "SiFive Unleashed CPUFreq" >> >> == Test Case == >> >> Boot with the latest DT. It should now boot. Boot without the latest >> DT, it should also boot. >> >> == Where problems could occur == >> >> Users expecting CPU freq scaling now don't have this working option. >> This is deemed to be acceptable as without the fix their systems are >> likely to be unbootable with the updated DT. >> >> >> *** BLURB HERE *** >> >> Colin Ian King (2): >> Revert "SiFive Unleashed CPUFreq" >> UBUNTU: [Config] Update annotations for CPUFreq revert >> >> arch/riscv/Kconfig | 8 ----- >> arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- >> .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- >> arch/riscv/configs/defconfig | 5 --- >> debian.riscv-21.04/config/annotations | 3 +- >> debian.riscv/config/annotations | 3 +- >> 6 files changed, 4 insertions(+), 54 deletions(-) >> > Perhaps apply in reverse order. I thinking order is a moot point, if the order is swapped we end up with config enforcing whining and breaking the build too. > > Patch 2/2 has a spelling error, "diabling". > > Acked-by: Tim Gardner <tim.gardner@canonical.com> > ----------- > Tim Gardner > Canonical, Inc
From: Colin Ian King <colin.king@canonical.com> == SRU Justifcation Hirsute RISCV == The SiFive Unleashed board with the current Ubuntu cpufreq default config can hang on boot with CPU freq enabled with the latest device tree settings. It is known that the cpufreq can be problematic so the recommended way forward is to currently revert the cpufreq enablement commit. commit 3949df6ecdca04339bc8a3925c2ba7f881cf82b1 Author: David Abdurachmanov <david.abdurachmanov@sifive.com> Date: Tue Jan 28 02:55:56 2020 -0800 SiFive Unleashed CPUFreq == The fix(es) == Revert commit "SiFive Unleashed CPUFreq" == Test Case == Boot with the latest DT. It should now boot. Boot without the latest DT, it should also boot. == Where problems could occur == Users expecting CPU freq scaling now don't have this working option. This is deemed to be acceptable as without the fix their systems are likely to be unbootable with the updated DT. *** BLURB HERE *** Colin Ian King (2): Revert "SiFive Unleashed CPUFreq" UBUNTU: [Config] Update annotations for CPUFreq revert arch/riscv/Kconfig | 8 ----- arch/riscv/boot/dts/sifive/fu540-c000.dtsi | 5 --- .../boot/dts/sifive/hifive-unleashed-a00.dts | 34 ------------------- arch/riscv/configs/defconfig | 5 --- debian.riscv-21.04/config/annotations | 3 +- debian.riscv/config/annotations | 3 +- 6 files changed, 4 insertions(+), 54 deletions(-)