mbox series

[SRU,Xenial,v3,0/4] Fix corruption on blocked_vcpu_on_cpu list

Message ID 20210118232208.11178-1-ioanna-maria.alifieraki@canonical.com
Headers show
Series Fix corruption on blocked_vcpu_on_cpu list | expand

Message

Ioanna Alifieraki Jan. 18, 2021, 11:22 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1908428

The following patches fix the bug reported in [1].
The first patch bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block) 
is pulled into to facilitate the backport of the next 3 patches that fix the bug.
Original patches come from [2] and have been accepted upstream.

[1] https://marc.info/?l=kvm&m=149559827906211&w=2
[2] https://lore.kernel.org/lkml/20170606105707.23207-1-pbonzini@redhat.com/

Paolo Bonzini (3):
  KVM: VMX: extract __pi_post_block
  KVM: VMX: avoid double list add with VT-d posted interrupts
  KVM: VMX: simplify and fix vmx_vcpu_pi_load

Yunhong Jiang (1):
  kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block

 arch/x86/kvm/vmx.c | 190 ++++++++++++++++++++++++++++-------------------------
 1 file changed, 100 insertions(+), 90 deletions(-)

Comments

Stefan Bader Jan. 21, 2021, 9:18 a.m. UTC | #1
On 19.01.21 00:22, Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908428
> 
> The following patches fix the bug reported in [1].
> The first patch bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block) 
> is pulled into to facilitate the backport of the next 3 patches that fix the bug.
> Original patches come from [2] and have been accepted upstream.
> 
> [1] https://marc.info/?l=kvm&m=149559827906211&w=2
> [2] https://lore.kernel.org/lkml/20170606105707.23207-1-pbonzini@redhat.com/
> 
> Paolo Bonzini (3):
>   KVM: VMX: extract __pi_post_block
>   KVM: VMX: avoid double list add with VT-d posted interrupts
>   KVM: VMX: simplify and fix vmx_vcpu_pi_load
> 
> Yunhong Jiang (1):
>   kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block
> 
>  arch/x86/kvm/vmx.c | 190 ++++++++++++++++++++++++++++-------------------------
>  1 file changed, 100 insertions(+), 90 deletions(-)
> 

Statements about the regression potential in the bug report still apply. What I
mean is that that section should describe what you think would be the symptoms
or areas where regressions would show up. So beside of the verification testing
by people affected, someone could say ok, we were covering this area and had no
issues so this might be ok.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kamal Mostafa Jan. 21, 2021, 5:05 p.m. UTC | #2
LGTM.

Acked-by: Kamal Mostafa <kamal@canonical.com>

 -Kamal

On Mon, Jan 18, 2021 at 11:22:04PM +0000, Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908428
> 
> The following patches fix the bug reported in [1].
> The first patch bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block) 
> is pulled into to facilitate the backport of the next 3 patches that fix the bug.
> Original patches come from [2] and have been accepted upstream.
> 
> [1] https://marc.info/?l=kvm&m=149559827906211&w=2
> [2] https://lore.kernel.org/lkml/20170606105707.23207-1-pbonzini@redhat.com/
> 
> Paolo Bonzini (3):
>   KVM: VMX: extract __pi_post_block
>   KVM: VMX: avoid double list add with VT-d posted interrupts
>   KVM: VMX: simplify and fix vmx_vcpu_pi_load
> 
> Yunhong Jiang (1):
>   kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block
> 
>  arch/x86/kvm/vmx.c | 190 ++++++++++++++++++++++++++++-------------------------
>  1 file changed, 100 insertions(+), 90 deletions(-)
> 
> -- 
> 1.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Kelsey Skunberg Jan. 22, 2021, 4:05 a.m. UTC | #3
Applied to Xenial/master-next. Thank you for fixing this up and
submitting Ioanna. :) 

-Kelsey

On 2021-01-18 23:22:04 , Ioanna Alifieraki wrote:
> BugLink: https://bugs.launchpad.net/bugs/1908428
> 
> The following patches fix the bug reported in [1].
> The first patch bc22512bb24c(kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block) 
> is pulled into to facilitate the backport of the next 3 patches that fix the bug.
> Original patches come from [2] and have been accepted upstream.
> 
> [1] https://marc.info/?l=kvm&m=149559827906211&w=2
> [2] https://lore.kernel.org/lkml/20170606105707.23207-1-pbonzini@redhat.com/
> 
> Paolo Bonzini (3):
>   KVM: VMX: extract __pi_post_block
>   KVM: VMX: avoid double list add with VT-d posted interrupts
>   KVM: VMX: simplify and fix vmx_vcpu_pi_load
> 
> Yunhong Jiang (1):
>   kvm: vmx: rename vmx_pre/post_block to pi_pre/post_block
> 
>  arch/x86/kvm/vmx.c | 190 ++++++++++++++++++++++++++++-------------------------
>  1 file changed, 100 insertions(+), 90 deletions(-)
> 
> -- 
> 1.9.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team