mbox series

[SRU,X/kvm,B/kvm,F/kvm,G/kvm,0/1] Change NET_IPIP and IPV6_SIT to modules

Message ID 20201125082517.20148-1-khalid.elmously@canonical.com
Headers show
Series [SRU,F/kvm,1/1] Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m | expand

Message

Khalid Elmously Nov. 25, 2020, 8:25 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1899832

There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.

The removed modules (sit.ko and ipip.ko) are automatically included in linux-modules as there is no modules-extra package at all.

Khalid Elmously (1):
  Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m

 debian.kvm/config/config.common.ubuntu | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Stefan Bader Nov. 25, 2020, 8:44 a.m. UTC | #1 
On 25.11.20 09:25, Khalid Elmously wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899832
> 
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.
> 
> The removed modules (sit.ko and ipip.ko) are automatically included in linux-modules as there is no modules-extra package at all.
> 
> Khalid Elmously (1):
>   Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
> 
>  debian.kvm/config/config.common.ubuntu | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
With double checking that the modules will be present in the set of modules
installed by default. Maybe should get annotated/enforced...

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Nov. 25, 2020, 9:17 a.m. UTC | #2 
On 25.11.20 09:25, Khalid Elmously wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899832
> 
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.
> 
> The removed modules (sit.ko and ipip.ko) are automatically included in linux-modules as there is no modules-extra package at all.
> 
> Khalid Elmously (1):
>    Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
> 
>   debian.kvm/config/config.common.ubuntu | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 

Makes sense to me.

However, the changes to config files should have something like
"UBUNTU: [config]" as prefix on the subject. This can be fixed when
applying the patches.

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
William Breathitt Gray Nov. 25, 2020, 3:11 p.m. UTC | #3 
On Wed, Nov 25, 2020 at 03:25:13AM -0500, Khalid Elmously wrote:
> BugLink: https://bugs.launchpad.net/bugs/1899832
> 
> There's no good reason for these modules to be statically built-in, and they are causing test validation problems on some clouds.
> 
> The removed modules (sit.ko and ipip.ko) are automatically included in linux-modules as there is no modules-extra package at all.
> 
> Khalid Elmously (1):
>   Set CONFIG_NET_IPIP and CONIG_IPV6_SIT =m
> 
>  debian.kvm/config/config.common.ubuntu | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> -- 
> 2.17.1

Applied with subject adjustments ("Ubuntu [config]") to
Xenial:linux-kvm, Bionic:linux-kvm, Focal:linux-kvm, and
Groovy:linux-kvm.

William Breathitt Gray