From patchwork Tue Nov 24 23:10:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thadeu Lima de Souza Cascardo X-Patchwork-Id: 1405762 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4CgfrN4ZdBz9sRR; Wed, 25 Nov 2020 10:10:28 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1khhS3-0002z4-Ls; Tue, 24 Nov 2020 23:10:23 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1khhS2-0002yy-QN for kernel-team@lists.ubuntu.com; Tue, 24 Nov 2020 23:10:22 +0000 Received: from 1.general.cascardo.uk.vpn ([10.172.198.58] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1khhS2-0002QR-53 for kernel-team@lists.ubuntu.com; Tue, 24 Nov 2020 23:10:22 +0000 From: Thadeu Lima de Souza Cascardo To: kernel-team@lists.ubuntu.com Subject: [SRU Xenial 0/2] LP: #1905475 Fix powerpc build Date: Tue, 24 Nov 2020 20:10:05 -0300 Message-Id: <20201124231007.2309907-1-cascardo@canonical.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" After uaccess flush backport, a powerpc flavor stopped building. This was due to a backport of a file that was not present in 4.4 and was even broken on upstream stable 4.4. We were just a little more broken due to differences in the backport. The potential regression might sound a little scary, but it's due to changes in the area of code that copies data to and from userspace. I managed to at least test that one of the flavors boot on an G4 iBook, though not the one that was failing to build. [Impact] powerpc flavor powerpc64-emb fails to build with kernel 4.4.0-196. [Test case] Build the kernel with all powerpc flavors. [Potential regression] The kernel might still not boot. Userspace data might be corrupted when kernel writes to it. Kernel might not read userspace data correctly and on-disk data would get corrupted. Daniel Axtens (1): powerpc/uaccess-flush: fix corenet64_smp_defconfig build Thadeu Lima de Souza Cascardo (1): UBUNTU: SAUCE: powerpc/uaccess: only include kup-radix.h on PPC_BOOK3S_64 arch/powerpc/include/asm/kup.h | 2 +- arch/powerpc/kernel/ppc_ksyms.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) Acked-by: Kamal Mostafa Acked-by: Ian May