| Message ID | 20201103173129.544371-1-alberto.milone@canonical.com |
|---|---|
| Headers | show |
| Series | Update the NVIDIA 455 driver | expand |
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > More or less agree but the transitional file should be better named migrate-nvidia-435. Reason is that if named transitionals it will be handled incorrectly if your variant does not contain --. Also I would not put dkms-versions into the lrm patch. This is matched anyway to what the kernel tree contains when we crank. -Stefan
On 04/11/2020 15:37, Stefan Bader wrote: > On 03.11.20 18:31, Alberto Milone wrote: >> Update the NVIDIA 455 driver and drop the 435 series. >> >> Also, provide a new virtual package, so that packagers >> can specify a dependency on signed modules (as opposed to >> the DKMS packages). >> >> Each couple of patches covers one flavour: generic, aws, azure, >> gcp, oracle. >> >> This requires updating the debian/dkms-versions to match what is >> in -proposed. >> >> BugLink: https://bugs.launchpad.net/bugs/1902093 >> >> Signed-off-by: Alberto Milone <alberto.milone@canonical.com> >> >> -- >> 2.25.1 >> > More or less agree but the transitional file should be better named > migrate-nvidia-435. Reason is that if named transitionals it will be handled > incorrectly if your variant does not contain --. Also I would not put > dkms-versions into the lrm patch. This is matched anyway to what the kernel tree > contains when we crank. > > -Stefan > Maybe we should revisit the way we handle transitionals, so that it is consistent across all the variants.
On 04.11.20 16:36, Alberto Milone wrote: > > > On 04/11/2020 15:37, Stefan Bader wrote: >> On 03.11.20 18:31, Alberto Milone wrote: >>> Update the NVIDIA 455 driver and drop the 435 series. >>> >>> Also, provide a new virtual package, so that packagers >>> can specify a dependency on signed modules (as opposed to >>> the DKMS packages). >>> >>> Each couple of patches covers one flavour: generic, aws, azure, >>> gcp, oracle. >>> >>> This requires updating the debian/dkms-versions to match what is >>> in -proposed. >>> >>> BugLink: https://bugs.launchpad.net/bugs/1902093 >>> >>> Signed-off-by: Alberto Milone <alberto.milone@canonical.com> >>> >>> -- >>> 2.25.1 >>> >> More or less agree but the transitional file should be better named >> migrate-nvidia-435. Reason is that if named transitionals it will be handled >> incorrectly if your variant does not contain --. Also I would not put >> dkms-versions into the lrm patch. This is matched anyway to what the kernel tree >> contains when we crank. >> >> -Stefan >> > > Maybe we should revisit the way we handle transitionals, so that it is > consistent across all the variants. > I could say as well that maybe we should just name those files differently. If you check previous releases that is mostly done that way...
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > Provided that whoever applies things should rather - strip out the changes to dkms.versions - rename the transitional file Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > > With the fixups mentioned by Stefan: Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > Applied to groovy-lrm/master. Thanks. -Stefan
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > > Applied to groovy/linux-restricted-modules-aws. Thanks, Kleber
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > > The patches for the derivatives are not removing the -435 binary packages (linux-modules-nvidia-435-@ABI@-*) from debian/control.d/nvidia. This also needs to be done manually when applying. Kleber
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > > Applied to groovy/linux-restricted-modules-gcp. Thanks, Kleber
On 03.11.20 18:31, Alberto Milone wrote: > Update the NVIDIA 455 driver and drop the 435 series. > > Also, provide a new virtual package, so that packagers > can specify a dependency on signed modules (as opposed to > the DKMS packages). > > Each couple of patches covers one flavour: generic, aws, azure, > gcp, oracle. > > This requires updating the debian/dkms-versions to match what is > in -proposed. > > BugLink: https://bugs.launchpad.net/bugs/1902093 > > Signed-off-by: Alberto Milone <alberto.milone@canonical.com> > > -- > 2.25.1 > > Applied to groovy/linux-restricted-modules-azure. Thanks, Kleber
Update the NVIDIA 455 driver and drop the 435 series. Also, provide a new virtual package, so that packagers can specify a dependency on signed modules (as opposed to the DKMS packages). Each couple of patches covers one flavour: generic, aws, azure, gcp, oracle. This requires updating the debian/dkms-versions to match what is in -proposed. BugLink: https://bugs.launchpad.net/bugs/1902093 Signed-off-by: Alberto Milone <alberto.milone@canonical.com> -- 2.25.1