mbox series

[0/1,SRU,F/OEM-5.6] drm/i915/dp_mst - System would hang during the boot up

Message ID 20201102054648.18416-1-koba.ko@canonical.com
Headers show
Series drm/i915/dp_mst - System would hang during the boot up | expand

Message

Koba Ko Nov. 2, 2020, 5:46 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1902469

[Impact]
The machine connect with the external monitor on dock(Thunderbolt),
Then system would hang during the boot-up.

[Fix]
The atomic check hooks must look up the encoder to be used with a
connector from the connector's atomic state, and not assume that it's
the connector's current attached encoder. The latter one can change
under the atomic check func, or can be unset yet as in the case of MST
connectors.

[test]
With the patch, The machine connect with the external monitor on dock(Thunderbolt),
Then system boot up successfully.

[Regression Potential]
Low. This patch is also verified by others and is archived in the drmtip.

Imre Deak (1):
  drm/i915: Fix encoder lookup during PSR atomic check

 drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Stefan Bader Nov. 2, 2020, 11:28 a.m. UTC | #1
On 02.11.20 06:46, Koba Ko wrote:
> BugLink: https://bugs.launchpad.net/bugs/1902469
> 
> [Impact]
> The machine connect with the external monitor on dock(Thunderbolt),
> Then system would hang during the boot-up.
> 
> [Fix]
> The atomic check hooks must look up the encoder to be used with a
> connector from the connector's atomic state, and not assume that it's
> the connector's current attached encoder. The latter one can change
> under the atomic check func, or can be unset yet as in the case of MST
> connectors.
> 
> [test]
> With the patch, The machine connect with the external monitor on dock(Thunderbolt),
> Then system boot up successfully.
> 
> [Regression Potential]
> Low. This patch is also verified by others and is archived in the drmtip.
> 
> Imre Deak (1):
>   drm/i915: Fix encoder lookup during PSR atomic check
> 
>  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Is this focal/oem-5.6 only? The bug report points at focal/linux.

-Stefan
Alex Murray Nov. 2, 2020, 11:09 p.m. UTC | #2
On Mon, 2020-11-02 at 21:58:24 +1030, Stefan Bader wrote:

> On 02.11.20 06:46, Koba Ko wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1902469
>> 
>> [Impact]
>> The machine connect with the external monitor on dock(Thunderbolt),
>> Then system would hang during the boot-up.
>> 
>> [Fix]
>> The atomic check hooks must look up the encoder to be used with a
>> connector from the connector's atomic state, and not assume that it's
>> the connector's current attached encoder. The latter one can change
>> under the atomic check func, or can be unset yet as in the case of MST
>> connectors.
>> 
>> [test]
>> With the patch, The machine connect with the external monitor on dock(Thunderbolt),
>> Then system boot up successfully.
>> 
>> [Regression Potential]
>> Low. This patch is also verified by others and is archived in the drmtip.
>> 
>> Imre Deak (1):
>>   drm/i915: Fix encoder lookup during PSR atomic check
>> 
>>  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
> Is this focal/oem-5.6 only? The bug report points at focal/linux.

There are also similar reports for groovy -
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1901215 - and I can
confirm this patch resolves that bug there too - can this patch be
targeted to groovy as well?

>
> -Stefan
Koba Ko Nov. 3, 2020, 2:55 a.m. UTC | #3
On Mon, Nov 2, 2020 at 7:28 PM Stefan Bader <stefan.bader@canonical.com>
wrote:

> On 02.11.20 06:46, Koba Ko wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1902469
> >
> > [Impact]
> > The machine connect with the external monitor on dock(Thunderbolt),
> > Then system would hang during the boot-up.
> >
> > [Fix]
> > The atomic check hooks must look up the encoder to be used with a
> > connector from the connector's atomic state, and not assume that it's
> > the connector's current attached encoder. The latter one can change
> > under the atomic check func, or can be unset yet as in the case of MST
> > connectors.
> >
> > [test]
> > With the patch, The machine connect with the external monitor on
> dock(Thunderbolt),
> > Then system boot up successfully.
> >
> > [Regression Potential]
> > Low. This patch is also verified by others and is archived in the drmtip.
> >
> > Imre Deak (1):
> >   drm/i915: Fix encoder lookup during PSR atomic check
> >
> >  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> Is this focal/oem-5.6 only? The bug report points at focal/linux.
>
> -Stefan
>
> I thought "[F/OEM5.6]" is for Focal-generic and OEM5.6.
If I want to SRU to focal/linux, would you please guide me how to state!?
Koba Ko Nov. 3, 2020, 2:58 a.m. UTC | #4
On Tue, Nov 3, 2020 at 7:09 AM Alex Murray <alex.murray@canonical.com>
wrote:

>
> On Mon, 2020-11-02 at 21:58:24 +1030, Stefan Bader wrote:
>
> > On 02.11.20 06:46, Koba Ko wrote:
> >> BugLink: https://bugs.launchpad.net/bugs/1902469
> >>
> >> [Impact]
> >> The machine connect with the external monitor on dock(Thunderbolt),
> >> Then system would hang during the boot-up.
> >>
> >> [Fix]
> >> The atomic check hooks must look up the encoder to be used with a
> >> connector from the connector's atomic state, and not assume that it's
> >> the connector's current attached encoder. The latter one can change
> >> under the atomic check func, or can be unset yet as in the case of MST
> >> connectors.
> >>
> >> [test]
> >> With the patch, The machine connect with the external monitor on
> dock(Thunderbolt),
> >> Then system boot up successfully.
> >>
> >> [Regression Potential]
> >> Low. This patch is also verified by others and is archived in the
> drmtip.
> >>
> >> Imre Deak (1):
> >>   drm/i915: Fix encoder lookup during PSR atomic check
> >>
> >>  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> > Is this focal/oem-5.6 only? The bug report points at focal/linux.
>
> There are also similar reports for groovy -
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1901215 - and I can
> confirm this patch resolves that bug there too - can this patch be
> targeted to groovy as well?
>
> >
> > -Stefan
>
> Sure, have target to groovy. Should I SRU  again!?
Stefan Bader Nov. 3, 2020, 10:43 a.m. UTC | #5
On 03.11.20 03:55, Koba Ko wrote:
> On Mon, Nov 2, 2020 at 7:28 PM Stefan Bader <stefan.bader@canonical.com
> <mailto:stefan.bader@canonical.com>> wrote:
> 
>     On 02.11.20 06:46, Koba Ko wrote:
>     > BugLink: https://bugs.launchpad.net/bugs/1902469
>     >
>     > [Impact]
>     > The machine connect with the external monitor on dock(Thunderbolt),
>     > Then system would hang during the boot-up.
>     >
>     > [Fix]
>     > The atomic check hooks must look up the encoder to be used with a
>     > connector from the connector's atomic state, and not assume that it's
>     > the connector's current attached encoder. The latter one can change
>     > under the atomic check func, or can be unset yet as in the case of MST
>     > connectors.
>     >
>     > [test]
>     > With the patch, The machine connect with the external monitor on
>     dock(Thunderbolt),
>     > Then system boot up successfully.
>     >
>     > [Regression Potential]
>     > Low. This patch is also verified by others and is archived in the drmtip.
>     >
>     > Imre Deak (1):
>     >   drm/i915: Fix encoder lookup during PSR atomic check
>     >
>     >  drivers/gpu/drm/i915/display/intel_psr.c | 2 +-
>     >  1 file changed, 1 insertion(+), 1 deletion(-)
>     >
>     Is this focal/oem-5.6 only? The bug report points at focal/linux.
> 
>     -Stefan
> 
> I thought "[F/OEM5.6]" is for Focal-generic and OEM5.6.
> If I want to SRU to focal/linux, would you please guide me how to state!?

It is confusing because mostly the form <series>/<kernel> is used to target a
certain kernel in the given series. So in case you want to target both it is
better to say either "focal + focal/[linux-]oem-5.6" or "focal/linux +
[linux-]oem-5.6". And the bug report would affect linux and also linux-oem-5.6.
Both nominated for focal.
Note that, based on the reply of Alex, this seems to be required at least in
groovy/linux, too. And as of now, you probably should check Hirsute/5.10 as well.

With all this, it would be best if you re-submitted that patch with an updated
target(s).

Thanks,
Stefan