mbox series

[F/G,0/1] uvcvideo: add mapping for HEVC payloads

Message ID 20201102035027.1365490-1-jesse.sung@canonical.com
Headers show
Series uvcvideo: add mapping for HEVC payloads | expand

Message

Jesse Sung Nov. 2, 2020, 3:50 a.m. UTC
BugLink: https://launchpad.net/bugs/1895803

This adds mapping for HEVC so that uvcvideo can support the format.

Risk of regression is low since it is a clean cherry-pick and only
adds a new format to the array.

Dmitry Buzdyk (1):
  media: uvcvideo: Add mapping for HEVC payloads

 drivers/media/usb/uvc/uvc_driver.c | 5 +++++
 drivers/media/usb/uvc/uvcvideo.h   | 4 ++++
 2 files changed, 9 insertions(+)

Comments

Stefan Bader Nov. 2, 2020, 11:25 a.m. UTC | #1
On 02.11.20 04:50, Wen-chien Jesse Sung wrote:
> BugLink: https://launchpad.net/bugs/1895803
> 
> This adds mapping for HEVC so that uvcvideo can support the format.

This (as it is the impact on the bug report) is a bit short for explaining
things. Even I have to think hard and guess that this is about USB
(web?)camera(s) failing to give you a certain format recording which they claim
to support.

> 
> Risk of regression is low since it is a clean cherry-pick and only
> adds a new format to the array.

And the regression potential would be that video (recording) issues get reported
with the new format which were not reported before (when they could not be done). ;)

> 
> Dmitry Buzdyk (1):
>   media: uvcvideo: Add mapping for HEVC payloads
> 
>  drivers/media/usb/uvc/uvc_driver.c | 5 +++++
>  drivers/media/usb/uvc/uvcvideo.h   | 4 ++++
>  2 files changed, 9 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Stefan Bader Nov. 2, 2020, 11:26 a.m. UTC | #2
On 02.11.20 12:25, Stefan Bader wrote:
> On 02.11.20 04:50, Wen-chien Jesse Sung wrote:
>> BugLink: https://launchpad.net/bugs/1895803
>>
>> This adds mapping for HEVC so that uvcvideo can support the format.
> 
> This (as it is the impact on the bug report) is a bit short for explaining
> things. Even I have to think hard and guess that this is about USB
> (web?)camera(s) failing to give you a certain format recording which they claim
> to support.
> 
>>
>> Risk of regression is low since it is a clean cherry-pick and only
>> adds a new format to the array.
> 
> And the regression potential would be that video (recording) issues get reported
> with the new format which were not reported before (when they could not be done). ;)
> 
>>
>> Dmitry Buzdyk (1):
>>   media: uvcvideo: Add mapping for HEVC payloads
>>
>>  drivers/media/usb/uvc/uvc_driver.c | 5 +++++
>>  drivers/media/usb/uvc/uvcvideo.h   | 4 ++++
>>  2 files changed, 9 insertions(+)
>>
> Acked-by: Stefan Bader <stefan.bader@canonical.com>
> 
Oh and forgot to add: what about 5.10 (hirsute)?

-Stefan
Jesse Sung Nov. 3, 2020, 5:27 a.m. UTC | #3
On Mon, Nov 2, 2020 at 7:26 PM Stefan Bader <stefan.bader@canonical.com> wrote:
>
> On 02.11.20 12:25, Stefan Bader wrote:
> > On 02.11.20 04:50, Wen-chien Jesse Sung wrote:
> >> BugLink: https://launchpad.net/bugs/1895803
> >>
> >> This adds mapping for HEVC so that uvcvideo can support the format.
> >
> > This (as it is the impact on the bug report) is a bit short for explaining
> > things. Even I have to think hard and guess that this is about USB
> > (web?)camera(s) failing to give you a certain format recording which they claim
> > to support.
> >
> >>
> >> Risk of regression is low since it is a clean cherry-pick and only
> >> adds a new format to the array.
> >
> > And the regression potential would be that video (recording) issues get reported
> > with the new format which were not reported before (when they could not be done). ;)
> >
> >>
> >> Dmitry Buzdyk (1):
> >>   media: uvcvideo: Add mapping for HEVC payloads
> >>
> >>  drivers/media/usb/uvc/uvc_driver.c | 5 +++++
> >>  drivers/media/usb/uvc/uvcvideo.h   | 4 ++++
> >>  2 files changed, 9 insertions(+)
> >>
> > Acked-by: Stefan Bader <stefan.bader@canonical.com>
> >
> Oh and forgot to add: what about 5.10 (hirsute)?

This commit was cherry-picked from 5.10-rc1 so it will be in Hirsute.

Thanks,
Jesse

>
> -Stefan
>
>