mbox series

[SRU,X,B,F,G,0/1] Don't NULL tty->driver_data until hvcs_cleanup() (LP: 1892546)

Message ID 20200915185649.24706-1-patricia.domingues@canonical.com
Headers show
Series Don't NULL tty->driver_data until hvcs_cleanup() (LP: 1892546) | expand

Message

patricia.domingues@canonical.com Sept. 15, 2020, 6:56 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1892546

SRU Justification:

[Impact]
* drmgr command is failing while trying to open console for IBMi on PowerVM LPAR

[Fix]
* 63ffcbdad738 "tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()"

[Test Case]
* Create a VM from PowerVC on a Novalink managed host. 
* Unmanage and manage the VM, this problem gets reproduced.
* grep the logs for "drmgr"


[Regression Potential]
The regression can be considered as very low, since:
* limited to the IBM Hypervisor Virtual Console Server.
* patched kernel where shared and successfully tested by IBM.
* the worse case, if the cleanup is broken a new opened connection might break.

[Other]
* The patch got upstream accepted.


Tyrel Datwyler (1):
  tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()

 drivers/tty/hvc/hvcs.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

Comments

Paolo Pisati Sept. 17, 2020, 10:27 a.m. UTC | #1 
On Tue, Sep 15, 2020 at 03:56:48PM -0300, patricia.domingues@canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1892546

Acked-by: Paolo Pisati <paolo.pisati@canonical.com>
Kelsey Skunberg Sept. 18, 2020, 1:36 a.m. UTC | #2 
Applied to master-next for xenial, bionic, and focal. thank you! 

-Kelsey

On 2020-09-15 15:56:48 , patricia.domingues@canonical.com wrote:
> BugLink: https://bugs.launchpad.net/bugs/1892546
> 
> SRU Justification:
> 
> [Impact]
> * drmgr command is failing while trying to open console for IBMi on PowerVM LPAR
> 
> [Fix]
> * 63ffcbdad738 "tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()"
> 
> [Test Case]
> * Create a VM from PowerVC on a Novalink managed host. 
> * Unmanage and manage the VM, this problem gets reproduced.
> * grep the logs for "drmgr"
> 
> 
> [Regression Potential]
> The regression can be considered as very low, since:
> * limited to the IBM Hypervisor Virtual Console Server.
> * patched kernel where shared and successfully tested by IBM.
> * the worse case, if the cleanup is broken a new opened connection might break.
> 
> [Other]
> * The patch got upstream accepted.
> 
> 
> Tyrel Datwyler (1):
>   tty: hvcs: Don't NULL tty->driver_data until hvcs_cleanup()
> 
>  drivers/tty/hvc/hvcs.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team