From patchwork Thu Sep 10 05:27:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hsuan-Yu Lin X-Patchwork-Id: 1361219 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 4Bn6pw3zmCz9sTg; Thu, 10 Sep 2020 15:27:51 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1kGF7X-0000MQ-VF; Thu, 10 Sep 2020 05:27:43 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kGF7V-0000ME-Vy for kernel-team@lists.ubuntu.com; Thu, 10 Sep 2020 05:27:41 +0000 Received: from mail-pj1-f69.google.com ([209.85.216.69]) by youngberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kGF7V-0002OH-Jq for kernel-team@lists.ubuntu.com; Thu, 10 Sep 2020 05:27:41 +0000 Received: by mail-pj1-f69.google.com with SMTP id z22so2990309pjr.8 for ; Wed, 09 Sep 2020 22:27:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=+Dpwv4HKGCgxGZOLh0rK8vhm9lU8Js9SBKUp+a1t21Y=; b=bH7uIxpsQfsQ3R407Qf8TpBgzRUwh2Yc/hpBVqrZPl0kywKHT5H3c1z3ioJRGd9ZOP bb4pLDmYjkH/XV+jb27mJ2HTV5gVlPjifYCnT3ZahtpEkhdGASuAMtcHYpMsVgI4jiXB jaCcBlihIfW0JujVnrmehxM8DeudIcRpoLBXy6WnXXUl2lL0ImDFEDF5SPPb/KPkyZpX 5UBAtGhh3nJm4sS+Kr75BAQYx3iVlom6JISXR/r3khBZpunUf4J8akDKLx+DHeXUnfUN WMqUiuCTniaAE8JDa0C/eHpHnofZZamxYmzowdJwOwzHcGTuw9jOlOGjWUV0IlUUSpT8 eykQ== X-Gm-Message-State: AOAM532N78vS0MFrlPzCxuQYor84e7a/Gr22iCE1oNf2rEqOEIFoecbH 1w6/aFt/SbLOqGfcCXpoJcqCAEnViyVgpmdm5U4JH/uI06bpA/R99IlmvyyCHZFtvjslJv2AX2G k5eMAeBE+0RcsfdWLWXFmnd7v3pbd7SRar3TqgN7pSA== X-Received: by 2002:a17:90a:7481:: with SMTP id p1mr3703364pjk.33.1599715659892; Wed, 09 Sep 2020 22:27:39 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwZ6bFMvyc6ftz5dtokb3TvVcJXmd44WLJFNpW5adAT1rZNcapVd968pHMCMQbtiqkgf7AxIA== X-Received: by 2002:a17:90a:7481:: with SMTP id p1mr3703340pjk.33.1599715659464; Wed, 09 Sep 2020 22:27:39 -0700 (PDT) Received: from dell.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id y5sm4024569pge.62.2020.09.09.22.27.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Sep 2020 22:27:39 -0700 (PDT) From: Hsuan-Yu Lin To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/2][SRU][G] Support WD19TB external output on TGL platform Date: Thu, 10 Sep 2020 13:27:34 +0800 Message-Id: <20200910052736.314874-1-shane.lin@canonical.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1886165 [Impact] TGL platform can't output external monitor on WD19TB docking. There's no screen on the external monitor. error in dmesg: [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe B FIFO underru [Fix] According to Intel's suggestion, we need this: https://patchwork.freedesktop.org/series/78909/ The following patches are landed in 5.9-rc1 and necessary for support TGL platform: * commit 09eac8277262 ("drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock") * commit f153478de4b2 ("drm/i915/tgl+: Use the correct DP_TP_* register instances in MST encoders") [Test] The WD19TB can output HDMI/DP to external monitor. [Regression Potential] Low, it's the fixes for TGL platform, doesn't affect other platforms. Imre Deak (2): drm/i915/tgl+: Use the correct DP_TP_* register instances in MST encoders drm/i915/tgl+: Fix TBT DPLL fractional divider for 38.4MHz ref clock drivers/gpu/drm/i915/display/intel_ddi.c | 15 ++++++++++----- drivers/gpu/drm/i915/display/intel_dpll_mgr.c | 13 ++++++++++++- 2 files changed, 22 insertions(+), 6 deletions(-) Acked-by: Paolo Pisati