mbox series

[0/1,SRU,Focal/OEM-5.6/Groovy] Fix AMD usb host controller lost after stress S3

Message ID 20200903063503.153721-1-aaron.ma@canonical.com
Headers show
Series [1/1,GROOVY] UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC | expand

Message

Aaron Ma Sept. 3, 2020, 6:35 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1893914

[Impact]
When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
The controller indicates "internal Host Controller Error"

[Fix]
To fix this, sparse controller enable bit has to be disabled.

[Test Case]
Verified on the target platform, OK for 100 times of S3.

[Regression Potential]
Low,
Add specific ID quirk for hw, no other hw related, tested with positive
results.
Backported is due to minimal context difference on Focal/OEM-5.6
kernels.

Nehal Bakulchandra Shah (1):
  UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC

 drivers/usb/host/xhci-pci.c | 12 ++++++++++++
 drivers/usb/host/xhci.h     |  1 +
 2 files changed, 13 insertions(+)

Comments

Stefan Bader Sept. 3, 2020, 9:12 a.m. UTC | #1 
On 03.09.20 08:35, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1893914
> 
> [Impact]
> When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
> The controller indicates "internal Host Controller Error"
> 
> [Fix]
> To fix this, sparse controller enable bit has to be disabled.
> 
> [Test Case]
> Verified on the target platform, OK for 100 times of S3.
> 
> [Regression Potential]
> Low,
> Add specific ID quirk for hw, no other hw related, tested with positive
> results.
> Backported is due to minimal context difference on Focal/OEM-5.6
> kernels.
> 
> Nehal Bakulchandra Shah (1):
>   UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC
> 
>  drivers/usb/host/xhci-pci.c | 12 ++++++++++++
>  drivers/usb/host/xhci.h     |  1 +
>  2 files changed, 13 insertions(+)
> 
I won't be looking until the bug report has at least status set sensible for the
tasks.

-Stefan
Aaron Ma Sept. 3, 2020, 9:17 a.m. UTC | #2 
On 9/3/20 5:12 PM, Stefan Bader wrote:
> I won't be looking until the bug report has at least status set sensible for the
> tasks.

Set the bug status to "In Progress".

Thanks,
Aaron
Stefan Bader Sept. 3, 2020, 9:22 a.m. UTC | #3 
On 03.09.20 08:35, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1893914
> 
> [Impact]
> When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
> The controller indicates "internal Host Controller Error"
> 
> [Fix]
> To fix this, sparse controller enable bit has to be disabled.
> 
> [Test Case]
> Verified on the target platform, OK for 100 times of S3.
> 
> [Regression Potential]
> Low,
> Add specific ID quirk for hw, no other hw related, tested with positive
> results.
> Backported is due to minimal context difference on Focal/OEM-5.6
> kernels.
> 
> Nehal Bakulchandra Shah (1):
>   UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC
> 
>  drivers/usb/host/xhci-pci.c | 12 ++++++++++++
>  drivers/usb/host/xhci.h     |  1 +
>  2 files changed, 13 insertions(+)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Sacilotto de Souza Sept. 3, 2020, 12:17 p.m. UTC | #4 
On 03.09.20 08:35, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1893914
> 
> [Impact]
> When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
> The controller indicates "internal Host Controller Error"
> 
> [Fix]
> To fix this, sparse controller enable bit has to be disabled.
> 
> [Test Case]
> Verified on the target platform, OK for 100 times of S3.
> 
> [Regression Potential]
> Low,
> Add specific ID quirk for hw, no other hw related, tested with positive
> results.
> Backported is due to minimal context difference on Focal/OEM-5.6
> kernels.
> 
> Nehal Bakulchandra Shah (1):
>   UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC
> 
>  drivers/usb/host/xhci-pci.c | 12 ++++++++++++
>  drivers/usb/host/xhci.h     |  1 +
>  2 files changed, 13 insertions(+)
> 

Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Timo Aaltonen Sept. 3, 2020, 12:18 p.m. UTC | #5 
On 3.9.2020 9.35, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1893914
> 
> [Impact]
> When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
> The controller indicates "internal Host Controller Error"
> 
> [Fix]
> To fix this, sparse controller enable bit has to be disabled.
> 
> [Test Case]
> Verified on the target platform, OK for 100 times of S3.
> 
> [Regression Potential]
> Low,
> Add specific ID quirk for hw, no other hw related, tested with positive
> results.
> Backported is due to minimal context difference on Focal/OEM-5.6
> kernels.
> 
> Nehal Bakulchandra Shah (1):
>   UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC
> 
>  drivers/usb/host/xhci-pci.c | 12 ++++++++++++
>  drivers/usb/host/xhci.h     |  1 +
>  2 files changed, 13 insertions(+)
> 

applied to oem-5.6, thanks
William Breathitt Gray Sept. 17, 2020, 1:29 p.m. UTC | #6 
On Thu, Sep 03, 2020 at 02:35:01PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1893914
> 
> [Impact]
> When stress S3 on AMD 0x15e5 usb host controller, it failed to resume.
> The controller indicates "internal Host Controller Error"
> 
> [Fix]
> To fix this, sparse controller enable bit has to be disabled.
> 
> [Test Case]
> Verified on the target platform, OK for 100 times of S3.
> 
> [Regression Potential]
> Low,
> Add specific ID quirk for hw, no other hw related, tested with positive
> results.
> Backported is due to minimal context difference on Focal/OEM-5.6
> kernels.
> 
> Nehal Bakulchandra Shah (1):
>   UBUNTU: SAUCE: xhci: workaround for S3 issue on AMD SNPS 3.0 xHC
> 
>  drivers/usb/host/xhci-pci.c | 12 ++++++++++++
>  drivers/usb/host/xhci.h     |  1 +
>  2 files changed, 13 insertions(+)
> 
> -- 
> 2.25.1

Applied to Focal.

William Breathitt Gray