mbox series

[SRU,Unstable/OEM-5.6,0/1] Fix non-working USB devices plugged during system sleep

Message ID 20200824063623.7581-1-kai.heng.feng@canonical.com
Headers show
Series Fix non-working USB devices plugged during system sleep | expand

Message

Kai-Heng Feng Aug. 24, 2020, 6:36 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1892678

[Impact]
Some USB devices aren't working if they are plugged under system sleep.

[Fix]
Consider xHCI PORTSC CAS bit over other conditions.

[Test]
Plug or re-plug USB devices during system sleep. USB devices always work
after system resume.

[Regression Potential]
There could be devices that depends on the old (but wrong) behavior.
However it's really unlikely and it's against xHCI spec, we can deal
with those quirky devices if any.

Kai-Heng Feng (1):
  xhci: Do warm-reset when both CAS and XDEV_RESUME are set

 drivers/usb/host/xhci-hub.c | 19 ++++++++++---------
 1 file changed, 10 insertions(+), 9 deletions(-)

Comments

Timo Aaltonen Aug. 24, 2020, 8:09 a.m. UTC | #1 
On 24.8.2020 9.36, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1892678
> 
> [Impact]
> Some USB devices aren't working if they are plugged under system sleep.
> 
> [Fix]
> Consider xHCI PORTSC CAS bit over other conditions.
> 
> [Test]
> Plug or re-plug USB devices during system sleep. USB devices always work
> after system resume.
> 
> [Regression Potential]
> There could be devices that depends on the old (but wrong) behavior.
> However it's really unlikely and it's against xHCI spec, we can deal
> with those quirky devices if any.
> 
> Kai-Heng Feng (1):
>   xhci: Do warm-reset when both CAS and XDEV_RESUME are set
> 
>  drivers/usb/host/xhci-hub.c | 19 ++++++++++---------
>  1 file changed, 10 insertions(+), 9 deletions(-)
> 

applied to oem-5.6, thanks
Seth Forshee Aug. 25, 2020, 8:16 p.m. UTC | #2 
On Mon, Aug 24, 2020 at 02:36:22PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1892678
> 
> [Impact]
> Some USB devices aren't working if they are plugged under system sleep.
> 
> [Fix]
> Consider xHCI PORTSC CAS bit over other conditions.
> 
> [Test]
> Plug or re-plug USB devices during system sleep. USB devices always work
> after system resume.
> 
> [Regression Potential]
> There could be devices that depends on the old (but wrong) behavior.
> However it's really unlikely and it's against xHCI spec, we can deal
> with those quirky devices if any.

Applied to groovy/master-next, thanks!