mbox series

[SRU,Unstable/OEM-5.6,0/1] Fix non-working Goodix touchpad after system sleep

Message ID 20200818084309.7114-1-kai.heng.feng@canonical.com
Headers show
Series Fix non-working Goodix touchpad after system sleep | expand

Message

Kai-Heng Feng Aug. 18, 2020, 8:43 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1891998

[Impact]
After system sleep, Goodix touchpad doesn't work anymore.

[Fix]
Add a delay after issuing SET_POWER_ON command.

[Test]
With the patch applied, Goodix touchpad still works after system sleep.

[Regression Potential]
The original delay between SET_POWER_ON and RESET was increaed to 60ms,
so the the driver becomes much more forgiving on power management. Hence
I am not seeing any major potential regression risk here.

Hans de Goede (1):
  HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands

 drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++++---------
 1 file changed, 13 insertions(+), 9 deletions(-)

Comments

Seth Forshee Aug. 19, 2020, 8:56 p.m. UTC | #1 
On Tue, Aug 18, 2020 at 04:43:08PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891998
> 
> [Impact]
> After system sleep, Goodix touchpad doesn't work anymore.
> 
> [Fix]
> Add a delay after issuing SET_POWER_ON command.
> 
> [Test]
> With the patch applied, Goodix touchpad still works after system sleep.
> 
> [Regression Potential]
> The original delay between SET_POWER_ON and RESET was increaed to 60ms,
> so the the driver becomes much more forgiving on power management. Hence
> I am not seeing any major potential regression risk here.

Applied to groovy/master-next, thanks!
Timo Aaltonen Aug. 21, 2020, 7:32 a.m. UTC | #2 
On 18.8.2020 11.43, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1891998
> 
> [Impact]
> After system sleep, Goodix touchpad doesn't work anymore.
> 
> [Fix]
> Add a delay after issuing SET_POWER_ON command.
> 
> [Test]
> With the patch applied, Goodix touchpad still works after system sleep.
> 
> [Regression Potential]
> The original delay between SET_POWER_ON and RESET was increaed to 60ms,
> so the the driver becomes much more forgiving on power management. Hence
> I am not seeing any major potential regression risk here.
> 
> Hans de Goede (1):
>   HID: i2c-hid: Always sleep 60ms after I2C_HID_PWR_ON commands
> 
>  drivers/hid/i2c-hid/i2c-hid-core.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 

applied to oem-5.6, thanks