mbox series

[0/1,GROOVY] ftrace: Fix ftrace_trace_task return value

Message ID 20200813165229.43105-1-colin.king@canonical.com
Headers show
Series ftrace: Fix ftrace_trace_task return value | expand

Message

Colin Ian King Aug. 13, 2020, 4:52 p.m. UTC
From: Colin Ian King <colin.king@canonical.com>

BugLink: https://bugs.launchpad.net/bugs/1891528

A couple of ftrace kernel self test regression tests are failing on
systems with 1 CPU, notably small 1 CPU cloud instances. The two
tests that are failing are:

[20] ftrace - function graph filters with stack tracer
[21] ftrace - function graph filters

Bisected this down to commit 717e3f5ebc82 ("ftrace: Make function 
trace pid filtering a bit more exact") in linux 5.6-rc4 and found
and tested an upstream fix to this issue with the commit
c58b6b0372de ("ftrace: Fix ftrace_trace_task return value").

Josef Bacik (1):
  ftrace: Fix ftrace_trace_task return value

 kernel/trace/ftrace.c | 3 ---
 kernel/trace/trace.h  | 7 ++++++-
 2 files changed, 6 insertions(+), 4 deletions(-)

Comments

Thadeu Lima de Souza Cascardo Aug. 13, 2020, 5:07 p.m. UTC | #1
On Thu, Aug 13, 2020 at 05:52:28PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1891528
> 
> A couple of ftrace kernel self test regression tests are failing on
> systems with 1 CPU, notably small 1 CPU cloud instances. The two
> tests that are failing are:
> 
> [20] ftrace - function graph filters with stack tracer
> [21] ftrace - function graph filters
> 
> Bisected this down to commit 717e3f5ebc82 ("ftrace: Make function 
> trace pid filtering a bit more exact") in linux 5.6-rc4 and found
> and tested an upstream fix to this issue with the commit
> c58b6b0372de ("ftrace: Fix ftrace_trace_task return value").
> 
> Josef Bacik (1):
>   ftrace: Fix ftrace_trace_task return value
> 
>  kernel/trace/ftrace.c | 3 ---
>  kernel/trace/trace.h  | 7 ++++++-
>  2 files changed, 6 insertions(+), 4 deletions(-)
> 
> -- 
> 2.27.0

Acked-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
Seth Forshee Aug. 14, 2020, 8 p.m. UTC | #2
On Thu, Aug 13, 2020 at 05:52:28PM +0100, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> BugLink: https://bugs.launchpad.net/bugs/1891528
> 
> A couple of ftrace kernel self test regression tests are failing on
> systems with 1 CPU, notably small 1 CPU cloud instances. The two
> tests that are failing are:
> 
> [20] ftrace - function graph filters with stack tracer
> [21] ftrace - function graph filters
> 
> Bisected this down to commit 717e3f5ebc82 ("ftrace: Make function 
> trace pid filtering a bit more exact") in linux 5.6-rc4 and found
> and tested an upstream fix to this issue with the commit
> c58b6b0372de ("ftrace: Fix ftrace_trace_task return value").

Applied to groovy/master-next, thanks!