mbox series

[SRU,E/F/OEM-B/OEM-OSP1-B,0/2] Support Headset Mic on HP cPC

Message ID 20200207083739.12325-1-kai.heng.feng@canonical.com
Headers show
Series Support Headset Mic on HP cPC | expand

Message

Kai-Heng Feng Feb. 7, 2020, 8:37 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1862313

[Impact]
Two HP workstations can't detect headset microphone.

[Fix]
Apply vendor-specific coefficient to enable headset mic detection.

[Test]
Plug headset and see if the mic gets detected.
Headset mic gets detected correctly after applying the patch.

[Regression Potential]
Low. The fix matches to very specific machines, so all other systems are
unaffected.

Kailang Yang (2):
  ALSA: hda/realtek - Add Headset Mic supported for HP cPC
  ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
    supported

 sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

Comments

Kleber Souza Feb. 7, 2020, 5:27 p.m. UTC | #1
On 2020-02-07 05:37, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.
> 
> Kailang Yang (2):
>   ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>   ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>     supported
> 
>  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 

Hi Kai-Heng,

The bug report nomination for the 'linux' package has the
Eoan series marked as 'Won't fix'. Could you please clarify
whether these patches need to be considered for Eoan?


Thanks,
Kleber
Kai-Heng Feng Feb. 7, 2020, 5:42 p.m. UTC | #2
> On Feb 8, 2020, at 01:27, Kleber Souza <kleber.souza@canonical.com> wrote:
> 
> On 2020-02-07 05:37, Kai-Heng Feng wrote:
>> BugLink: https://bugs.launchpad.net/bugs/1862313
>> 
>> [Impact]
>> Two HP workstations can't detect headset microphone.
>> 
>> [Fix]
>> Apply vendor-specific coefficient to enable headset mic detection.
>> 
>> [Test]
>> Plug headset and see if the mic gets detected.
>> Headset mic gets detected correctly after applying the patch.
>> 
>> [Regression Potential]
>> Low. The fix matches to very specific machines, so all other systems are
>> unaffected.
>> 
>> Kailang Yang (2):
>>  ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>>  ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>>    supported
>> 
>> sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>> 1 file changed, 45 insertions(+)
>> 
> 
> Hi Kai-Heng,
> 
> The bug report nomination for the 'linux' package has the
> Eoan series marked as 'Won't fix'. Could you please clarify
> whether these patches need to be considered for Eoan?

Yes, Eoan also needs this fix.
Updated the launchpad series to "confirmed".

Kai-Heng

> 
> 
> Thanks,
> Kleber
Kleber Souza Feb. 7, 2020, 8:12 p.m. UTC | #3
On 2020-02-07 05:37, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.
> 
> Kailang Yang (2):
>   ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>   ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>     supported
> 
>  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 


Hardware specific fix-ups.


Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
Sultan Alsawaf Feb. 11, 2020, 1:01 a.m. UTC | #4
On Fri, Feb 07, 2020 at 04:37:36PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.
> 
> Kailang Yang (2):
>   ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>   ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>     supported
> 
>  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team

Acked-by: Sultan Alsawaf <sultan.alsawaf@canonical.com>
Khaled Elmously Feb. 14, 2020, 5:03 a.m. UTC | #5
On 2020-02-07 16:37:36 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.
> 
> Kailang Yang (2):
>   ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>   ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>     supported
> 
>  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Seth Forshee Feb. 19, 2020, 7:27 p.m. UTC | #6
On Fri, Feb 07, 2020 at 04:37:36PM +0800, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.

Applied to focal/master-next, thanks!
Timo Aaltonen Feb. 21, 2020, 12:20 p.m. UTC | #7
On 7.2.2020 10.37, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1862313
> 
> [Impact]
> Two HP workstations can't detect headset microphone.
> 
> [Fix]
> Apply vendor-specific coefficient to enable headset mic detection.
> 
> [Test]
> Plug headset and see if the mic gets detected.
> Headset mic gets detected correctly after applying the patch.
> 
> [Regression Potential]
> Low. The fix matches to very specific machines, so all other systems are
> unaffected.
> 
> Kailang Yang (2):
>   ALSA: hda/realtek - Add Headset Mic supported for HP cPC
>   ALSA: hda/realtek - Fixed one of HP ALC671 platform Headset Mic
>     supported
> 
>  sound/pci/hda/patch_realtek.c | 45 +++++++++++++++++++++++++++++++++++
>  1 file changed, 45 insertions(+)
> 

applied to osp1 oem-next, thanks