mbox series

[0/3,SRU,B/OEM-B,0/1] Fix touchpad not working

Message ID 20191204045946.29214-1-aaron.ma@canonical.com
Headers show
Series Fix touchpad not working | expand

Message

Aaron Ma Dec. 4, 2019, 4:59 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1854798

[Impact]
Synaptics s3203 touchpad not working after update to kernel
4.15.0-72-generic

[Fix]
After applied commit "Input: synaptics-rmi4 - avoid processing unknown
IRQs",
no irq response from touchpad.
This commit is depended on commit:
"Input: synaptics-rmi4 - convert irq distribution to irq_domain"

[Test]
Verified on hardware, tests results are good.

[Regression Potential]
Low.
Fix bug that introduced by stable release update.

2nd and 3rd patches are fixes for the 1st patch.
These commits are already included by eoan kernel, so bionic 4.15 only.

Andrew Duggan (1):
  Input: synaptics-rmi4 - disable the relative position IRQ in the F12
    driver

Nick Dyer (1):
  Input: synaptics-rmi4 - convert irq distribution to irq_domain

Wei Yongjun (1):
  Input: synaptics-rmi4 - fix the error return code in
    rmi_probe_interrupts()

 drivers/input/rmi4/Kconfig      |  1 +
 drivers/input/rmi4/rmi_bus.c    | 50 ++++++++++++++++++++++++++++++-
 drivers/input/rmi4/rmi_bus.h    | 10 ++++++-
 drivers/input/rmi4/rmi_driver.c | 52 +++++++++++++--------------------
 drivers/input/rmi4/rmi_f01.c    | 10 +++----
 drivers/input/rmi4/rmi_f03.c    |  9 +++---
 drivers/input/rmi4/rmi_f11.c    | 42 ++++++++++----------------
 drivers/input/rmi4/rmi_f12.c    | 36 +++++++++++++++++++----
 drivers/input/rmi4/rmi_f30.c    |  9 +++---
 drivers/input/rmi4/rmi_f34.c    |  5 ++--
 drivers/input/rmi4/rmi_f54.c    |  6 ----
 include/linux/rmi.h             |  2 ++
 12 files changed, 145 insertions(+), 87 deletions(-)

Comments

Kleber Souza Dec. 10, 2019, 2:46 p.m. UTC | #1
On 2019-12-04 05:59, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1854798
> 
> [Impact]
> Synaptics s3203 touchpad not working after update to kernel
> 4.15.0-72-generic
> 
> [Fix]
> After applied commit "Input: synaptics-rmi4 - avoid processing unknown
> IRQs",
> no irq response from touchpad.
> This commit is depended on commit:
> "Input: synaptics-rmi4 - convert irq distribution to irq_domain"
> 
> [Test]
> Verified on hardware, tests results are good.
> 
> [Regression Potential]
> Low.
> Fix bug that introduced by stable release update.
> 
> 2nd and 3rd patches are fixes for the 1st patch.
> These commits are already included by eoan kernel, so bionic 4.15 only.

As discussed on IRC, these patches might be no needed, as the commit
that introduced the issue ("Input: synaptics-rmi4 - avoid processing unknown
IRQs") was reverted in v4.14.155 and picked up by 4.15.0-73. However,
I will not NAK it for now until we have a plan on how to fix this issue.


Thanks,
Kleber

> 
> Andrew Duggan (1):
>   Input: synaptics-rmi4 - disable the relative position IRQ in the F12
>     driver
> 
> Nick Dyer (1):
>   Input: synaptics-rmi4 - convert irq distribution to irq_domain
> 
> Wei Yongjun (1):
>   Input: synaptics-rmi4 - fix the error return code in
>     rmi_probe_interrupts()
> 
>  drivers/input/rmi4/Kconfig      |  1 +
>  drivers/input/rmi4/rmi_bus.c    | 50 ++++++++++++++++++++++++++++++-
>  drivers/input/rmi4/rmi_bus.h    | 10 ++++++-
>  drivers/input/rmi4/rmi_driver.c | 52 +++++++++++++--------------------
>  drivers/input/rmi4/rmi_f01.c    | 10 +++----
>  drivers/input/rmi4/rmi_f03.c    |  9 +++---
>  drivers/input/rmi4/rmi_f11.c    | 42 ++++++++++----------------
>  drivers/input/rmi4/rmi_f12.c    | 36 +++++++++++++++++++----
>  drivers/input/rmi4/rmi_f30.c    |  9 +++---
>  drivers/input/rmi4/rmi_f34.c    |  5 ++--
>  drivers/input/rmi4/rmi_f54.c    |  6 ----
>  include/linux/rmi.h             |  2 ++
>  12 files changed, 145 insertions(+), 87 deletions(-)
>
Kleber Souza Jan. 6, 2020, 3:34 p.m. UTC | #2
On 2019-12-04 05:59, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1854798
> 
> [Impact]
> Synaptics s3203 touchpad not working after update to kernel
> 4.15.0-72-generic
> 
> [Fix]
> After applied commit "Input: synaptics-rmi4 - avoid processing unknown
> IRQs",
> no irq response from touchpad.
> This commit is depended on commit:
> "Input: synaptics-rmi4 - convert irq distribution to irq_domain"
> 
> [Test]
> Verified on hardware, tests results are good.
> 
> [Regression Potential]
> Low.
> Fix bug that introduced by stable release update.
> 
> 2nd and 3rd patches are fixes for the 1st patch.
> These commits are already included by eoan kernel, so bionic 4.15 only.
> 
> Andrew Duggan (1):
>   Input: synaptics-rmi4 - disable the relative position IRQ in the F12
>     driver
> 
> Nick Dyer (1):
>   Input: synaptics-rmi4 - convert irq distribution to irq_domain
> 
> Wei Yongjun (1):
>   Input: synaptics-rmi4 - fix the error return code in
>     rmi_probe_interrupts()
> 
>  drivers/input/rmi4/Kconfig      |  1 +
>  drivers/input/rmi4/rmi_bus.c    | 50 ++++++++++++++++++++++++++++++-
>  drivers/input/rmi4/rmi_bus.h    | 10 ++++++-
>  drivers/input/rmi4/rmi_driver.c | 52 +++++++++++++--------------------
>  drivers/input/rmi4/rmi_f01.c    | 10 +++----
>  drivers/input/rmi4/rmi_f03.c    |  9 +++---
>  drivers/input/rmi4/rmi_f11.c    | 42 ++++++++++----------------
>  drivers/input/rmi4/rmi_f12.c    | 36 +++++++++++++++++++----
>  drivers/input/rmi4/rmi_f30.c    |  9 +++---
>  drivers/input/rmi4/rmi_f34.c    |  5 ++--
>  drivers/input/rmi4/rmi_f54.c    |  6 ----
>  include/linux/rmi.h             |  2 ++
>  12 files changed, 145 insertions(+), 87 deletions(-)
> 

As discussed offline, these patches are not needed.

Thanks,
Kleber