mbox series

[v2,0/5,SRU,B/OEM-B/OEM-OSP1/D] Enable new Elan touchpads which are not in current whitelist

Message ID 20191121064013.28740-1-aaron.ma@canonical.com
Headers show
Series Enable new Elan touchpads which are not in current whitelist | expand

Message

Aaron Ma Nov. 21, 2019, 6:40 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1853246

[Impact]
New touchpads are ignored by hid driver because of IDs are missed in the
whitelist.

[Fix]
Only 2 Elan touchpad IDs are allowed to be loaded in hid driver.
Change to the blacklist of elan touchpads supported by elan_i2c, so
others can be enabled by hid.

[Test]
Verified on hardware. Tests results are good.

[Regression Potential]
Low.
keep current IDs of elan_i2c, loads those touchpads ID those weren't
supported.

Those patches are already in 5.3+ kernel,
only bionic and disco kernel need them.

backports are due to the filename and minor content changes.

v2 changes:
Since commit 0c043d70d04 which is included by 5.3 is already
in bionic and disco kernel, so backport this commit change
in filename changes.


Jeffrey Hugo (3):
  HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630
  Input: elan_i2c - export the device id whitelist
  HID: quirks: Refactor ELAN 400 and 401 handling

 drivers/hid/hid-core.c              | 19 +++++---
 drivers/input/mouse/elan_i2c_core.c | 50 +------------------
 include/linux/input/elan-i2c-ids.h  | 76 +++++++++++++++++++++++++++++
 3 files changed, 88 insertions(+), 57 deletions(-)
 create mode 100644 include/linux/input/elan-i2c-ids.h

Comments

You-Sheng Yang Nov. 21, 2019, 7:07 a.m. UTC | #1
Acked-By: You-Sheng Yang <vicamo.yang@canonical.com>

On 2019-11-21 14:40, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1853246
> 
> [Impact]
> New touchpads are ignored by hid driver because of IDs are missed in the
> whitelist.
> 
> [Fix]
> Only 2 Elan touchpad IDs are allowed to be loaded in hid driver.
> Change to the blacklist of elan touchpads supported by elan_i2c, so
> others can be enabled by hid.
> 
> [Test]
> Verified on hardware. Tests results are good.
> 
> [Regression Potential]
> Low.
> keep current IDs of elan_i2c, loads those touchpads ID those weren't
> supported.
> 
> Those patches are already in 5.3+ kernel,
> only bionic and disco kernel need them.
> 
> backports are due to the filename and minor content changes.
> 
> v2 changes:
> Since commit 0c043d70d04 which is included by 5.3 is already
> in bionic and disco kernel, so backport this commit change
> in filename changes.
> 
> 
> Jeffrey Hugo (3):
>   HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630
>   Input: elan_i2c - export the device id whitelist
>   HID: quirks: Refactor ELAN 400 and 401 handling
> 
>  drivers/hid/hid-core.c              | 19 +++++---
>  drivers/input/mouse/elan_i2c_core.c | 50 +------------------
>  include/linux/input/elan-i2c-ids.h  | 76 +++++++++++++++++++++++++++++
>  3 files changed, 88 insertions(+), 57 deletions(-)
>  create mode 100644 include/linux/input/elan-i2c-ids.h
>
Stefan Bader Nov. 28, 2019, 3:18 p.m. UTC | #2
On 21.11.19 07:40, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1853246
> 
> [Impact]
> New touchpads are ignored by hid driver because of IDs are missed in the
> whitelist.
> 
> [Fix]
> Only 2 Elan touchpad IDs are allowed to be loaded in hid driver.
> Change to the blacklist of elan touchpads supported by elan_i2c, so
> others can be enabled by hid.
> 
> [Test]
> Verified on hardware. Tests results are good.
> 
> [Regression Potential]
> Low.
> keep current IDs of elan_i2c, loads those touchpads ID those weren't
> supported.
> 
> Those patches are already in 5.3+ kernel,
> only bionic and disco kernel need them.
> 
> backports are due to the filename and minor content changes.
> 
> v2 changes:
> Since commit 0c043d70d04 which is included by 5.3 is already
> in bionic and disco kernel, so backport this commit change
> in filename changes.
> 
> 
> Jeffrey Hugo (3):
>   HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630
>   Input: elan_i2c - export the device id whitelist
>   HID: quirks: Refactor ELAN 400 and 401 handling
> 
>  drivers/hid/hid-core.c              | 19 +++++---
>  drivers/input/mouse/elan_i2c_core.c | 50 +------------------
>  include/linux/input/elan-i2c-ids.h  | 76 +++++++++++++++++++++++++++++
>  3 files changed, 88 insertions(+), 57 deletions(-)
>  create mode 100644 include/linux/input/elan-i2c-ids.h
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Kleber Souza Dec. 2, 2019, 11:53 a.m. UTC | #3
On 2019-11-21 07:40, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1853246
> 
> [Impact]
> New touchpads are ignored by hid driver because of IDs are missed in the
> whitelist.
> 
> [Fix]
> Only 2 Elan touchpad IDs are allowed to be loaded in hid driver.
> Change to the blacklist of elan touchpads supported by elan_i2c, so
> others can be enabled by hid.
> 
> [Test]
> Verified on hardware. Tests results are good.
> 
> [Regression Potential]
> Low.
> keep current IDs of elan_i2c, loads those touchpads ID those weren't
> supported.
> 
> Those patches are already in 5.3+ kernel,
> only bionic and disco kernel need them.
> 
> backports are due to the filename and minor content changes.
> 
> v2 changes:
> Since commit 0c043d70d04 which is included by 5.3 is already
> in bionic and disco kernel, so backport this commit change
> in filename changes.
> 
> 
> Jeffrey Hugo (3):
>   HID: quirks: Fix keyboard + touchpad on Lenovo Miix 630
>   Input: elan_i2c - export the device id whitelist
>   HID: quirks: Refactor ELAN 400 and 401 handling
> 
>  drivers/hid/hid-core.c              | 19 +++++---
>  drivers/input/mouse/elan_i2c_core.c | 50 +------------------
>  include/linux/input/elan-i2c-ids.h  | 76 +++++++++++++++++++++++++++++
>  3 files changed, 88 insertions(+), 57 deletions(-)
>  create mode 100644 include/linux/input/elan-i2c-ids.h
> 

Applied to bionic and disco master-next branches.

Thanks,
Kleber