mbox series

[SRU,B/D,0/1] Remove Ideapad HW rfkill list

Message ID 20190729160656.13442-1-kai.heng.feng@canonical.com
Headers show
Series Remove Ideapad HW rfkill list | expand

Message

Kai-Heng Feng July 29, 2019, 4:06 p.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1837136

[Impact]
WiFi on Ideapads are rfkill HW blocked by default.

[Fix]
Remove no_hw_rfkill_list as most Ideapads don't have hardware rfkill
button.

[Test]
User reported the fix works.

[Regression Potential]
Low. If there's any actual device that has HW rfkill button, we can
simply add it to whitelist.

Hans de Goede (1):
  platform/x86: ideapad-laptop: Remove no_hw_rfkill_list

 drivers/platform/x86/ideapad-laptop.c | 307 ++------------------------
 1 file changed, 15 insertions(+), 292 deletions(-)

Comments

Connor Kuehl July 29, 2019, 10:44 p.m. UTC | #1 
On 7/29/19 9:06 AM, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1837136
> 
> [Impact]
> WiFi on Ideapads are rfkill HW blocked by default.
> 
> [Fix]
> Remove no_hw_rfkill_list as most Ideapads don't have hardware rfkill
> button.
> 
> [Test]
> User reported the fix works.
> 
> [Regression Potential]
> Low. If there's any actual device that has HW rfkill button, we can
> simply add it to whitelist.
> 
> Hans de Goede (1):
>   platform/x86: ideapad-laptop: Remove no_hw_rfkill_list
> 
>  drivers/platform/x86/ideapad-laptop.c | 307 ++------------------------
>  1 file changed, 15 insertions(+), 292 deletions(-)
> 

Acked-by: Connor Kuehl <connor.kuehl@canonical.com>
Stefan Bader Aug. 12, 2019, 12:44 p.m. UTC | #2 
On 29.07.19 18:06, Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1837136
> 
> [Impact]
> WiFi on Ideapads are rfkill HW blocked by default.
> 
> [Fix]
> Remove no_hw_rfkill_list as most Ideapads don't have hardware rfkill
> button.
> 
> [Test]
> User reported the fix works.
> 
> [Regression Potential]
> Low. If there's any actual device that has HW rfkill button, we can
> simply add it to whitelist.
> 
> Hans de Goede (1):
>   platform/x86: ideapad-laptop: Remove no_hw_rfkill_list
> 
>  drivers/platform/x86/ideapad-laptop.c | 307 ++------------------------
>  1 file changed, 15 insertions(+), 292 deletions(-)
> 
As the commit message describes, we will have to look out for bug reports saying
"there are no networks I can connect to" and check whether those are some
Ideapad with the switch set to off.

Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously Aug. 13, 2019, 5:26 a.m. UTC | #3 
On 2019-07-30 00:06:54 , Kai-Heng Feng wrote:
> BugLink: https://bugs.launchpad.net/bugs/1837136
> 
> [Impact]
> WiFi on Ideapads are rfkill HW blocked by default.
> 
> [Fix]
> Remove no_hw_rfkill_list as most Ideapads don't have hardware rfkill
> button.
> 
> [Test]
> User reported the fix works.
> 
> [Regression Potential]
> Low. If there's any actual device that has HW rfkill button, we can
> simply add it to whitelist.
> 
> Hans de Goede (1):
>   platform/x86: ideapad-laptop: Remove no_hw_rfkill_list
> 
>  drivers/platform/x86/ideapad-laptop.c | 307 ++------------------------
>  1 file changed, 15 insertions(+), 292 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team