| Message ID | 20190717144211.4687-1-hui.wang@canonical.com |
|---|---|
| Headers | show |
| Series | alsa/hdmi: add icelake hdmi audio support for a Dell machine | expand |
On 17.07.19 16:42, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836916 > > This patch is needed to be merged to oem-osp1-b kernel ASAP, since > our oem project is waiting for this patch. > > And Since this patch is to support icl hdmi audio and it depends on > i915 to support icl first, and our bionic and oem-b kernel doesn't > support icl in their i915 driver, so these patchset doesn't work for > B/OEM-B, as a result, I don't send them for B/OEM-B. > > And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel > doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 > to EAON kernel. > > [Impact] > On a Dell icelake platform, the hdmi audio doesn't work at all, when users > plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. > > [Fix] > add icl hdmi audio id and related support patch to alsa driver. > > [Test Case] > after applying the patchset, we plug hdmi cable and the hdmi audio shows up > in the sound-setting and works well, after unplugging the cable, the hdmi > audio disappears as expected. > > [Regression Risk] > Low. this patchset is specific to a icl hdmi audio codec. > > > > Jaroslav Kysela (1): > ALSA: hda: hdmi - add Icelake support > > Takashi Iwai (2): > ALSA: hda/hdmi - Remove duplicated define > ALSA: hda/hdmi - Fix i915 reverse port/pin mapping > > sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++--------- > 1 file changed, 69 insertions(+), 21 deletions(-) > With 2/3 of a set coming from subsystem maintainers tip and not fully buying into a low regression potential (it changes a driver which at least is shared across similar HW and Intel is not unknown to break older stuff when adding new stuff) I am wondering whether this really is Sru material...
On 2019/7/19 下午4:42, Stefan Bader wrote: > On 17.07.19 16:42, Hui Wang wrote: >> BugLink: https://bugs.launchpad.net/bugs/1836916 >> >> This patch is needed to be merged to oem-osp1-b kernel ASAP, since >> our oem project is waiting for this patch. >> >> And Since this patch is to support icl hdmi audio and it depends on >> i915 to support icl first, and our bionic and oem-b kernel doesn't >> support icl in their i915 driver, so these patchset doesn't work for >> B/OEM-B, as a result, I don't send them for B/OEM-B. >> >> And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel >> doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 >> to EAON kernel. >> >> [Impact] >> On a Dell icelake platform, the hdmi audio doesn't work at all, when users >> plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. >> >> [Fix] >> add icl hdmi audio id and related support patch to alsa driver. >> >> [Test Case] >> after applying the patchset, we plug hdmi cable and the hdmi audio shows up >> in the sound-setting and works well, after unplugging the cable, the hdmi >> audio disappears as expected. >> >> [Regression Risk] >> Low. this patchset is specific to a icl hdmi audio codec. >> >> >> >> Jaroslav Kysela (1): >> ALSA: hda: hdmi - add Icelake support >> >> Takashi Iwai (2): >> ALSA: hda/hdmi - Remove duplicated define >> ALSA: hda/hdmi - Fix i915 reverse port/pin mapping >> >> sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++--------- >> 1 file changed, 69 insertions(+), 21 deletions(-) >> > With 2/3 of a set coming from subsystem maintainers tip and not fully buying > into a low regression potential (it changes a driver which at least is shared > across similar HW and Intel is not unknown to break older stuff when adding new > stuff) I am wondering whether this really is Sru material... Our OEM project needs this patchset, otherwise the hdmi audio doesn't work on Dell icl laptop. The 0001 patch is specific to icl codec by adding the new codec id, and the 0003 has no change for codec with port_num==0, that means there is no change for non-icl codec after applying this patch. If you think it is too early to merge these patches to generic kernel, it is fine to drop them. let the OEM-OSP1-B merge them first. Thanks >
On Wed, Jul 17, 2019 at 10:42:08PM +0800, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836916 > > This patch is needed to be merged to oem-osp1-b kernel ASAP, since > our oem project is waiting for this patch. > > And Since this patch is to support icl hdmi audio and it depends on > i915 to support icl first, and our bionic and oem-b kernel doesn't > support icl in their i915 driver, so these patchset doesn't work for > B/OEM-B, as a result, I don't send them for B/OEM-B. > > And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel > doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 > to EAON kernel. > > [Impact] > On a Dell icelake platform, the hdmi audio doesn't work at all, when users > plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. > > [Fix] > add icl hdmi audio id and related support patch to alsa driver. > > [Test Case] > after applying the patchset, we plug hdmi cable and the hdmi audio shows up > in the sound-setting and works well, after unplugging the cable, the hdmi > audio disappears as expected. > > [Regression Risk] > Low. this patchset is specific to a icl hdmi audio codec. One of these patches is upstream but the others are not, so please remember to include the development release! I see that Stefan has reservations for these for stable, but they seem appropriate for the development release, so I have applied them to eoan/master-next.
On 17.07.19 16:42, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836916 > > This patch is needed to be merged to oem-osp1-b kernel ASAP, since > our oem project is waiting for this patch. > > And Since this patch is to support icl hdmi audio and it depends on > i915 to support icl first, and our bionic and oem-b kernel doesn't > support icl in their i915 driver, so these patchset doesn't work for > B/OEM-B, as a result, I don't send them for B/OEM-B. > > And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel > doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 > to EAON kernel. > > [Impact] > On a Dell icelake platform, the hdmi audio doesn't work at all, when users > plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. > > [Fix] > add icl hdmi audio id and related support patch to alsa driver. > > [Test Case] > after applying the patchset, we plug hdmi cable and the hdmi audio shows up > in the sound-setting and works well, after unplugging the cable, the hdmi > audio disappears as expected. > > [Regression Risk] > Low. this patchset is specific to a icl hdmi audio codec. > > The latter 2 patches are now upstream. So with updated sha1 references, I think its ok now for disco. > > Jaroslav Kysela (1): > ALSA: hda: hdmi - add Icelake support > > Takashi Iwai (2): commit eb4177116bf568a413c544eca3f4446cb4064be9 > ALSA: hda/hdmi - Remove duplicated define commit 3140aafb22edeab0cc41f15f53b12a118c0ac215 > ALSA: hda/hdmi - Fix i915 reverse port/pin mapping > > sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++--------- > 1 file changed, 69 insertions(+), 21 deletions(-) > Acked-by: Stefan Bader <stefan.bader@canonical.com>
On 7/17/19 4:42 PM, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836916 > > This patch is needed to be merged to oem-osp1-b kernel ASAP, since > our oem project is waiting for this patch. > > And Since this patch is to support icl hdmi audio and it depends on > i915 to support icl first, and our bionic and oem-b kernel doesn't > support icl in their i915 driver, so these patchset doesn't work for > B/OEM-B, as a result, I don't send them for B/OEM-B. > > And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel > doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 > to EAON kernel. > > [Impact] > On a Dell icelake platform, the hdmi audio doesn't work at all, when users > plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. > > [Fix] > add icl hdmi audio id and related support patch to alsa driver. > > [Test Case] > after applying the patchset, we plug hdmi cable and the hdmi audio shows up > in the sound-setting and works well, after unplugging the cable, the hdmi > audio disappears as expected. > > [Regression Risk] > Low. this patchset is specific to a icl hdmi audio codec. > > > > Jaroslav Kysela (1): > ALSA: hda: hdmi - add Icelake support > > Takashi Iwai (2): > ALSA: hda/hdmi - Remove duplicated define > ALSA: hda/hdmi - Fix i915 reverse port/pin mapping > > sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++--------- > 1 file changed, 69 insertions(+), 21 deletions(-) > With the sha1 references updated as mentioned by Stefan: Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 7/17/19 4:42 PM, Hui Wang wrote: > BugLink: https://bugs.launchpad.net/bugs/1836916 > > This patch is needed to be merged to oem-osp1-b kernel ASAP, since > our oem project is waiting for this patch. > > And Since this patch is to support icl hdmi audio and it depends on > i915 to support icl first, and our bionic and oem-b kernel doesn't > support icl in their i915 driver, so these patchset doesn't work for > B/OEM-B, as a result, I don't send them for B/OEM-B. > > And the 0001-xxx.patch is already in the kernel-v5.1, so EAON kernel > doesn't need to apply 0001-xxx.patch, only need to apply 0002 and 0003 > to EAON kernel. > > [Impact] > On a Dell icelake platform, the hdmi audio doesn't work at all, when users > plug hdmi cable, they can't find hdmi audio from gnome-sound-setting. > > [Fix] > add icl hdmi audio id and related support patch to alsa driver. > > [Test Case] > after applying the patchset, we plug hdmi cable and the hdmi audio shows up > in the sound-setting and works well, after unplugging the cable, the hdmi > audio disappears as expected. > > [Regression Risk] > Low. this patchset is specific to a icl hdmi audio codec. > > > > Jaroslav Kysela (1): > ALSA: hda: hdmi - add Icelake support > > Takashi Iwai (2): > ALSA: hda/hdmi - Remove duplicated define > ALSA: hda/hdmi - Fix i915 reverse port/pin mapping > > sound/pci/hda/patch_hdmi.c | 90 +++++++++++++++++++++++++++++--------- > 1 file changed, 69 insertions(+), 21 deletions(-) > Applied to disco/master-next branch, removing the additional maintainer repo info from patches 2 and 3 (the sha1 was kept the same). Thanks, Kleber