From patchwork Thu May 16 10:20:22 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Po-Hsu Lin X-Patchwork-Id: 1100466 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 454SBR161Wz9s6w; Thu, 16 May 2019 20:21:17 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hRDVe-0006cU-54; Thu, 16 May 2019 10:21:10 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hRDVc-0006c5-Ko for kernel-team@lists.ubuntu.com; Thu, 16 May 2019 10:21:08 +0000 Received: from mail-pg1-f199.google.com ([209.85.215.199]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hRDV2-0008NT-SQ for kernel-team@lists.ubuntu.com; Thu, 16 May 2019 10:20:33 +0000 Received: by mail-pg1-f199.google.com with SMTP id o8so1921810pgq.5 for ; Thu, 16 May 2019 03:20:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id; bh=d6u6EvRneITG0W/LOLG/y0lJYYBoTrWKxSmk5KkEIWg=; b=lVjRztVrOPyLnrtSX8Gc8UjVktjtYkz9CjGsiqS9bjMXyiT3d1fxjppB5eHvB/+Zta hX1KZMajeUySTSYe5ucOtYc4bQJF0jNbuOX5V5EuFvK5ryJZQoINLoEVHbNTQZ0ykmTQ mHmjORU4giOk5KrU93Cnt0wSRg9TvloPr1wPHxMgLPCzwywpts2CkEXBGcInjXyU9suI qj6tfPUJYdKU7UQ91I0tbS11p3B/XUo0eEzdJ9cv97mxMyXEEfQzxO0YgDjvd4rB1Moq 02fJuWMLXpQYI/BzCh5IF3tHPm5EoYpyvvzqdDjKhf32vTVOn/4Uk/EgRRCq8eQvyJG6 420w== X-Gm-Message-State: APjAAAXJlthCBRx2ejb6KlsubTSBYda+TgXz+NtjkNrcONQd1++hBy1i wXFfhSM+xUOrJQqHzG7ti0nOROX+1macm5CVYbavzwK3yIqDJyVe6fUZ8fQVBkl6xTC74nZVMVH lF0S8u+7DGsR5l9Dt+orUEsT/DOR5ZU9InwfUronl X-Received: by 2002:a62:6585:: with SMTP id z127mr13833919pfb.179.1558002031109; Thu, 16 May 2019 03:20:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqyVuuyyP5WpoCtrIbdFd8bZ8aTRyUFsFxq7KAeCgr+VL6AS0dZsKWwKMp4KgQvidS6i1tPkwg== X-Received: by 2002:a62:6585:: with SMTP id z127mr13833861pfb.179.1558002030537; Thu, 16 May 2019 03:20:30 -0700 (PDT) Received: from Leggiero.taipei.internal (61-220-137-37.HINET-IP.hinet.net. [61.220.137.37]) by smtp.gmail.com with ESMTPSA id l65sm9379714pfb.7.2019.05.16.03.20.29 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 16 May 2019 03:20:29 -0700 (PDT) From: Po-Hsu Lin To: kernel-team@lists.ubuntu.com Subject: [B][C][SRU][PATCH 0/1] selftests/seccomp: Enhance per-arch ptrace syscall skip tests Date: Thu, 16 May 2019 18:20:22 +0800 Message-Id: <20190516102023.19004-1-po-hsu.lin@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1812796 == SRU Justification == The TRACE_syscall.ptrace_syscall_dropped test in seccomp from ubuntu_kernel_selftests will fail on a Power8 node with B/C kernel. [ RUN ] TRACE_syscall.ptrace_syscall_dropped seccomp_bpf.c:1808:TRACE_syscall.ptrace_syscall_dropped:Expected 1 (1) == syscall(286) (18446744073709551615) TRACE_syscall.ptrace_syscall_dropped: Test failed at step #13 [ FAIL ] TRACE_syscall.ptrace_syscall_dropped == Fix == * ed5f1326 (selftests/seccomp: Enhance per-arch ptrace syscall skip tests) This patch can be cherry-picked into B/C, and it's already in Disco. The ptrace_syscall_dropped will be changed into ptrace_syscall_faked, and a new ptrace_syscall_errno test will be added. == Test == Patch tested with different arch (amd64 / power8 / arm64 / i386), the new test will pass on them except for PowerPC. Although the faked (bug 1829363) and errno (bug 1829359) test will fail on PowerPC, it's actually helping us to nail down a real issue in our kernel. == Regression Potential == Low, changes limited to the testing tool in the kernel. Kees Cook (1): selftests/seccomp: Enhance per-arch ptrace syscall skip tests tools/testing/selftests/seccomp/seccomp_bpf.c | 72 +++++++++++++++++++++------ 1 file changed, 57 insertions(+), 15 deletions(-) Acked-by: Connor Kuehl