mbox series

[v2,0/2,linux-signed,SRU,Disco] Fix Built-Using package name

Message ID 20190411215058.9640-1-dann.frazier@canonical.com
Headers show
Series Fix Built-Using package name | expand

Message

dann frazier April 11, 2019, 9:50 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1824016

The Built-Using field hardcodes "linux" as the source package, even for the
hwe & hwe-edge packages. Correct that. Technically only the
linux-signed-hwe{-edge} packages need this fix, but I'm including patches
for linux-signed as well to prevent future occurences due to cargo-culting.

Verified by confirming that the same control file is generated before
and after this change (it is to linux-signed, where the hardcoded package
name happens to be correct).

fyi, I've got another branch with a lot more cleanup, but I'll just sit on
that until the next devel release, unless there's already a tree to target
there (unstable?).

v2:
  * Clarify the vague PACKAGE, VERSION template vars by prefixing
    them with "UNSIGNED_SRC_".
  * Restrict to linux-signed/disco until the approach is agreed.

dann frazier (2):
  UBUNTU: Rename "VERSION" template string to more precise
    "UNSIGNED_SRC_VERSION"
  UBUNTU: Use the correct source package name in Built-Using field

 debian/control.stub | 8 ++++----
 debian/rules        | 3 ++-
 2 files changed, 6 insertions(+), 5 deletions(-)

Comments

Stefan Bader April 23, 2019, 8:33 a.m. UTC | #1
On 11.04.19 23:50, dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1824016
> 
> The Built-Using field hardcodes "linux" as the source package, even for the
> hwe & hwe-edge packages. Correct that. Technically only the
> linux-signed-hwe{-edge} packages need this fix, but I'm including patches
> for linux-signed as well to prevent future occurences due to cargo-culting.
> 
> Verified by confirming that the same control file is generated before
> and after this change (it is to linux-signed, where the hardcoded package
> name happens to be correct).
> 
> fyi, I've got another branch with a lot more cleanup, but I'll just sit on
> that until the next devel release, unless there's already a tree to target
> there (unstable?).
> 
> v2:
>   * Clarify the vague PACKAGE, VERSION template vars by prefixing
>     them with "UNSIGNED_SRC_".
>   * Restrict to linux-signed/disco until the approach is agreed.
> 
> dann frazier (2):
>   UBUNTU: Rename "VERSION" template string to more precise
>     "UNSIGNED_SRC_VERSION"
>   UBUNTU: Use the correct source package name in Built-Using field
> 
>  debian/control.stub | 8 ++++----
>  debian/rules        | 3 ++-
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously April 24, 2019, 5:55 a.m. UTC | #2
On 2019-04-11 15:50:56 , dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1824016
> 
> The Built-Using field hardcodes "linux" as the source package, even for the
> hwe & hwe-edge packages. Correct that. Technically only the
> linux-signed-hwe{-edge} packages need this fix, but I'm including patches
> for linux-signed as well to prevent future occurences due to cargo-culting.
> 
> Verified by confirming that the same control file is generated before
> and after this change (it is to linux-signed, where the hardcoded package
> name happens to be correct).
> 
> fyi, I've got another branch with a lot more cleanup, but I'll just sit on
> that until the next devel release, unless there's already a tree to target
> there (unstable?).
> 
> v2:
>   * Clarify the vague PACKAGE, VERSION template vars by prefixing
>     them with "UNSIGNED_SRC_".
>   * Restrict to linux-signed/disco until the approach is agreed.
> 
> dann frazier (2):
>   UBUNTU: Rename "VERSION" template string to more precise
>     "UNSIGNED_SRC_VERSION"
>   UBUNTU: Use the correct source package name in Built-Using field
> 
>  debian/control.stub | 8 ++++----
>  debian/rules        | 3 ++-
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> -- 
> 2.20.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team
Khalid Elmously April 24, 2019, 6:50 a.m. UTC | #3
On 2019-04-11 15:50:56 , dann frazier wrote:
> BugLink: https://bugs.launchpad.net/bugs/1824016
> 
> The Built-Using field hardcodes "linux" as the source package, even for the
> hwe & hwe-edge packages. Correct that. Technically only the
> linux-signed-hwe{-edge} packages need this fix, but I'm including patches
> for linux-signed as well to prevent future occurences due to cargo-culting.
> 
> Verified by confirming that the same control file is generated before
> and after this change (it is to linux-signed, where the hardcoded package
> name happens to be correct).
> 
> fyi, I've got another branch with a lot more cleanup, but I'll just sit on
> that until the next devel release, unless there's already a tree to target
> there (unstable?).
> 
> v2:
>   * Clarify the vague PACKAGE, VERSION template vars by prefixing
>     them with "UNSIGNED_SRC_".
>   * Restrict to linux-signed/disco until the approach is agreed.
> 
> dann frazier (2):
>   UBUNTU: Rename "VERSION" template string to more precise
>     "UNSIGNED_SRC_VERSION"
>   UBUNTU: Use the correct source package name in Built-Using field
> 
>  debian/control.stub | 8 ++++----
>  debian/rules        | 3 ++-
>  2 files changed, 6 insertions(+), 5 deletions(-)
> 
> -- 
> 2.20.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team