From patchwork Sun Mar 31 23:33:05 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Murray X-Patchwork-Id: 1072100 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44XWxY14pYz9sQm; Mon, 1 Apr 2019 10:33:21 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hAjww-0008NB-KC; Sun, 31 Mar 2019 23:33:14 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hAjwu-0008Mx-U6 for kernel-team@lists.ubuntu.com; Sun, 31 Mar 2019 23:33:12 +0000 Received: from ppp121-45-96-156.bras2.adl6.internode.on.net ([121.45.96.156] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1hAjwt-0003rW-Ow for kernel-team@lists.ubuntu.com; Sun, 31 Mar 2019 23:33:12 +0000 From: Alex Murray To: kernel-team@lists.ubuntu.com Subject: [PATCH 0/1] [SRU] [Bionic/raspi2] Add devicetree overlay for SLB9670 TPM module Date: Mon, 1 Apr 2019 10:03:05 +1030 Message-Id: <20190331233306.10502-1-alex.murray@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1822036 [Impact] Currently it is not possible to use the SLB9670 TPM module with Ubuntu Core since we do not ship the required devicetree overlay to enable it https://github.com/raspberrypi/linux/commit/c28ac2dc08bd73963f953a757a3362c64b5524ed and there is no way for snaps to easily add their own devicetree overlay. Finally it is not practical to expect Ubuntu Core users to have to build and maintain their own kernels just to support a particular hardware device. For background discussion, refer to this thread on the snapcraft forums https://forum.snapcraft.io/t/guidance-on-snap-interface-to-load-a-device-tree-overlay-on-rpi-core18/10106/11 Once this overlay is added, then users simply need to modify the boot config.txt to enable the overlay to be loaded automatically. In the future, snapd might also enable support so this can be managed by snapd via snap system configuration. [Test Case] Boot a RPi with a SLB9670 connected, modify /boot/config.txt to specify dtoverlay=tpm-slb9670, then load the tpm_tis_spi module and /dev/tpm0 should be available. [Regression Potential] Almost zero chance of regression potential since this is simply adding a new overlay to the kernel. This is not loaded automatically so there is no real chance of regression. [Other Info] All that is required for this SRU is to merge https://github.com/raspberrypi/linux/commit/c28ac2dc08bd73963f953a757a3362c64b5524ed to the current bionic raspi kernel branch. Peter Huewe (1): Add overlay for SLB9760 Iridium /LetsTrust TPM arch/arm/boot/dts/overlays/Makefile | 1 + arch/arm/boot/dts/overlays/README | 8 ++++ .../boot/dts/overlays/tpm-slb9670-overlay.dts | 44 +++++++++++++++++++ 3 files changed, 53 insertions(+) create mode 100644 arch/arm/boot/dts/overlays/tpm-slb9670-overlay.dts