mbox series

[0/1,SRU,B/B-OEM/C/D] Fix AMD IOMMU NULL dereference

Message ID 20190320104138.8734-1-aaron.ma@canonical.com
Headers show
Series Fix AMD IOMMU NULL dereference | expand

Message

Aaron Ma March 20, 2019, 10:41 a.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1820990

[Impact]
When no acpi hid match the device, there will be a NULL dereference in
amd iommu.
It will make system hang.

[Fix]
Check NULL pointer before using it.

[Test]
Tested on several AMD platforms, bugs are fixed with this patch.

[Regression Potential]
Low, upstream fix, Verified on several platforms.
It should be safe.

Aaron Ma (1):
  iommu/amd: Fix NULL dereference bug in match_hid_uid

 drivers/iommu/amd_iommu.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

Comments

Seth Forshee March 20, 2019, 9:05 p.m. UTC | #1
On Wed, Mar 20, 2019 at 06:41:37PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1820990
> 
> [Impact]
> When no acpi hid match the device, there will be a NULL dereference in
> amd iommu.
> It will make system hang.
> 
> [Fix]
> Check NULL pointer before using it.
> 
> [Test]
> Tested on several AMD platforms, bugs are fixed with this patch.
> 
> [Regression Potential]
> Low, upstream fix, Verified on several platforms.
> It should be safe.

Applied to disco/master-next, thanks!
Khaled Elmously March 25, 2019, 5:01 a.m. UTC | #2
On 2019-03-20 18:41:37 , Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1820990
> 
> [Impact]
> When no acpi hid match the device, there will be a NULL dereference in
> amd iommu.
> It will make system hang.
> 
> [Fix]
> Check NULL pointer before using it.
> 
> [Test]
> Tested on several AMD platforms, bugs are fixed with this patch.
> 
> [Regression Potential]
> Low, upstream fix, Verified on several platforms.
> It should be safe.
> 
> Aaron Ma (1):
>   iommu/amd: Fix NULL dereference bug in match_hid_uid
> 
>  drivers/iommu/amd_iommu.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team