From patchwork Wed Mar 20 01:47:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hui Wang X-Patchwork-Id: 1058805 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 44PCVV34JJz9sNk; Wed, 20 Mar 2019 12:48:02 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1h6QKd-0008AS-4J; Wed, 20 Mar 2019 01:47:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1h6QKb-0008AM-Vi for kernel-team@lists.ubuntu.com; Wed, 20 Mar 2019 01:47:49 +0000 Received: from [112.44.203.234] (helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1h6QKa-00036s-Ut for kernel-team@lists.ubuntu.com; Wed, 20 Mar 2019 01:47:49 +0000 From: Hui Wang To: kernel-team@lists.ubuntu.com Subject: [SRU][B/B-OEM/C/D][PATCH 0/1] codecs stop working after S3 Date: Wed, 20 Mar 2019 09:47:15 +0800 Message-Id: <20190320014718.8974-1-hui.wang@canonical.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1820930 To fix this bug, B/OEM-B/C needs only 1 patch, while v5.0-rc1 introduced a new patch which affect this issue, so the DISCO needs 2 patches. [Impact] After S3, some codecs (alc236, alc255, alc891 and some HDMI codec) stop working, they can't detect jack plugging/unplugging or the audio device can't show up in the gnome-sound-setting [Fix] After S3, if it runs runtime_resume(), the codec works again. We change the driver to let system_resume() trigger runtime_resume() [Test Case] This issue is reported from OEM project, some codecs can't detect jack pluggin/unplugging, some codecs can't show up in the UI, after applying this patch, all related bugs are fixed. [Regression Potential] Low. have tested on many machines (with this issue or without this issue), all worked well. Hui Wang (2): ALSA: hda - Enforces runtime_resume after S3 and S4 for each codec ALSA: hda - Don't trigger jackpoll_work in azx_resume sound/pci/hda/hda_codec.c | 18 +++++++++++++++++- sound/pci/hda/hda_intel.c | 8 ++++---- 2 files changed, 21 insertions(+), 5 deletions(-) Acked-by: Seth Forshee Acked-by: Aaron Ma