mbox series

[0/2,SRU,B/C/D/OEM] Fix Xorg crash with nomodeset when BIOS

Message ID 20190122070546.8317-1-aaron.ma@canonical.com
Headers show
Series Fix Xorg crash with nomodeset when BIOS | expand

Message

Aaron Ma Jan. 22, 2019, 7:05 a.m. UTC 
BugLink: https://bugs.launchpad.net/bugs/1812797

[Impact]
On dual GPU platform, BIOS set frame buffer addr to 64-bit,
usually when CSM=NO setting in BIOS.
When no proper GPU driver loaded, Xorg driver will use the wrong fb addr,
then crash.

[Fix]
Add 64-bit efifb support, make Xorg find the correct GPU fb addr.
If still failed, use the first GPU as default.

[Test]
Tested on Intel and NV dual GPU platform. Works fine.

[Regression Potential]
Upstream fix, low risk.
Verified on ThinkPad P1/P52.

Aaron Ma (2):
  vgaarb: Add support for 64-bit frame buffer address
  vgaarb: Keep adding VGA device in queue

 drivers/gpu/vga/vgaarb.c | 21 ++++++++++++++-------
 1 file changed, 14 insertions(+), 7 deletions(-)

Comments

Seth Forshee Jan. 22, 2019, 7:49 p.m. UTC | #1 
On Tue, Jan 22, 2019 at 03:05:44PM +0800, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1812797
> 
> [Impact]
> On dual GPU platform, BIOS set frame buffer addr to 64-bit,
> usually when CSM=NO setting in BIOS.
> When no proper GPU driver loaded, Xorg driver will use the wrong fb addr,
> then crash.
> 
> [Fix]
> Add 64-bit efifb support, make Xorg find the correct GPU fb addr.
> If still failed, use the first GPU as default.
> 
> [Test]
> Tested on Intel and NV dual GPU platform. Works fine.
> 
> [Regression Potential]
> Upstream fix, low risk.
> Verified on ThinkPad P1/P52.

Upstream cherry picks, positive testing.

Acked-by: Seth Forshee <seth.forshee@canonical.com>

Applied to disco/master-next, thanks!
Stefan Bader Jan. 30, 2019, 2:03 p.m. UTC | #2 
On 22.01.19 08:05, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1812797
> 
> [Impact]
> On dual GPU platform, BIOS set frame buffer addr to 64-bit,
> usually when CSM=NO setting in BIOS.
> When no proper GPU driver loaded, Xorg driver will use the wrong fb addr,
> then crash.
> 
> [Fix]
> Add 64-bit efifb support, make Xorg find the correct GPU fb addr.
> If still failed, use the first GPU as default.
> 
> [Test]
> Tested on Intel and NV dual GPU platform. Works fine.
> 
> [Regression Potential]
> Upstream fix, low risk.
> Verified on ThinkPad P1/P52.
> 
> Aaron Ma (2):
>   vgaarb: Add support for 64-bit frame buffer address
>   vgaarb: Keep adding VGA device in queue
> 
>  drivers/gpu/vga/vgaarb.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
Acked-by: Stefan Bader <stefan.bader@canonical.com>
Khalid Elmously Feb. 1, 2019, 2:43 a.m. UTC | #3 
On 2019-01-22 15:05:44 , Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1812797
> 
> [Impact]
> On dual GPU platform, BIOS set frame buffer addr to 64-bit,
> usually when CSM=NO setting in BIOS.
> When no proper GPU driver loaded, Xorg driver will use the wrong fb addr,
> then crash.
> 
> [Fix]
> Add 64-bit efifb support, make Xorg find the correct GPU fb addr.
> If still failed, use the first GPU as default.
> 
> [Test]
> Tested on Intel and NV dual GPU platform. Works fine.
> 
> [Regression Potential]
> Upstream fix, low risk.
> Verified on ThinkPad P1/P52.
> 
> Aaron Ma (2):
>   vgaarb: Add support for 64-bit frame buffer address
>   vgaarb: Keep adding VGA device in queue
> 
>  drivers/gpu/vga/vgaarb.c | 21 ++++++++++++++-------
>  1 file changed, 14 insertions(+), 7 deletions(-)
> 
> -- 
> 2.17.1
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team