mbox series

[SRU,B/OEM,0/2,v2] : SRU: xhci hang when resume from S3

Message ID 20181128152924.16867-1-aaron.ma@canonical.com
Headers show
Series : SRU: xhci hang when resume from S3 | expand

Message

Aaron Ma Nov. 28, 2018, 3:29 p.m. UTC
BugLink: https://bugs.launchpad.net/bugs/1805344

Chnangelog:
V2:
Add BugLink.

[Impact]
On some thinkpad laptops, Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, then kernel hang.

[Fix]
Restrict the USB2 resume status check in USB2 roothub to fix hang issue.

[Test Case]
Suspend/resume 30 times OK.

[Regression Potential]
Low, upstream fix backported/cherry-picked.

These 2 patches are already Cc: stable@vger.kernel.org, cosmic and future kernel will get these 2 patches.

Aaron Ma (2):
  usb: xhci: fix uninitialized completion when USB3 port got wrong
    status
  usb: xhci: fix timeout for transition from RExit to U0

 drivers/usb/host/xhci-hub.c  | 6 +++---
 drivers/usb/host/xhci-ring.c | 2 +-
 drivers/usb/host/xhci.h      | 2 +-
 3 files changed, 5 insertions(+), 5 deletions(-)

Comments

AceLan Kao Nov. 29, 2018, 7:17 a.m. UTC | #1
Acked-By: AceLan Kao <acelan.kao@canonical.com>
Hui Wang Nov. 29, 2018, 7:20 a.m. UTC | #2
Acked-by: Hui Wang <hui.wang@canonical.com>

On 2018/11/28 下午11:29, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1805344
>
> Chnangelog:
> V2:
> Add BugLink.
>
> [Impact]
> On some thinkpad laptops, Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
> Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, then kernel hang.
>
> [Fix]
> Restrict the USB2 resume status check in USB2 roothub to fix hang issue.
>
> [Test Case]
> Suspend/resume 30 times OK.
>
> [Regression Potential]
> Low, upstream fix backported/cherry-picked.
>
> These 2 patches are already Cc: stable@vger.kernel.org, cosmic and future kernel will get these 2 patches.
>
> Aaron Ma (2):
>    usb: xhci: fix uninitialized completion when USB3 port got wrong
>      status
>    usb: xhci: fix timeout for transition from RExit to U0
>
>   drivers/usb/host/xhci-hub.c  | 6 +++---
>   drivers/usb/host/xhci-ring.c | 2 +-
>   drivers/usb/host/xhci.h      | 2 +-
>   3 files changed, 5 insertions(+), 5 deletions(-)
>
AceLan Kao Nov. 30, 2018, 1:55 a.m. UTC | #3
Applied on oem kernel 4.15.0-1029.34
Kleber Souza Jan. 9, 2019, 2:14 p.m. UTC | #4
On 11/28/18 4:29 PM, Aaron Ma wrote:
> BugLink: https://bugs.launchpad.net/bugs/1805344
>
> Chnangelog:
> V2:
> Add BugLink.
>
> [Impact]
> On some thinkpad laptops, Realtek USB3.0 Card Reader [0bda:0328] reports wrong port status on
> Cannon lake PCH USB3.1 xHCI [8086:a36d] after resume from S3, then kernel hang.
>
> [Fix]
> Restrict the USB2 resume status check in USB2 roothub to fix hang issue.
>
> [Test Case]
> Suspend/resume 30 times OK.
>
> [Regression Potential]
> Low, upstream fix backported/cherry-picked.
>
> These 2 patches are already Cc: stable@vger.kernel.org, cosmic and future kernel will get these 2 patches.
>
> Aaron Ma (2):
>   usb: xhci: fix uninitialized completion when USB3 port got wrong
>     status
>   usb: xhci: fix timeout for transition from RExit to U0
>
>  drivers/usb/host/xhci-hub.c  | 6 +++---
>  drivers/usb/host/xhci-ring.c | 2 +-
>  drivers/usb/host/xhci.h      | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
>

Applied to bionic/master-next branch.

Thanks,
Kleber