| Message ID | 20181016185237.6196-1-manoj.iyer@canonical.com |
|---|---|
| Headers | show |
| Series | CPPC: bug fixes | expand |
On 10/16/18 20:52, Manoj Iyer wrote: > Please consider the following patch set for SRU in Bionic for CPPC bug > fixes from upstream, these patches are clean cherry-picks. > > CPPC bug fixes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1796949 > > The CPPC feature needs to be explicitly enabled in Firmware (default is > disabled) for these patches to be in effect. > > I have build a kernel and regression tested on Cavium Thunder X2 CN99XX > system. For test kernel, and detailed test results. please refer to the > comments in the bug report. > > > All clean cherry-picks, limited to platform driver and tested. My only comment is regarding the missing S-O-B on patch 1/3, which can be fixed while applying it. Acked-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
On 16.10.18 20:52, Manoj Iyer wrote: > Please consider the following patch set for SRU in Bionic for CPPC bug > fixes from upstream, these patches are clean cherry-picks. > > CPPC bug fixes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1796949 > > The CPPC feature needs to be explicitly enabled in Firmware (default is > disabled) for these patches to be in effect. > > I have build a kernel and regression tested on Cavium Thunder X2 CN99XX > system. For test kernel, and detailed test results. please refer to the > comments in the bug report. > > > Acked-by: Stefan Bader <stefan.bader@canonical.com> As Kleber mentioned the s-o-b for patch #1 needs to be added. Also, though it does not strictly matter, we should probably use the form https://bugs.launchpad.net/bugs/# for all BugLinks we do. Since I am not sure how flexible the scraper is it might actually matter. -Stefan
Added missing S-O-B On 2018-10-16 13:52:34 , Manoj Iyer wrote: > Please consider the following patch set for SRU in Bionic for CPPC bug > fixes from upstream, these patches are clean cherry-picks. > > CPPC bug fixes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1796949 > > The CPPC feature needs to be explicitly enabled in Firmware (default is > disabled) for these patches to be in effect. > > I have build a kernel and regression tested on Cavium Thunder X2 CN99XX > system. For test kernel, and detailed test results. please refer to the > comments in the bug report. > > > > -- > kernel-team mailing list > kernel-team@lists.ubuntu.com > https://lists.ubuntu.com/mailman/listinfo/kernel-team
On 10/23/18 08:30, Khaled Elmously wrote: > Added missing S-O-B The BugLink url hasn't been fixed at first, so I fixed it on all 3 patches and force pushed the branch. Thanks, Kleber > > > On 2018-10-16 13:52:34 , Manoj Iyer wrote: >> Please consider the following patch set for SRU in Bionic for CPPC bug >> fixes from upstream, these patches are clean cherry-picks. >> >> CPPC bug fixes: https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1796949 >> >> The CPPC feature needs to be explicitly enabled in Firmware (default is >> disabled) for these patches to be in effect. >> >> I have build a kernel and regression tested on Cavium Thunder X2 CN99XX >> system. For test kernel, and detailed test results. please refer to the >> comments in the bug report. >> >> >> >> -- >> kernel-team mailing list >> kernel-team@lists.ubuntu.com >> https://lists.ubuntu.com/mailman/listinfo/kernel-team >