From patchwork Mon Jan 27 12:09:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Heimes X-Patchwork-Id: 1229719 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (no SPF record) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 485pTB45Blz9sR1; Mon, 27 Jan 2020 23:09:32 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1iw3Cn-00054z-TZ; Mon, 27 Jan 2020 12:09:25 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iw3Cm-00054s-J3 for kernel-team@lists.ubuntu.com; Mon, 27 Jan 2020 12:09:24 +0000 Received: from 2.general.fheimes.uk.vpn ([10.172.194.67] helo=T570.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_CBC_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1iw3Cm-0005CG-8u for kernel-team@lists.ubuntu.com; Mon, 27 Jan 2020 12:09:24 +0000 From: frank.heimes@canonical.com To: kernel-team@lists.ubuntu.com Subject: [SRU][B][E][F][PATCH 0/2] Fix misleading error message: Configuring the VNIC characteristics failed (LP: 1860523) Date: Mon, 27 Jan 2020 14:09:02 +0200 Message-Id: <1580126944-30768-1-git-send-email-frank.heimes@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" Buglink: https://bugs.launchpad.net/bugs/1860523 SRU Justification: [Impact] * For devices that don't support the 'INVISIBLE' characteristic (ie. OSA), the resulting IO failure raises the noisy error message "Configuring the VNIC characteristics failed" * The INVISIBLE characteristic unconditionally gets switched off, which is reverted with this patch. * For Internal Queued Direct communication (IQD) 'INVISIBLE' is off by default. * Hence the INVISIBLE characteristic case is unnecessary. [Fix] * 68c57bfd52836e31bff33e5e1fc64029749d2c35 68c57bf "s390/qeth: fix false reporting of VNIC CHAR config failure" * Upstream accepted with v5.5-rc5, but backport for 4.19-stable and 5.4-stable here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git [Test Case] * Configure an IBM z15 for LinuxONE III machine with at least one OSA adapter. * Check dmsg for message "Configuring the VNIC characteristics failed" while setting an OSA device online. [Regression Potential] * The regression potential is low, since the patch is limited to a single line * again linited to the s390x architecture and once again limited to the qeth network driver * and on z15 hardware only. [Other Info] * This bug was identified at IBM while testing and is now rolled out to several different kernels. * Once the patch got applied to the Ubuntu kernel(s) and a verification is required, * this needs to be done by IBM, since Canonical doesn't have the needed machine generation. Alexandra Winter (1): s390/qeth: fix false reporting of VNIC CHAR config failure drivers/s390/net/qeth_l2_main.c | 1 - 1 file changed, 1 deletion(-) Acked-by: Khalid Elmously Acked-by: Marcelo Henrique Cerri