mbox series

[SRU,B,E,F,0/2] Fix misleading error message: Configuring the VNIC characteristics failed (LP: 1860523)

Message ID 1580126944-30768-1-git-send-email-frank.heimes@canonical.com
Headers show
Series Fix misleading error message: Configuring the VNIC characteristics failed (LP: 1860523) | expand

Message

Frank Heimes Jan. 27, 2020, 12:09 p.m. UTC
Buglink: https://bugs.launchpad.net/bugs/1860523

SRU Justification:

[Impact]

* For devices that don't support the 'INVISIBLE' characteristic (ie. OSA), the resulting IO failure raises the noisy error message "Configuring the VNIC characteristics failed"

* The INVISIBLE characteristic unconditionally gets switched off, which is reverted with this patch.

* For Internal Queued Direct communication (IQD) 'INVISIBLE' is off by default.

* Hence the INVISIBLE characteristic case is unnecessary.

[Fix]

* 68c57bfd52836e31bff33e5e1fc64029749d2c35 68c57bf "s390/qeth: fix false reporting of VNIC CHAR config failure"

* Upstream accepted with v5.5-rc5, but backport for 4.19-stable and 5.4-stable here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git

[Test Case]

* Configure an IBM z15 for LinuxONE III machine with at least one OSA adapter.

* Check dmsg for message "Configuring the VNIC characteristics failed" while setting an OSA device online.

[Regression Potential]

* The regression potential is low, since the patch is limited to a single line

* again linited to the s390x architecture and once again limited to the qeth network driver

* and on z15 hardware only.

[Other Info]

* This bug was identified at IBM while testing and is now rolled out to several different kernels.

* Once the patch got applied to the Ubuntu kernel(s) and a verification is required,

* this needs to be done by IBM, since Canonical doesn't have the needed machine generation.

Alexandra Winter (1):
  s390/qeth: fix false reporting of VNIC CHAR config failure

 drivers/s390/net/qeth_l2_main.c | 1 -
 1 file changed, 1 deletion(-)

Comments

Khaled Elmously Jan. 28, 2020, 6:19 p.m. UTC | #1
On 2020-01-27 14:09:02 , frank.heimes@canonical.com wrote:
> Buglink: https://bugs.launchpad.net/bugs/1860523
> 
> SRU Justification:
> 
> [Impact]
> 
> * For devices that don't support the 'INVISIBLE' characteristic (ie. OSA), the resulting IO failure raises the noisy error message "Configuring the VNIC characteristics failed"
> 
> * The INVISIBLE characteristic unconditionally gets switched off, which is reverted with this patch.
> 
> * For Internal Queued Direct communication (IQD) 'INVISIBLE' is off by default.
> 
> * Hence the INVISIBLE characteristic case is unnecessary.
> 
> [Fix]
> 
> * 68c57bfd52836e31bff33e5e1fc64029749d2c35 68c57bf "s390/qeth: fix false reporting of VNIC CHAR config failure"
> 
> * Upstream accepted with v5.5-rc5, but backport for 4.19-stable and 5.4-stable here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git
> 
> [Test Case]
> 
> * Configure an IBM z15 for LinuxONE III machine with at least one OSA adapter.
> 
> * Check dmsg for message "Configuring the VNIC characteristics failed" while setting an OSA device online.
> 
> [Regression Potential]
> 
> * The regression potential is low, since the patch is limited to a single line
> 
> * again linited to the s390x architecture and once again limited to the qeth network driver
> 
> * and on z15 hardware only.
> 
> [Other Info]
> 
> * This bug was identified at IBM while testing and is now rolled out to several different kernels.
> 
> * Once the patch got applied to the Ubuntu kernel(s) and a verification is required,
> 
> * this needs to be done by IBM, since Canonical doesn't have the needed machine generation.
> 
> Alexandra Winter (1):
>   s390/qeth: fix false reporting of VNIC CHAR config failure
> 
>  drivers/s390/net/qeth_l2_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 

Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Marcelo Henrique Cerri Jan. 28, 2020, 6:22 p.m. UTC | #2
Acked-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
Khaled Elmously Jan. 28, 2020, 6:28 p.m. UTC | #3
On 2020-01-27 14:09:02 , frank.heimes@canonical.com wrote:
> Buglink: https://bugs.launchpad.net/bugs/1860523
> 
> SRU Justification:
> 
> [Impact]
> 
> * For devices that don't support the 'INVISIBLE' characteristic (ie. OSA), the resulting IO failure raises the noisy error message "Configuring the VNIC characteristics failed"
> 
> * The INVISIBLE characteristic unconditionally gets switched off, which is reverted with this patch.
> 
> * For Internal Queued Direct communication (IQD) 'INVISIBLE' is off by default.
> 
> * Hence the INVISIBLE characteristic case is unnecessary.
> 
> [Fix]
> 
> * 68c57bfd52836e31bff33e5e1fc64029749d2c35 68c57bf "s390/qeth: fix false reporting of VNIC CHAR config failure"
> 
> * Upstream accepted with v5.5-rc5, but backport for 4.19-stable and 5.4-stable here: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git
> 
> [Test Case]
> 
> * Configure an IBM z15 for LinuxONE III machine with at least one OSA adapter.
> 
> * Check dmsg for message "Configuring the VNIC characteristics failed" while setting an OSA device online.
> 
> [Regression Potential]
> 
> * The regression potential is low, since the patch is limited to a single line
> 
> * again linited to the s390x architecture and once again limited to the qeth network driver
> 
> * and on z15 hardware only.
> 
> [Other Info]
> 
> * This bug was identified at IBM while testing and is now rolled out to several different kernels.
> 
> * Once the patch got applied to the Ubuntu kernel(s) and a verification is required,
> 
> * this needs to be done by IBM, since Canonical doesn't have the needed machine generation.
> 
> Alexandra Winter (1):
>   s390/qeth: fix false reporting of VNIC CHAR config failure
> 
>  drivers/s390/net/qeth_l2_main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> -- 
> 2.7.4
> 
> 
> -- 
> kernel-team mailing list
> kernel-team@lists.ubuntu.com
> https://lists.ubuntu.com/mailman/listinfo/kernel-team