From patchwork Tue Jun 18 07:03:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Heimes X-Patchwork-Id: 1117650 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 45SfF92zTZz9sDX; Tue, 18 Jun 2019 17:03:40 +1000 (AEST) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1hd89S-0003UE-Ft; Tue, 18 Jun 2019 07:03:30 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1hd89R-0003U8-GI for kernel-team@lists.ubuntu.com; Tue, 18 Jun 2019 07:03:29 +0000 Received: from 2.general.fheimes.uk.vpn ([10.172.194.67] helo=localhost.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1hd89R-0003kG-3X for kernel-team@lists.ubuntu.com; Tue, 18 Jun 2019 07:03:29 +0000 From: frank.heimes@canonical.com To: kernel-team@lists.ubuntu.com Subject: [SRU][B][C][D][Patch 0/1] pkey: Indicate old mkvp only if old and current mkvp are different (LP: 1832625) Date: Tue, 18 Jun 2019 09:03:06 +0200 Message-Id: <1560841387-920-1-git-send-email-frank.heimes@canonical.com> X-Mailer: git-send-email 2.7.4 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" Buglink: https://bugs.launchpad.net/bugs/1832625 SRU Justification: [Impact] * 'zkey validate' shows wrong information about master key registers * this might lead to unsuccessful usage of pkeys, although the master key and the derived keys are correct [Fix] * ebb7c695d3bc7a4986b92edc8d9ef43491be183e ebb7c69 "pkey: Indicate old mkvp only if old and current mkvp are different" [Test Case] * set a CCA master key * generate a pkey * 'change' (or better set) the current CCA master key to the exact same master key again which is currently in use * execute a 'zkey validate' [Regression Potential] * The regression potential can be considered as very low since this is purely s390x specific * changes are limited to a single file (drivers/s390/crypto/pkey_api.c) * patch changes only one line (actually expands an if stmt) * and all this happens only in a very specific situation (in case a new master key was set, using the same key as before) [Other Info] * Problem was found during tests at IBM and is a so called 'preventive fix' Ingo Franzki (1): From: Ingo Franzki drivers/s390/crypto/pkey_api.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)